Repository navigation
docs: update implementation backlog for the contrast solver replacement - #232
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 7, 2026
This was referenced Oct 8, 2026
pbroom
force-pushed
the
docs/backlog-contrast-engine-history
branch
from
October 8, 2026 17:04
9e41c06 to
fd82f77
Compare
This was referenced Oct 9, 2026
pbroom
force-pushed
the
refactor/react-color-plane-remove-deprecated
branch
from
October 10, 2026 02:39
1ffb2c5 to
343d359
Compare
pbroom
force-pushed
the
docs/backlog-contrast-engine-history
branch
from
October 10, 2026 02:39
fd82f77 to
5e94eff
Compare
Owner
Author
pbroom
added a commit
that referenced
this pull request
Oct 10, 2026
getColorAreaFallbackPoint silently mapped any unknown gamut, such as the removed 'p3' spelling, to sRGB while every core entry point throws. It now calls core's assertGamutTarget, so the TypeError wording is identical and ends "'p3' is not supported; use 'display-p3'". Validator placement: routing through the core plane fallbackPoint query would change behaviour (it forces a finite hue and returns unclamped plane coordinates, while the driver returns clamped, y-flipped UI coordinates for any axes). The repo has no `./gamut` subpath, and adding one would widen the package export map, tsup entries and facade. assertGamutTarget is therefore exported from the existing `./plane` subpath, which already owns the gamut-taking queries, and not from the root barrel. lint, build, test, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict all pass on this branch. Part of the color-kit assessment stack (#204 → #232). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
pbroom
changed the base branch from
refactor/react-color-plane-remove-deprecated
to
graphite-base/232
October 10, 2026 19:54
pbroom
added a commit
that referenced
this pull request
Oct 10, 2026
…l renderer alias (#231) Hard cut-over, no aliases left behind: - Remove the deprecated `outOfGamut` prop and the exported `ColorPlaneOutOfGamutConfig` type. `edgeBehavior` is now the only way to choose the out-of-gamut edge treatment (default 'clamp'). - Remove `'webgl'` from `ColorPlaneRenderer` and delete the runtime mapping (and its one-time console warning) that resolved it to 'gpu'. - Drop the two tests that exercised the removed options. - Correct the docs API table, which listed the `edgeBehavior` default as 'transparent'; the component default is 'clamp'. ColorPlane has no runtime prop validation, so none is added; the old values are now TypeScript errors. The `renderer="canvas2d"` alias is separate and unchanged. BREAKING CHANGE: ColorPlane no longer accepts `outOfGamut` or `renderer="webgl"`. lint, build, test, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict all pass on this branch. Part of the color-kit assessment stack (#204 → #232). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
IB-006 still described the legacy marching-squares and hybrid contrast engines as current. Mark them as replaced with PR references (#223 retired the legacy engine, #228 replaced the hybrid solver with the ray-based solver in contrast/region-solver.ts), record the new options and the removed ones, and list the two open follow-ups: 7 tiny P3 APCA pieces missed by the single-extremum scan, and ContrastRegionLayer still gamut-mapping its reference. The repo-wide sweep for region-legacy, region-hybrid, hybridMaxDepth, samplingMode and "legacy engine" found no other docs describing the removed engines as current; remaining hits are removal notices, changelog entries or the still-supported gamut/chroma-band samplingMode. Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
force-pushed
the
docs/backlog-contrast-engine-history
branch
from
October 10, 2026 19:56
5e94eff to
6411a19
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IB-006 still described the legacy marching-squares and hybrid contrast
engines as current. Mark them as replaced with PR references (#223 retired
the legacy engine, #228 replaced the hybrid solver with the ray-based
solver in contrast/region-solver.ts), record the new options and the
removed ones, and list the two open follow-ups: 7 tiny P3 APCA pieces
missed by the single-extremum scan, and ContrastRegionLayer still
gamut-mapping its reference.
The repo-wide sweep for region-legacy, region-hybrid, hybridMaxDepth,
samplingMode and "legacy engine" found no other docs describing the removed
engines as current; remaining hits are removal notices, changelog entries or
the still-supported gamut/chroma-band samplingMode.
lint, build, test, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict all pass on this branch.
Part of the color-kit assessment stack (#204 → #232).
🤖 Generated with Claude Code