[pbroom]

parse('#gggggg') returned { l: NaN, c: NaN, h: NaN } because hexToRgb
never validated its digits, toHex then emitted "#NaNNaNNaN", inputs such
as rgb(1.2.3 0 0) were accepted, and toCss silently fell back to hex for
unknown formats.

• hexToRgb validates length (3/4/6/8) and digits and throws otherwise.
• parse moves to conversion/parse.ts and validates every component token
  against the CSS grammar, so malformed numbers throw and
  components that overflow to Infinity (1e999) throw too.
• New tryParse(input): Color | null, exported from the root. A nullable
  return matches the existing parseColorStringInputValue helper in
  @color-kit/driver and keeps the hot path allocation-free; a result
  object would add API surface without carrying more than the error
  message, which parse already provides.
• toCss takes a CssColorFormat string-literal union and throws a
  TypeError for unknown formats at runtime. @color-kit/react's
  requestedCss/displayedCss callbacks now take CssColorFormat.
• toHex, toCss and rgbToHex throw a RangeError for non-finite channels
  instead of emitting NaN digits.
• Tests include fast-check properties: arbitrary garbage never parses to
  a non-finite Color, and tryParse never throws.

Bundle size: parse + toHex + contrastRatio 2.32 kB -> 2.64 kB (limit
2.7 kB, unchanged).

Part of a stacked set of PRs (#204 → #221) from the color-kit assessment. Validated per branch with pnpm build and pnpm test; lint, format, typecheck, size, artifact, preprod and agents checks pass at the top of the stack.

🤖 Generated with Claude Code

[pbroom]

• refactor(react)!: remove UI components; ship state and plane hooks only #249
• docs(react): rebuild the React docs around the plane hooks #248
• feat(react): add plane renderer, geometry and adaptive-quality hooks #247
• feat(docs): syntax highlighting palette for code samples #246
• feat(docs): native API map at /api/map #245
• docs: add concept pages, guides and entry-point narratives #244
• feat(docs): live plane hero on home and the example system #243
• feat(docs): generated API reference from TypeDoc JSON #242
• refactor(core)!: derive plane query budgets from step counts and drop PlaneWithSense #241
• fix(react): render input aria-label once, on the inner input #240
• fix(driver): map absolute percents as range positions and keep tiny-step precision #239
• fix(core): uncap saturate chroma and resolve planeHue as an OKLCH hue #238
• fix(driver): reject unknown gamuts and align validation error types #237
• chore(docs): remove Sandpack, the shadcn kit and the legacy docs shell #236
• docs(core,driver,react): document the public API #235
• chore: pin control-kit to a commit with its own pnpm workspace #234
• docs: update implementation backlog for the contrast solver replacement #232
• refactor(react)!: remove ColorPlane's deprecated edge option and webgl renderer alias #231
• fix(driver): validate the gamut in getColorAreaFallbackPoint #230
• feat(driver,react): keep the previous hue when an achromatic color is entered #229
• refactor(core)!: replace the hybrid contrast solver with chroma-column tracing #228
• perf(core): trim what contrastRatio pulls in #227
• perf(core): pack the named-color table #226
• feat(core): point 'p3' users to 'display-p3' #225
• chore: ignore local .claude files in prettier #224
• refactor(core)!: retire the legacy contrast-region engine #223
• fix(core): keep hybrid contrast contours connected through folds #222
• chore: add changesets for the assessment stack #221
• docs: generated API reference and repo polish #220
• chore: adopt changesets for versioning and release notes #219
• chore: fix facade peers, licensing, and lint ignores #218
• refactor(react): reuse core contrast and transfer functions #217
• refactor(core)!: make the contrast-region engine explicit #216
• refactor(core)!: remove pre-launch aliases and trim the root export surface #215
• refactor!: name the Display P3 space 'display-p3' everywhere #214
• refactor(driver): share pointer drag throttling between slider and area #213
• feat(react): keyboard, ARIA, disabled, and focus support for sliders and areas #212
• fix(react): stable refs, WebGL context loss, and handler composition #211
• fix(react): apply controlled updates against the latest snapshot #210
• feat(core): selectable gamut mapping method #209
• fix(core): compute contrast from unrounded values #208
• fix(core): consistent achromatic hue handling and single transfer function #207
• feat(core): parse CSS Color 4 syntax #206
• fix(core): reject malformed color input instead of producing NaN #205 👈 (View in Graphite)
• chore: add fast-check and axe-core test dependencies #204
• docs: graphics and performance APIs demo page #203
• feat(core): tuple and typed-array interop for GPU and three.js #202
• feat(core): allocation-free *Into variants for hot paths #201
• feat(core): interpolation space option for mix/interpolate/generateScale #200
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[greptile-apps]

Confidence Score: 4/5

[Medium risk] Adds input validation to color parsing and serialization.

The PR should not merge until parsing rejects colors that become non-finite during conversion.

Findings

1.  Conversion can return infinite chroma ▶

Summary

The PR validates hex digits and CSS color components, adds nullable tryParse(), rejects non-finite serializer inputs and unknown CSS output formats, and narrows React formatting callback types. One conversion path can still return a non-finite color from finite input tokens.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Input["OKLab text input"] --> Token["Validate finite component tokens"]
  Token --> Convert["Convert OKLab to OKLCH"]
  Convert --> Result["parse returns Color"]
  Result --> TryParse["tryParse returns Color"]
  Convert -. "Large finite components can overflow here" .-> Result

Loading

_{Reviews (1) · Last reviewed commit: "fix(core): reject malformed color input ..."}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
color-kit	Ready	Preview	Oct 10, 2026 6:58pm UTC

[pbroom]

Merge activity

• Oct 10, 6:47 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Oct 10, 6:57 PM UTC: Graphite rebased this pull request as part of a merge.
• Oct 10, 6:58 PM UTC: @pbroom merged this pull request with Graphite.