Repository navigation
fix(react): render input aria-label once, on the inner input - #240
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
828ff34 to
c4ecbe2
Compare
ffc6a15 to
38b646c
Compare
c4ecbe2 to
f97dacf
Compare
38b646c to
d9bdd09
Compare
d9bdd09 to
e3a0a11
Compare
pbroom
left a comment
pbroom
left a comment
There was a problem hiding this comment.
Reviewed the full incremental PR and its corrections at e3a0a11fa65a0e88c52a4bdfa203a49606486a4f. ARIA label rendering reviewed; accessible-name assertions added. No remaining actionable findings in the reviewed scope.
Independent correction re-reviews and stack preservation verification passed. At the integrated tip, lint, full build/DTS, 2,208 tests, formatting, strict agent checks and 14 built-site Chrome tests passed. All recorded actionable review threads are addressed. Hosted CI is being verified separately; this review does not authorize merge or release.
e3a0a11 to
ff99bfe
Compare
ColorInput and ColorStringInput spread the rest props (including aria-label) onto the wrapper div and also set aria-label on the inner input, so a consumer label was rendered twice. aria-label and aria-labelledby are now taken out of the rest props and applied only to the inner input; a consumer label replaces the default, and aria-labelledby alone suppresses the default aria-label. Co-Authored-By: Claude Opus 5.5 <[email protected]>
ff99bfe to
e4afb83
Compare
This branch was successfully deployed
1 participant
ColorInput and ColorStringInput spread the rest props (including
aria-label) onto the wrapper div and also set aria-label on the inner
input, so a consumer label was rendered twice. aria-label and
aria-labelledby are now taken out of the rest props and applied only to
the inner input; a consumer label replaces the default, and
aria-labelledby alone suppresses the default aria-label.
Found while documenting the public API in #235. Each finding was reproduced against the built package before the fix, has a regression test, and its affected JSDoc examples were recomputed. lint, build, test, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict pass.
Part of the color-kit assessment stack.
🤖 Generated with Claude Code