Repository navigation
feat(core): point 'p3' users to 'display-p3' - #225
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 6, 2026
Owner
Author
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This was referenced Oct 8, 2026
Owner
Author
pbroom
changed the base branch from
chore/prettier-ignore-claude
to
graphite-base/225
October 10, 2026 19:37
pbroom
added a commit
that referenced
this pull request
Oct 10, 2026
Part of the color-kit assessment stack (#204 → #225). lint, build, test, format:check, typecheck and agents:check:strict pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Validating the gamut in contrastRatio pushed the parse and everyday bundles past their limits. Shorten the gamut error message and raise the parse budget to the approved 5.5 kB (everyday toolkit 5.55 kB, keeping its usual 0.05 kB offset). Co-Authored-By: Claude Opus 5.5 <[email protected]>
mix/interpolate (and their Into variants) returned exact endpoints before validating the space, so t = 0 or 1 (and generateScale with two stops) accepted the removed 'p3'. chromaBand, contrastBoundary and contrastRegion queries returned empty geometry on non-L×C planes before checking the gamut. Validate first in both cases and cover them in tests. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Measured 5.51 kB and 5.56 kB gzipped; the next branch's named-color packing brings both back under the approved 5.5 kB / 5.55 kB, where the budgets are restored. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Measured 5.57 kB and 5.62 kB gzipped; perf/core-size-budget restores the approved 5.5 kB / 5.55 kB. Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
force-pushed
the
feat/core-p3-hint
branch
from
October 10, 2026 19:39
03a0e16 to
ee62764
Compare
pbroom
added a commit
that referenced
this pull request
Oct 10, 2026
oklab.ts destructured all four OKLab matrices into row constants at module scope. Bundlers keep top-level destructuring even when nothing reads it, so any bundle that needed only one direction (contrastRatio needs OKLab -> linear sRGB; parse needs only the reverse) carried the other two matrices too. Read the rows inside each kernel instead; the arithmetic is unchanged, so results are bit-identical. Gzip, size-limit (on top of #225 in parentheses): contrastRatio alone: 1310 -> 1096 B (1466 -> 1243 B) parse alone: 4565 -> 4346 B parse + toHex + contrastRatio: 5233 -> 5225 B (5358 -> 5354 B) everyday toolkit: 5281 -> 5275 B (5412 -> 5405 B) packColors + unpackColors: 2317 -> 2277 B Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
added a commit
that referenced
this pull request
Oct 10, 2026
oklab.ts destructured all four OKLab matrices into row constants at module scope. Bundlers keep top-level destructuring even when nothing reads it, so any bundle that needed only one direction (contrastRatio needs OKLab -> linear sRGB; parse needs only the reverse) carried the other two matrices too. Read the rows inside each kernel instead; the arithmetic is unchanged, so results are bit-identical. Gzip, size-limit (on top of #225 in parentheses): contrastRatio alone: 1310 -> 1096 B (1466 -> 1243 B) parse alone: 4565 -> 4346 B parse + toHex + contrastRatio: 5233 -> 5225 B (5358 -> 5354 B) everyday toolkit: 5281 -> 5275 B (5412 -> 5405 B) packColors + unpackColors: 2317 -> 2277 B Part of the color-kit assessment stack (#204 → #227). Build, test, lint, typecheck, format, size and check:artifacts pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the color-kit assessment stack (#204 → #225). lint, build, test, format:check, typecheck and agents:check:strict pass.
🤖 Generated with Claude Code