Skip to content

chore: fix facade peers, licensing, and lint ignores - #218

Merged
pbroom merged 2 commits into
mainfrom
chore/packaging-and-licensing
Oct 10, 2026
Merged

pbroom merged 2 commits into
mainfrom
chore/packaging-and-licensing

Conversation

@pbroom

@pbroom pbroom commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner
  • Drop the unused @base-ui/react and radix-ui peers from the color-kit
    facade (nothing in dist imports them) and stop shipping the
    color-kit/react/color-input subpath, which needs the unpublished
    @color-kit/control-kit. ColorInput stays in @color-kit/react and docs,
    with a note that it is not in the published package yet.
  • Ship LICENSE (copied from the root at build) and THIRD_PARTY_NOTICES.md
    (Apache-2.0 notice for the bundled Material color utilities) in the
    tarball; move @material/material-color-utilities to core devDependencies
    since tsup inlines it.
  • check-artifacts now asserts the license files, the absent color-input
    entry, and that dist only imports declared peers.
  • Correct the "zero-dependency core" claim in DESIGN.md.
  • Ignore .claude/ in ESLint and .claude/worktrees/ in git.
  • Silence esbuild's expected ignored-bare-import warnings in pnpm size via a
    .size-limit.js wrapper around the existing JSON budgets.

Part of a stacked set of PRs (#204 → #221) from the color-kit assessment. Validated per branch with pnpm build and pnpm test; lint, format, typecheck, size, artifact, preprod and agents checks pass at the top of the stack.

🤖 Generated with Claude Code

pbroom commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Removes unpublished component from published package exports.

The PR appears safe to merge, though CI should run the new artifact assertions to catch packaging regressions earlier.

Fix All in CursorFindings

  1. P2 New checks bypassed in CI ▶

Summary

The PR removes the unpublished ColorInput facade entry and unused peers, adds license notices to the package, and updates docs, artifact validation, and size-check configuration.

  • The new artifact assertions are not included in CI’s artifact-validation step.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Build[Facade build] --> Dist[Published dist]
  Build --> License[Copied LICENSE]
  Notice[THIRD_PARTY_NOTICES.md] --> Package[Package tarball]
  Dist --> Package
  License --> Package
  CI[CI artifact step] --> Metadata[Metadata checks only]
  Release[Release verification] --> Assertions[New artifact assertions]
Loading

Reviews (1) · Last reviewed commit: "chore: fix facade peers, licensing, and ..."

Comment thread packages/color-kit/scripts/check-artifacts.mjs
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
color-kit Ready Ready Preview Oct 10, 2026 7:26pm UTC

@pbroom
pbroom force-pushed the refactor/react-shared-color-math branch from 1ea17cd to 903c45b Compare October 8, 2026 02:44
@pbroom
pbroom force-pushed the chore/packaging-and-licensing branch from 162a719 to 3889ffa Compare October 8, 2026 02:44

pbroom commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner Author

Merge activity

  • Oct 10, 6:47 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 7:26 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 10, 7:26 PM UTC: @pbroom merged this pull request with Graphite.

@pbroom
pbroom changed the base branch from refactor/react-shared-color-math to graphite-base/218 October 10, 2026 19:23
@pbroom
pbroom changed the base branch from graphite-base/218 to main October 10, 2026 19:24
pbroom and others added 2 commits October 10, 2026 19:25
- Drop the unused @base-ui/react and radix-ui peers from the color-kit
  facade (nothing in dist imports them) and stop shipping the
  `color-kit/react/color-input` subpath, which needs the unpublished
  @color-kit/control-kit. ColorInput stays in @color-kit/react and docs,
  with a note that it is not in the published package yet.
- Ship LICENSE (copied from the root at build) and THIRD_PARTY_NOTICES.md
  (Apache-2.0 notice for the bundled Material color utilities) in the
  tarball; move @material/material-color-utilities to core devDependencies
  since tsup inlines it.
- check-artifacts now asserts the license files, the absent color-input
  entry, and that dist only imports declared peers.
- Correct the "zero-dependency core" claim in DESIGN.md.
- Ignore .claude/ in ESLint and .claude/worktrees/ in git.
- Silence esbuild's expected ignored-bare-import warnings in pnpm size via a
  .size-limit.js wrapper around the existing JSON budgets.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
CI only ran check:artifacts:metadata, skipping the license, excluded
entry and undeclared-peer checks in check-artifacts.mjs.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@pbroom
pbroom force-pushed the chore/packaging-and-licensing branch from 3889ffa to ce02143 Compare October 10, 2026 19:25
@pbroom
pbroom merged commit f87804e into main Oct 10, 2026
6 of 7 checks passed
@pbroom
pbroom deleted the chore/packaging-and-licensing branch October 10, 2026 19:26

This branch was successfully deployed

1 active deployment
Preview — ce021433 Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant