Repository navigation
chore(docs): remove Sandpack, the shadcn kit and the legacy docs shell - #236
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 8, 2026
This was referenced Oct 8, 2026
pbroom
force-pushed
the
docs/s0-jsdoc-and-surface
branch
from
October 8, 2026 17:04
251e098 to
34a1680
Compare
pbroom
commented
Oct 8, 2026
pbroom
left a comment
pbroom
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the full incremental PR and its corrections at fe27c4eeaa27e1865e34511ec75077db7e7ff5cb. Shell reviewed; focus, breakpoint, route-error landmark, storage, search failures, emitted contrast and favicon/smoke corrected. No remaining actionable findings in the reviewed scope.
Independent correction re-reviews and stack preservation verification passed. At the integrated tip, lint, full build/DTS, 2,208 tests, formatting, strict agent checks and 14 built-site Chrome tests passed. All recorded actionable review threads are addressed. Hosted CI is being verified separately; this review does not authorize merge or release.
This was referenced Oct 9, 2026
pbroom
force-pushed
the
docs/s0-jsdoc-and-surface
branch
from
October 10, 2026 02:39
b5e0f78 to
92d5ace
Compare
Owner
Author
pbroom
changed the base branch from
docs/s0-jsdoc-and-surface
to
graphite-base/236
October 10, 2026 20:01
Delete vendor/sandpack and every Sandpack consumer, the shadcn UI kit, legacy-docs.css/docs.css, the inspector and right rail, the component-doc route and its data, and components.json. Move the graphics demos to src/examples/interop/graphics and park the old MDX under src/content/_legacy (unrouted) for the content slices to mine. Swap dependencies up front for the overhaul: drop radix-ui, @radix-ui/*, cva, lz-string, tw-animate-css, tailwind-merge and @tailwindcss/typography; add remark-frontmatter, remark-mdx-frontmatter, rehype-slug, self-hosted Inter and JetBrains Mono, d3-hierarchy, d3-shape, pagefind, vitest, vite-node, yaml, @playwright/test and @axe-core/playwright. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…rerender - Tokens: src/styles/tokens.ts generates tokens.css with color-kit (toSrgbGamut/toCss fallbacks, display-p3 overrides): achromatic --gray-0..12, one P3 accent, dark theme on [data-theme=dark], type and grid scales. A vitest suite checks the CSS is in sync and every text/UI pair with contrastRatio (4.5 / 3). - Shell: header (wordmark, search, theme toggle, GitHub), filterable sidebar in package order with a Base UI drawer below 960 px, 680/920 px content grid, On this page at 1280 px, footer display-gamut readout, skip link, focus ring tokens, reduced motion. - Routes: src/site/routes.ts is driven by MDX frontmatter globs plus an API route index hook (fixture until S2 drops src/generated/api.json). - MDX contracts: Example, Signature, Swatch/GamutBadge, Callout, CodeBlock (Shiki CSS-variables theme), InstallLine; plugins for ?highlighted and ?frontmatter imports. - Prerender: entry-server + scripts/prerender.mjs write dist/<route>/index.html with per-route meta and modulepreloads; the client loads the route chunk before hydrateRoot. - Search: lazy Base UI dialog, symbol slot plus Pagefind prose search. - Budgets: chunk <= 200 kB, home JS <= 110 kB gzip, enforced in build. - vercel.json with clean URLs and redirects from /docs/* and /reference. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice S1 of the docs overhaul: the foundation for an API-first site. It replaces the shadcn component gallery with a "precision instrument" shell. Per the overhaul plan, content pages arrive in S2–S5.
Built
tokens.tsgeneratestokens.cssusing color-kit itself. Achromatic neutrals, one P3 accent with sRGB fallbacks, and self-hosted Inter and JetBrains Mono. A test checks 32 contrast pairs per theme.src/site/routes.ts), with a hook for the generated API data (a fixture until S2).react-dom/static(dist/<route>/index.html) and hydrated without warnings. Search is Pagefind, loaded lazily.src/components/ui/:<Example>,<Signature>,<Swatch>/<GamutBadge>,<Callout>,<CodeBlock>,<InstallLine>, and?highlightedsource imports.apps/docs/vercel.json: folds in chore(docs): add Vercel config with SPA rewrites and an out-of-repo pnpm store #233's install and build settings, plus clean URLs, redirects from the old/docs/*and/reference/*paths, and immutable asset caching. It deliberately has no SPA catch-all rewrite: every route is prerendered, and a catch-all would serve the home page with a 200 on typos. Vercel serves404.htmlinstead.Removed
386 files and about 48.6k lines:
vendor/sandpack(335 files), the shadcn kit, legacy CSS, the inspector and right rail, the component-doc pages and the old demos. Old MDX moved tosrc/content/_legacy/for S4 to draw on.Dependencies dropped: radix-ui, cva, lz-string, tw-animate-css, tailwind-merge, @tailwindcss/typography, Sandpack.
Budgets
vendor-reactat 194.8 kB (limit 200).Verified
Supersedes #233 once merged.
Part of the color-kit assessment stack (#204 → #236).
🤖 Generated with Claude Code