Repository navigation
feat(docs): live plane hero on home and the example system - #243
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7401630 to
e987661
Compare
89c7f6e to
00d4967
Compare
e987661 to
f2e5f6f
Compare
00d4967 to
dbb1238
Compare
pbroom
left a comment
There was a problem hiding this comment.
Reviewed the full incremental PR and its corrections at dbb123899603d3196da2d964fba6d65fa6064ad1. Examples/content reviewed; transitive evaluator invalidation and hero failed-download recovery corrected. No remaining actionable findings in the reviewed scope.
Independent correction re-reviews and stack preservation verification passed. At the integrated tip, lint, full build/DTS, 2,208 tests, formatting, strict agent checks and 14 built-site Chrome tests passed. All recorded actionable review threads are addressed. Hosted CI is being verified separately; this review does not authorize merge or release.
|
Hosted CI follow-up: the dependency invalidation regression failed on the published head (cached output after a transitive edit): https://github.com/pbroom/color-kit/actions/runs/37826729585. The two dependency threads are reopened while the author and independent reviewer diagnose it. Local success did not establish hosted success; correction and exact-head CI verification remain owned. |
pbroom
left a comment
There was a problem hiding this comment.
Final re-review at b3eb6234f03affa9404225e4439aae233951b387: Examples/content reviewed; transitive evaluator invalidation and hero failed-download recovery corrected. The hosted dependency-test follow-up is included; no remaining actionable findings in scope.
All 12 final stack heads now pass CI, including Node 20/22 and the plane benchmark. Final local lint, build/DTS, 2,209 tests, formatting and strict agent checks pass. The 14 built-site browser checks passed on unchanged application code; the follow-up changes only the regression test and archive lesson. Vercel previews are tracked separately while pending.
f2e5f6f to
1855790
Compare
b3eb623 to
3394969
Compare
Home: "A queryable OKLCH color engine." over a live hue slice of OKLCH (chroma x lightness). sense(plane) answers the sRGB region, the Display P3 boundary and WCAG AA regions on white and black (theme picks one in CSS); a 160x160 toP3Into loop paints a display-p3 canvas underneath. The first frame (hue 264) is computed in Node at build time via `?build`, so the SVG prerenders and hydrates from identical JSON while color-kit/plane loads lazily after hydration. Hue is a native range input (aria-valuetext) and a horizontal drag on the plane; work is rAF-throttled. The hero's own source is shown below it, plus the install line and three "what you can ask" links. Examples: <Example> now renders the live component over its build-time source (module or HTML), collapses long sources and isolates failures. plugins/eval-example.ts fills `// →` results by running snippets against color-kit source; documented in src/examples/README.md. Graphics demos get *Example wrappers; the old Sandpack plane quick start is a real example. Contract changes (backwards compatible): Example `source` also accepts the `?highlighted` module; new `collapseAfter`; `?build` imports; prerender links route-chunk CSS; ESLint allows bare expressions in example snippets. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
3394969 to
b1e7936
Compare
|
Deployment failed for project color-kit with the following error: Learn More: https://vercel.com/pbrooms-projects?upgradeToPro=build-rate-limit |
Summary
Docs overhaul slice S3: the live plane hero on the home page, plus the example system.
Home page
sense(plane)answers three queries:toP3Intoloop paints a display-p3 canvas.?build. The SVG prerenders and hydrates from the same JSON, andcolor-kit/planeloads lazily after hydration.aria-valuetext, or by dragging horizontally on the plane. Updates are rAF-throttled.Examples
<Example>renders the live component above its source, which is highlighted at build time. It collapses long sources and isolates failures.plugins/eval-example.tsfills in// →results by running each snippet against the color-kit source. This is documented insrc/examples/README.md.*Examplewrappers.src/examples/plane/quick-start.tsx.Contract changes (backwards compatible)
<Example>'ssourcealso accepts the?highlightedmodule.collapseAfterprop.?buildimports.Rebased onto #242 with no conflicts. The
eslint.config.jsand styles changes merged cleanly with S2's; theapi.cssimport and the example-snippet rule are both kept.Verified
pnpm buildandpnpm test.Part of the color-kit assessment stack.
🤖 Generated with Claude Code