Skip to content

chore: adopt changesets for versioning and release notes - #219

Merged
pbroom merged 5 commits into
mainfrom
chore/adopt-changesets
Oct 10, 2026
Merged

pbroom merged 5 commits into
mainfrom
chore/adopt-changesets

Conversation

@pbroom

@pbroom pbroom commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner
  • Add @changesets/cli (v3) with changeset and version-packages scripts.
  • Configure changesets so only the published color-kit facade is
    versioned (privatePackages: version/tag false); plain 0.x versions, with
    the next dist-tag still coming from publishConfig.
  • Drop the two stale @color-kit/react changesets: they target a private,
    never-published package and predate the 0.1.0 release prep, so changesets
    would silently skip them.
  • check:preprod now rejects changesets that target non-publishable
    packages or use a major bump while the package is pre-1.0.
  • Add a Version Packages workflow (changesets/action, version PR only, no
    npm publishing or token); publishing stays manual via pnpm publish:next.
  • Document the flow in CONTRIBUTING.md and README, and add a changeset for
    the facade peer/color-input/licensing changes.

Part of a stacked set of PRs (#204 → #221) from the color-kit assessment. Validated per branch with pnpm build and pnpm test; lint, format, typecheck, size, artifact, preprod and agents checks pass at the top of the stack.

🤖 Generated with Claude Code

pbroom commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[High risk] Adopts changesets for versioning and release automation.

The PR should not merge until the changeset guard stops silently accepting releases it failed to validate.

Fix All in CursorFindings

  1. P1 Valid releases go unchecked ▶
  2. P2 Changesets drops Node 20 support ▶
  3. P2 Security Writable workflow uses mutable actions ▶

Summary

The PR adds Changesets-based versioning for the published color-kit facade, an automated version-PR workflow, release guidance, and a preproduction changeset guard.

  • The guard can silently miss valid changeset releases.
  • The new CLI’s Node requirement conflicts with documented Node 20 support, and the write-enabled workflow leaves three action references mutable.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Contributor adds color-kit changeset] --> B[CI: check:preprod]
  B --> C[Merge to main]
  C --> D[Version Packages workflow]
  D --> E[changeset version]
  E --> F[Version PR]
  F --> G[Merge version PR]
  G --> H[Manual publish:next]
Loading

Reviews (1) · Last reviewed commit: "chore: adopt changesets for versioning a..."

Comment thread scripts/check-preproduction.mjs Outdated
Comment thread package.json Outdated
Comment thread .github/workflows/version-packages.yml Outdated

pbroom commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner Author

Merge activity

  • Oct 10, 6:47 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 7:28 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 10, 7:28 PM UTC: @pbroom merged this pull request with Graphite.

@pbroom
pbroom changed the base branch from chore/packaging-and-licensing to graphite-base/219 October 10, 2026 19:25
@pbroom
pbroom changed the base branch from graphite-base/219 to main October 10, 2026 19:26
pbroom and others added 5 commits October 10, 2026 19:27
- Add @changesets/cli (v3) with `changeset` and `version-packages` scripts.
- Configure changesets so only the published `color-kit` facade is
  versioned (privatePackages: version/tag false); plain 0.x versions, with
  the `next` dist-tag still coming from publishConfig.
- Drop the two stale @color-kit/react changesets: they target a private,
  never-published package and predate the 0.1.0 release prep, so changesets
  would silently skip them.
- check:preprod now rejects changesets that target non-publishable
  packages or use a major bump while the package is pre-1.0.
- Add a Version Packages workflow (changesets/action, version PR only, no
  npm publishing or token); publishing stays manual via pnpm publish:next.
- Document the flow in CONTRIBUTING.md and README, and add a changeset for
  the facade peer/color-input/licensing changes.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@changesets/cli 3 requires Node ^22.11, but the workspace supports
Node >=20. 2.31.1 and its dependency tree run on Node 20.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
…arse

Lines with a trailing YAML comment or other syntax were silently skipped,
so a release targeting a private package could pass check:preprod.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
changesets/action v2 (ae32849, v2.1.2) calls validateChangesetsCliVersion
from every mode and throws when the root package declares or resolves
@changesets/cli 2.x ("use Changesets action v1 instead"). We pin the CLI
to ^2.31.1 to keep Node 20 support, so the Version Packages workflow
would fail on main. Pin v1.9.0 (a45c4d5, node24 runtime), which has no
CLI-version gate and runs `changeset version` (or the version script)
for CLI >= 2, and switch to its input names: version, commit, title.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@pbroom
pbroom force-pushed the chore/adopt-changesets branch from 00b0329 to fbf0e6e Compare October 10, 2026 19:27
@pbroom
pbroom merged commit f5be857 into main Oct 10, 2026
6 of 7 checks passed
@pbroom
pbroom deleted the chore/adopt-changesets branch October 10, 2026 19:28

This branch was successfully deployed

1 active deployment
Preview — fbf0e6eb Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant