Repository navigation
refactor(react): reuse core contrast and transfer functions - #217
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Owner
Author
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 6, 2026
|
This was referenced Oct 6, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pbroom
force-pushed
the
refactor/core-explicit-contrast-engine
branch
from
October 8, 2026 02:44
d9f427e to
d127833
Compare
pbroom
force-pushed
the
refactor/react-shared-color-math
branch
from
October 8, 2026 02:44
1ea17cd to
903c45b
Compare
This was referenced Oct 8, 2026
Owner
Author
pbroom
changed the base branch from
refactor/core-explicit-contrast-engine
to
graphite-base/217
October 10, 2026 19:21
- ContrastRegionLayer scores candidate fill paths with core's contrastRatio / contrastAPCA, passing the region's gamut, instead of its own unclamped WCAG copy and gamut-less APCA call, so the score matches the field the contrast region was traced from. - Export linearToSrgbChannel / srgbToLinearChannel from core and use them in ColorPlane's CPU path instead of a local transfer-function copy (GLSL shader sources keep their own implementation). - createWebglState now deletes the shaders, program, and buffer it created when compilation, linking, or uniform lookup fails. Co-Authored-By: Claude Opus 5.5 <[email protected]>
- Contrast fill: a Display P3 WCAG fill agrees with the gamut-aware check, and APCA polarity decides an ambiguous boundary closure. - ColorPlane: link failure and a missing uniform free GL objects and fall back to the cpu renderer. Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
force-pushed
the
refactor/react-shared-color-math
branch
from
October 10, 2026 19:23
903c45b to
d103ab3
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

contrastRatio / contrastAPCA, passing the region's gamut, instead of
its own unclamped WCAG copy and gamut-less APCA call, so the score
matches the field the contrast region was traced from.
them in ColorPlane's CPU path instead of a local transfer-function
copy (GLSL shader sources keep their own implementation).
created when compilation, linking, or uniform lookup fails.
Part of a stacked set of PRs (#204 → #221) from the color-kit assessment. Validated per branch with
pnpm buildandpnpm test; lint, format, typecheck, size, artifact, preprod and agents checks pass at the top of the stack.🤖 Generated with Claude Code