Repository navigation
feat(docs): generated API reference from TypeDoc JSON - #242
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 740163089c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
7401630 to
e987661
Compare
ed25431 to
8ae2a67
Compare
e987661 to
f2e5f6f
Compare
8ae2a67 to
10e0964
Compare
pbroom
left a comment
There was a problem hiding this comment.
Reviewed the full incremental PR and its corrections at f2e5f6f9f6649bfc1826be1d0492cb73f1fde2cc. Index signatures, forwarded-ref Props/signatures and dangling parameter anchors corrected. No remaining actionable findings in the reviewed scope.
Independent correction re-reviews and stack preservation verification passed. At the integrated tip, lint, full build/DTS, 2,208 tests, formatting, strict agent checks and 14 built-site Chrome tests passed. All recorded actionable review threads are addressed. Hosted CI is being verified separately; this review does not authorize merge or release.
10e0964 to
83eb6ab
Compare
f2e5f6f to
1855790
Compare
Replace the TypeDoc HTML output in /reference with a generated reference built into the site: - scripts/api: TypeDoc JSON (.typedoc/api.json) for every entry point in packages/color-kit/package.json#exports, normalized into src/generated/api.json plus per-entry and per-symbol page files typed by src/api/model.ts. One page per declaration in its most specific entry; other entries list it as a re-export. Links resolve at generation time. - /api, /api/:entry (domains, kind glyphs, narrative MDX slot, re-exports) and /api/:entry/:Symbol (declaration, params, returns, throws, build-time highlighted examples, notes MDX slot, see also, also exported from, source link at the commit), all prerendered. - <Signature> implements the S1 contract, with <Params>, <TypeLink> and responsive one-parameter-per-line layout. - ⌘K symbol hits come from the API routes, ranked by name, word and initials. - Drift test: every facade .d.ts export has a page, every exports subpath is documented, every /api link resolves. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1855790 to
c7b93f3
Compare
|
Deployment failed for project color-kit with the following error: Learn More: https://vercel.com/pbrooms-projects?upgradeToPro=build-rate-limit |
## Summary Docs overhaul slice S3: the live plane hero on the home page, plus the example system. **Home page** - Headline: "A queryable OKLCH color engine.", set over a live hue slice of OKLCH (chroma × lightness). - `sense(plane)` answers three queries: - the sRGB region - the Display P3 boundary - the WCAG AA region on white or black, chosen by the theme - Underneath, a 160×160 `toP3Into` loop paints a display-p3 canvas. - The first frame (hue 264) is computed in Node at build time via `?build`. The SVG prerenders and hydrates from the same JSON, and `color-kit/plane` loads lazily after hydration. - Hue is set with a native range input that has `aria-valuetext`, or by dragging horizontally on the plane. Updates are rAF-throttled. - Below the hero: its own source, the install line and three "what you can ask" links. - Follow-up commit: the hero axes get every tick and separate axis titles. **Examples** - `<Example>` renders the live component above its source, which is highlighted at build time. It collapses long sources and isolates failures. - `plugins/eval-example.ts` fills in `// →` results by running each snippet against the color-kit source. This is documented in `src/examples/README.md`. - The graphics demos get `*Example` wrappers. - The old Sandpack plane quick start is now a real example in `src/examples/plane/quick-start.tsx`. **Contract changes** (backwards compatible) - `<Example>`'s `source` also accepts the `?highlighted` module. - New `collapseAfter` prop. - New `?build` imports. - Prerender links route-chunk CSS. - ESLint allows bare expressions in example snippets. Rebased onto #242 with no conflicts. The `eslint.config.js` and styles changes merged cleanly with S2's; the `api.css` import and the example-snippet rule are both kept. ## Verified - On this branch: `pnpm build` and `pnpm test`. - Bundle check passes: the largest chunk is 194.8 kB against a 200 kB limit, and home initial JS is 100.2 kB gzip against a 110 kB limit. - Docs tests pass: 601 tests. - At the stack top (#244): lint, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict all pass. - Browser checks at the stack top: - Dragging the hero hue slider from 264° to 65° recomputes the geometry (about 3.8 ms of queries plus paint). - In light theme the contrast reference flips to white. - At 375 px the hero fits with no horizontal scroll. - No console errors or hydration warnings. Part of the color-kit assessment stack. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Docs overhaul slice S2: a generated API reference built into the site. It replaces the TypeDoc HTML output that used to live in
/reference.apps/docs/scripts/api). It runs TypeDoc JSON for every entry point inpackages/color-kit/package.json#exports.src/generated/api.json, plus page files per entry and per symbol, typed bysrc/api/model.ts. All of these are gitignored and built bypnpm docs:api./api./api/:entry: domains, kind glyphs, a narrative MDX slot and re-exports./api/:entry/:Symbol: declaration, params, returns, throws, build-time highlighted examples, a notes MDX slot, see also, "also exported from" and a source link at the commit.<Signature>implements the S1 contract. It comes with<Params>,<TypeLink>and a responsive layout with one parameter per line..d.tshas a page/apilink resolvesRebased onto #241 with no conflicts. The generated reference reflects the #237–#241 surface; for example,
PlaneWithSensehas no page.Verified
pnpm buildandpnpm test./api/plane/senseand/api/core/Colorrender.Part of the color-kit assessment stack.
🤖 Generated with Claude Code