Repository navigation
fix(core): uncap saturate chroma and resolve planeHue as an OKLCH hue - #238
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
51241a5 to
9966c5f
Compare
4012f07 to
02cd00c
Compare
9966c5f to
5e9fc61
Compare
02cd00c to
3628071
Compare
5e9fc61 to
d8af837
Compare
3628071 to
800d652
Compare
pbroom
left a comment
There was a problem hiding this comment.
Reviewed the full incremental PR and its corrections at d8af837fc1ac1a1cee4d32e4d1551288abbafcd1. Saturate and plane hue reviewed; inherited gradient tests preserved. No remaining actionable findings in the reviewed scope.
Independent correction re-reviews and stack preservation verification passed. At the integrated tip, lint, full build/DTS, 2,208 tests, formatting, strict agent checks and 14 built-site Chrome tests passed. All recorded actionable review threads are addressed. Hosted CI is being verified separately; this review does not authorize merge or release.
d8af837 to
c79d502
Compare
saturate/desaturate clamped chroma to [0, 0.4], so wide-gamut colors above 0.4 lost chroma (saturate lowered it, desaturate(c, 0) changed it). Chroma is now only clamped below at 0, like lighten/darken clamp lightness to its domain; 0.4 stays as the saturate step span. planeHue returned the model's own hue on HSL, HSV and HCT planes, but its callers (gamut boundary, contrast and chroma-band queries and their result hue) expect an OKLCH hue. It now converts the fixed color, and falls back to the model hue's most saturated color when that fixed color is achromatic. Co-Authored-By: Claude Opus 5.5 <[email protected]>
c79d502 to
97850a5
Compare
saturate/desaturate clamped chroma to [0, 0.4], so wide-gamut colors
above 0.4 lost chroma (saturate lowered it, desaturate(c, 0) changed
it). Chroma is now only clamped below at 0, like lighten/darken clamp
lightness to its domain; 0.4 stays as the saturate step span.
planeHue returned the model's own hue on HSL, HSV and HCT planes, but
its callers (gamut boundary, contrast and chroma-band queries and their
result hue) expect an OKLCH hue. It now converts the fixed color, and
falls back to the model hue's most saturated color when that fixed color
is achromatic.
Found while documenting the public API in #235. Each finding was reproduced against the built package before the fix, has a regression test, and its affected JSDoc examples were recomputed. lint, build, test, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict pass.
Part of the color-kit assessment stack.
🤖 Generated with Claude Code