Repository navigation
fix(driver): validate the gamut in getColorAreaFallbackPoint - #230
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 7, 2026
This was referenced Oct 8, 2026
pbroom
changed the base branch from
feat/preserve-hue-on-achromatic-input
to
graphite-base/230
October 8, 2026 15:25
pbroom
force-pushed
the
fix/driver-fallback-gamut-validation
branch
from
October 8, 2026 17:04
d82d0c2 to
2858bfe
Compare
pbroom
changed the base branch from
graphite-base/230
to
feat/preserve-hue-on-achromatic-input
October 8, 2026 17:04
This was referenced Oct 9, 2026
Owner
Author
pbroom
changed the base branch from
feat/preserve-hue-on-achromatic-input
to
graphite-base/230
October 10, 2026 19:48
getColorAreaFallbackPoint silently mapped any unknown gamut, such as the removed 'p3' spelling, to sRGB while every core entry point throws. It now calls core's assertGamutTarget, so the TypeError wording is identical and ends "'p3' is not supported; use 'display-p3'". Validator placement: routing through the core plane fallbackPoint query would change behaviour (it forces a finite hue and returns unclamped plane coordinates, while the driver returns clamped, y-flipped UI coordinates for any axes). The repo has no `./gamut` subpath, and adding one would widen the package export map, tsup entries and facade. assertGamutTarget is therefore exported from the existing `./plane` subpath, which already owns the gamut-taking queries, and not from the root barrel. Co-Authored-By: Claude Opus 5.5 <[email protected]>
assertGamutTarget treats undefined as an omitted optional gamut, so a JavaScript caller that left out query.gamut got an sRGB mapping back with gamut: undefined. The fallback point's gamut is required: throw a TypeError instead, as the @throws note now says. Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
force-pushed
the
fix/driver-fallback-gamut-validation
branch
from
October 10, 2026 19:51
bac18cc to
902b3dd
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getColorAreaFallbackPoint silently mapped any unknown gamut, such as the
removed 'p3' spelling, to sRGB while every core entry point throws. It now
calls core's assertGamutTarget, so the TypeError wording is identical and
ends "'p3' is not supported; use 'display-p3'".
Validator placement: routing through the core plane fallbackPoint query
would change behaviour (it forces a finite hue and returns unclamped plane
coordinates, while the driver returns clamped, y-flipped UI coordinates
for any axes). The repo has no
./gamutsubpath, and adding one wouldwiden the package export map, tsup entries and facade. assertGamutTarget
is therefore exported from the existing
./planesubpath, which alreadyowns the gamut-taking queries, and not from the root barrel.
lint, build, test, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict all pass on this branch.
Part of the color-kit assessment stack (#204 → #232).
🤖 Generated with Claude Code