Repository navigation
fix(react): apply controlled updates against the latest snapshot - #210
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Owner
Author
This was referenced Oct 6, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This was referenced Oct 6, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 8, 2026
This was referenced Oct 8, 2026
Owner
Author
pbroom
changed the base branch from
feat/core-gamut-map-method
to
graphite-base/210
October 10, 2026 19:05
Controlled useColor/useMultiColor read `state` from the render closure, so
two updates in one tick (e.g. setChannel('l') then setChannel('c')) each
started from the same stale value and the second overwrote the first.
- Add an internal `useLatestSnapshot` (color-store.ts): updates write a
pending snapshot keyed to the committed value; reads return it until the
controlled prop (or committed uncontrolled state) changes. Refs are only
touched in event handlers and a layout effect, never during render.
- onChange timing: both hooks now call onChange synchronously inside the
setter, before React re-renders, in controlled and uncontrolled modes,
once per effective update and never for no-ops. Uncontrolled useMultiColor
previously emitted from a post-commit effect; it now computes the event
eagerly from the latest snapshot and still commits via
setInternalModel(prev => ...). Synchronous emission makes it StrictMode-
safe without the post-commit sequence-dedupe queue, which is removed.
- Move single-color transitions into driver reducers (setColorRequested,
setColorChannel, setColorActiveGamut, setColorActiveView) and use them
from useColor; no-op semantics are unchanged.
- removeColor drops its unused `source` param (hard cut-over; removal has
no entry left to carry a source).
- useColor hex/rgb/hsl/hsv/oklch are lazy getters cached per requested
color, so the non-reactive <Color> provider no longer converts every render.
- Docs: document onChange timing and controlled composition.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
setColorRequested and setColorChannel returned the old state when only the requested gamutMapMethod differed, so the override was ignored. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…fects useLatestSnapshot refreshed its committed ref in a layout effect, which runs after descendants' layout effects, so a child calling a setter from useLayoutEffect composed onto the previous controlled state (l=0.2 instead of 0.8). Sync the ref in an insertion effect, which React runs for the whole tree before any layout effect; no ref is touched during render. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…effects useLatestSnapshot refreshed committedRef in an insertion effect but still dropped the pending write in its layout effect, which runs after descendants'. When a controlled parent rejected an update, a child that called a setter from useLayoutEffect on that commit composed onto the rejected write (l=0.9,h=90 instead of l=0.6,h=90), in useColor and useMultiColor. Expire the pending write in the same insertion effect; same-tick composition and reject-then-accept are unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
force-pushed
the
fix/react-controlled-state
branch
from
October 10, 2026 19:07
7e9b72f to
546f702
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controlled useColor/useMultiColor read
statefrom the render closure, sotwo updates in one tick (e.g. setChannel('l') then setChannel('c')) each
started from the same stale value and the second overwrote the first.
useLatestSnapshot(color-store.ts): updates write apending snapshot keyed to the committed value; reads return it until the
controlled prop (or committed uncontrolled state) changes. Refs are only
touched in event handlers and a layout effect, never during render.
setter, before React re-renders, in controlled and uncontrolled modes,
once per effective update and never for no-ops. Uncontrolled useMultiColor
previously emitted from a post-commit effect; it now computes the event
eagerly from the latest snapshot and still commits via
setInternalModel(prev => ...). Synchronous emission makes it StrictMode-
safe without the post-commit sequence-dedupe queue, which is removed.
setColorChannel, setColorActiveGamut, setColorActiveView) and use them
from useColor; no-op semantics are unchanged.
sourceparam (hard cut-over; removal hasno entry left to carry a source).
color, so the non-reactive provider no longer converts every render.
Part of a stacked set of PRs (#204 → #221) from the color-kit assessment. Validated per branch with
pnpm buildandpnpm test; lint, format, typecheck, size, artifact, preprod and agents checks pass at the top of the stack.🤖 Generated with Claude Code