Repository navigation
refactor!: name the Display P3 space 'display-p3' everywhere - #214
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Owner
Author
This was referenced Oct 6, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 6, 2026
|
This was referenced Oct 6, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pbroom
force-pushed
the
refactor/core-display-p3-naming
branch
from
October 8, 2026 02:44
0e758bf to
ebd26cf
Compare
pbroom
force-pushed
the
refactor/driver-drag-controller
branch
from
October 8, 2026 02:44
f92ddf0 to
99c5bbb
Compare
This was referenced Oct 8, 2026
Owner
Author
pbroom
changed the base branch from
refactor/driver-drag-controller
to
graphite-base/214
October 10, 2026 19:15
Use 'display-p3' (matching CSS color(display-p3 ...)) as the only
identifier for gamma-encoded Display P3:
- InterpolationSpace: 'p3' -> 'display-p3' ('linear-p3' unchanged);
unknown spaces now throw a TypeError instead of silently mixing in
linear sRGB.
- PlaneModel: drop 'p3' and the 'display-p3' -> 'p3' alias; resolved
planes keep model 'display-p3'. Unknown models throw a TypeError.
- CssColorFormat: toCss(color, 'p3') -> toCss(color, 'display-p3').
- ArraySpace (packColors/unpackColors): 'p3' -> 'display-p3'.
Update react/driver callers, tests, bench, and docs.
BREAKING CHANGE: 'p3' is no longer accepted as a space, plane model,
CSS format, or array layout; use 'display-p3'.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
force-pushed
the
refactor/core-display-p3-naming
branch
from
October 10, 2026 19:17
ebd26cf to
e145411
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use 'display-p3' (matching CSS color(display-p3 ...)) as the only
identifier for gamma-encoded Display P3:
unknown spaces now throw a TypeError instead of silently mixing in
linear sRGB.
planes keep model 'display-p3'. Unknown models throw a TypeError.
Update react/driver callers, tests, bench, and docs.
BREAKING CHANGE: 'p3' is no longer accepted as a space, plane model,
CSS format, or array layout; use 'display-p3'.
Part of a stacked set of PRs (#204 → #221) from the color-kit assessment. Validated per branch with
pnpm buildandpnpm test; lint, format, typecheck, size, artifact, preprod and agents checks pass at the top of the stack.🤖 Generated with Claude Code