Skip to content

refactor!: name the Display P3 space 'display-p3' everywhere - #214

Merged
pbroom merged 2 commits into
mainfrom
refactor/core-display-p3-naming
Oct 10, 2026
Merged

pbroom merged 2 commits into
mainfrom
refactor/core-display-p3-naming

Conversation

@pbroom

@pbroom pbroom commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Use 'display-p3' (matching CSS color(display-p3 ...)) as the only
identifier for gamma-encoded Display P3:

  • InterpolationSpace: 'p3' -> 'display-p3' ('linear-p3' unchanged);
    unknown spaces now throw a TypeError instead of silently mixing in
    linear sRGB.
  • PlaneModel: drop 'p3' and the 'display-p3' -> 'p3' alias; resolved
    planes keep model 'display-p3'. Unknown models throw a TypeError.
  • CssColorFormat: toCss(color, 'p3') -> toCss(color, 'display-p3').
  • ArraySpace (packColors/unpackColors): 'p3' -> 'display-p3'.

Update react/driver callers, tests, bench, and docs.

BREAKING CHANGE: 'p3' is no longer accepted as a space, plane model,
CSS format, or array layout; use 'display-p3'.

Part of a stacked set of PRs (#204 → #221) from the color-kit assessment. Validated per branch with pnpm build and pnpm test; lint, format, typecheck, size, artifact, preprod and agents checks pass at the top of the stack.

🤖 Generated with Claude Code

pbroom commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Renames a color space identifier throughout the codebase.

The PR should not merge until invalid interpolation spaces are rejected at endpoints as well as interior positions.

Fix All in CursorFindings

  1. P1 Unknown spaces pass at endpoints ▶

Summary

The PR standardizes the gamma-encoded Display P3 identifier as display-p3 across core APIs and their callers.

  • Removes the old p3 API tokens and updates docs, demos, tests, and benchmarks.
  • Adds errors for unknown interpolation spaces and plane models.

Reviews (1) · Last reviewed commit: "refactor!: name the Display P3 space 'di..."

Comment thread packages/core/src/interpolation/index.ts Outdated
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
color-kit Ready Ready Preview Oct 10, 2026 7:18pm UTC

@pbroom
pbroom force-pushed the refactor/core-display-p3-naming branch from 0e758bf to ebd26cf Compare October 8, 2026 02:44
@pbroom
pbroom force-pushed the refactor/driver-drag-controller branch from f92ddf0 to 99c5bbb Compare October 8, 2026 02:44

pbroom commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner Author

Merge activity

  • Oct 10, 6:47 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 7:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 10, 7:18 PM UTC: @pbroom merged this pull request with Graphite.

@pbroom
pbroom changed the base branch from refactor/driver-drag-controller to graphite-base/214 October 10, 2026 19:15
@pbroom
pbroom changed the base branch from graphite-base/214 to main October 10, 2026 19:16
pbroom and others added 2 commits October 10, 2026 19:17
Use 'display-p3' (matching CSS color(display-p3 ...)) as the only
identifier for gamma-encoded Display P3:

- InterpolationSpace: 'p3' -> 'display-p3' ('linear-p3' unchanged);
  unknown spaces now throw a TypeError instead of silently mixing in
  linear sRGB.
- PlaneModel: drop 'p3' and the 'display-p3' -> 'p3' alias; resolved
  planes keep model 'display-p3'. Unknown models throw a TypeError.
- CssColorFormat: toCss(color, 'p3') -> toCss(color, 'display-p3').
- ArraySpace (packColors/unpackColors): 'p3' -> 'display-p3'.

Update react/driver callers, tests, bench, and docs.

BREAKING CHANGE: 'p3' is no longer accepted as a space, plane model,
CSS format, or array layout; use 'display-p3'.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@pbroom
pbroom force-pushed the refactor/core-display-p3-naming branch from ebd26cf to e145411 Compare October 10, 2026 19:17
@pbroom
pbroom merged commit 16ee0d0 into main Oct 10, 2026
7 checks passed
@pbroom
pbroom deleted the refactor/core-display-p3-naming branch October 10, 2026 19:18

This branch was successfully deployed

1 active deployment
Preview — e1454110 Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant