Repository navigation
chore: pin control-kit to a commit with its own pnpm workspace - #234
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 8, 2026
This was referenced Oct 8, 2026
This was referenced Oct 8, 2026
pbroom
force-pushed
the
docs/backlog-contrast-engine-history
branch
from
October 8, 2026 17:04
9e41c06 to
fd82f77
Compare
pbroom
force-pushed
the
chore/bump-control-kit-workspace
branch
from
October 8, 2026 17:04
039ba97 to
15d85d0
Compare
This was referenced Oct 9, 2026
pbroom
force-pushed
the
chore/bump-control-kit-workspace
branch
from
October 10, 2026 02:39
15d85d0 to
920d85b
Compare
pbroom
force-pushed
the
docs/backlog-contrast-engine-history
branch
from
October 10, 2026 02:39
fd82f77 to
5e94eff
Compare
Owner
Author
pbroom
changed the base branch from
docs/backlog-contrast-engine-history
to
graphite-base/234
October 10, 2026 19:56
control-kit is a Git dependency with a `prepare` script, so pnpm prepares it with a nested `pnpm install` in `<storeDir>/v10/tmp/_tmp_*`. The pinned commit had no pnpm-workspace.yaml, so when the store sits inside this repo (as on Vercel) the nested install walked up to color-kit's pnpm-workspace.yaml, installed the whole color-kit workspace, hit control-kit again, and recursed without end (73 levels in 4 minutes locally; Vercel installs hung for 24+ minutes). Pin e5aebdf, which is the previously pinned b9cd2cb plus a root pnpm-workspace.yaml (`onlyBuiltDependencies: [esbuild]`). The nested install now stops at control-kit's own root; no other control-kit code changes. The same fix for control-kit main is pbroom/control-kit#98. Moving to that line means adopting control-kit's @pbroom/control-kit rename and newer peers, which is left for a separate change. Co-Authored-By: Claude Opus 5.5 <[email protected]>
pbroom
force-pushed
the
chore/bump-control-kit-workspace
branch
from
October 10, 2026 19:58
920d85b to
b55dac7
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
control-kit is a Git dependency with a
preparescript, so pnpm prepares itwith a nested
pnpm installin<storeDir>/v10/tmp/_tmp_*. The pinnedcommit had no pnpm-workspace.yaml, so when the store sits inside this repo
(as on Vercel) the nested install walked up to color-kit's
pnpm-workspace.yaml, installed the whole color-kit workspace, hit
control-kit again, and recursed without end (73 levels in 4 minutes
locally; Vercel installs hung for 24+ minutes).
Pin e5aebdf, which is the previously pinned b9cd2cb plus a root
pnpm-workspace.yaml (
onlyBuiltDependencies: [esbuild]). The nestedinstall now stops at control-kit's own root; no other control-kit code
changes. The same fix for control-kit main is
pbroom/control-kit#98. Moving to that line means
adopting control-kit's @pbroom/control-kit rename and newer peers, which
is left for a separate change.
Verification
A fresh
pnpm install --frozen-lockfilewith the pnpm store inside the repo, which used to recurse 73+ levels, now finishes in 11 s. It runs one control-kit prepare: 211 packages, then the workspace installs once.buildandtestpass there. lint, build, test, format:check, typecheck, size, check:artifacts, check:preprod and agents:check:strict all pass.Pins
e5aebdf, which is the old pinb9cd2cbplus only control-kit's newpnpm-workspace.yaml, on the control-kit branchfix/own-pnpm-workspace-b9cd2cb. The same fix for control-kitmainis in pbroom/control-kit#98. Moving to control-kitmainlater also means adopting its rename to@pbroom/control-kitand its new peer ranges, which is a separate upgrade.Once this lands, #233's
--store-dir=/tmp/pnpm-storeworkaround is no longer required but stays harmless.Part of the color-kit assessment stack (#204 → #234).
🤖 Generated with Claude Code