Repository navigation
Conversation
Byte length cannot recover an element count when elements are zero-sized. Keep the count in slice decoding, and retain each child's metadata when composing indexed decoders into a sequence. Prove initialization, realizability for admitted values, and completeness through physical and mathematical decoding. Check empty uninhabited slices, distinct zero-byte counts, rejected metadata, and nested indexed sequences. These are pure representation laws; they do not supply a Rust layout or pointer-access premise. gherrit-pr-id: Grpvcydhrmu5xhlrgdma3sjuwlvxdozc6 Agent-authored-by: AI agent acting on joshlf's behalf
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request extends the Lean formalization of Rust storage decoders by introducing the sequence decoder, which composes repeated uses of a storage decoder, and proving its properties regarding initialization, realizability, and completeness. It also adds several theorems for sliceDecoder and arrayDecoder, alongside comprehensive test cases in ReferentTests.lean and RustStorageTests.lean covering edge cases such as zero-byte widths and empty types. There are no review comments, and we have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gsul3w4vydc4wowguwwscielqttbpeytg #3892 +/- ##
==================================================================
Coverage 48.67% 48.67%
==================================================================
Files 35 35
Lines 4754 4754
==================================================================
Hits 2314 2314
Misses 2440 2440 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Byte length cannot recover an element count when elements are zero-sized.
Keep the count in slice decoding, and retain each child's metadata when
composing indexed decoders into a sequence.
Prove initialization, realizability for admitted values, and completeness
through physical and mathematical decoding. Check empty uninhabited
slices, distinct zero-byte counts, rejected metadata, and nested indexed
sequences. These are pure representation laws; they do not supply a Rust
layout or pointer-access premise.
Authored by an AI agent acting on joshlf's behalf.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Grpvcydhrmu5xhlrgdma3sjuwlvxdozc6 && git checkout -b pr-Grpvcydhrmu5xhlrgdma3sjuwlvxdozc6 FETCH_HEADCheckout
git fetch origin refs/heads/Grpvcydhrmu5xhlrgdma3sjuwlvxdozc6 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Grpvcydhrmu5xhlrgdma3sjuwlvxdozc6 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.