Skip to content

Move cast_from into layout/cast_from.rs - #3824

Open
joshlf wants to merge 1 commit into
Ggis7hb6l6jmnmnk4fjfb3w2lulssgynzfrom
Glzjt2cwoexxyhj2f2lgnba524ajc2cqp
Open

joshlf wants to merge 1 commit into
Ggis7hb6l6jmnmnk4fjfb3w2lulssgynzfrom
Glzjt2cwoexxyhj2f2lgnba524ajc2cqp

Conversation

@joshlf

@joshlf joshlf commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Give the pointer-cast implementation its own source file so subsequent
changes to cast planning can be reviewed separately from the layout code.
Move the inline module unchanged to layout/cast_from.rs, use layout/mod.rs
as the module root, and update the unsafe-code source catalog.

Authored by an AI agent acting on joshlf's behalf.


Latest Update: v31 — Compare vs v30

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v31 v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Glzjt2cwoexxyhj2f2lgnba524ajc2cqp && git checkout -b pr-Glzjt2cwoexxyhj2f2lgnba524ajc2cqp FETCH_HEAD

Checkout

git fetch origin refs/heads/Glzjt2cwoexxyhj2f2lgnba524ajc2cqp && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Glzjt2cwoexxyhj2f2lgnba524ajc2cqp && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Glzjt2cwoexxyhj2f2lgnba524ajc2cqp

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:21:46.915447Z 79158f4 PR opened
🔒 Security Review ✅ Completed 2026-10-08T10:24:12.044364Z 79158f4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This was referenced Oct 8, 2026
@joshlf
joshlf force-pushed the Ggis7hb6l6jmnmnk4fjfb3w2lulssgynz branch from 92642e1 to ec12c2b Compare October 9, 2026 00:08
@joshlf
joshlf force-pushed the Glzjt2cwoexxyhj2f2lgnba524ajc2cqp branch from 79158f4 to 9916d7c Compare October 9, 2026 00:08
@codecov-commenter

codecov-commenter commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (Ggis7hb6l6jmnmnk4fjfb3w2lulssgynz@2d86981). Learn more about missing BASE report.

Files with missing lines Patch % Lines
zerocopy/src/layout/cast_from.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##             Ggis7hb6l6jmnmnk4fjfb3w2lulssgynz    #3824   +/-   ##
====================================================================
  Coverage                                     ?   92.92%           
====================================================================
  Files                                        ?       17           
  Lines                                        ?     2459           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?     2285           
  Misses                                       ?      174           
  Partials                                     ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf
joshlf force-pushed the Ggis7hb6l6jmnmnk4fjfb3w2lulssgynz branch from 3960bad to 3a699df Compare October 14, 2026 18:32
@joshlf
joshlf force-pushed the Glzjt2cwoexxyhj2f2lgnba524ajc2cqp branch from e81df37 to 133c19e Compare October 14, 2026 18:32
@joshlf
joshlf force-pushed the Ggis7hb6l6jmnmnk4fjfb3w2lulssgynz branch from 3a699df to 3ad300b Compare October 14, 2026 21:43
@joshlf
joshlf force-pushed the Glzjt2cwoexxyhj2f2lgnba524ajc2cqp branch from 133c19e to 0fd7b2e Compare October 14, 2026 21:43
@joshlf
joshlf force-pushed the Glzjt2cwoexxyhj2f2lgnba524ajc2cqp branch from 0fd7b2e to d66a3dc Compare October 15, 2026 00:40
Give the pointer-cast implementation its own source file so subsequent
changes to cast planning can be reviewed separately from the layout code.
Move the inline module unchanged to layout/cast_from.rs, use layout/mod.rs
as the module root, and update the unsafe-code source catalog.

gherrit-pr-id: Glzjt2cwoexxyhj2f2lgnba524ajc2cqp
Agent-authored-by: AI agent acting on joshlf's behalf

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants