Skip to content

Prove the numerical bounds used by split operations - #3840

Open
joshlf wants to merge 1 commit into
Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7from
Gytt7syk4w4f52xlmszabgwlaiofsu7p6
Open

joshlf wants to merge 1 commit into
Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7from
Gytt7syk4w4f52xlmszabgwlaiofsu7p6

Conversation

@joshlf

@joshlf joshlf commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Factor the split-length calculation and zero-padding decision into proved
helpers used by the production pointer paths. A Rust assertion harness
compares complete sizes with the independent reference and checks physical
tail containment.

Prove counts, bounds and disjoint numerical intervals, including empty and
zero-sized tails, under the visible witness and containment guards.
Pointer validity, provenance and access permissions remain separate Rust
obligations. Refresh UI diagnostics for the shifted source lines.

Authored by an AI agent acting on joshlf's behalf.


Latest Update: v31 — Compare vs v30

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v31 v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6 && git checkout -b pr-Gytt7syk4w4f52xlmszabgwlaiofsu7p6 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:24:43.065371Z 11914d0 PR opened
🔒 Security Review ✅ Completed 2026-10-08T10:25:11.764579Z 11914d0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This was referenced Oct 8, 2026
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from 11914d0 to 8b0dc59 Compare October 9, 2026 00:08
@codecov-commenter

codecov-commenter commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.42857% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.16%. Comparing base (28d6c6b) to head (e1054a3).

Files with missing lines Patch % Lines
zerocopy/src/split_at.rs 11.29% 55 Missing ⚠️
zerocopy/src/layout/tail_transform_checks.rs 0.00% 5 Missing ⚠️
zerocopy/src/layout/tail_checks.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7    #3840      +/-   ##
=====================================================================
- Coverage                              53.83%   53.16%   -0.67%     
=====================================================================
  Files                                     30       30              
  Lines                                   4267     4332      +65     
=====================================================================
+ Hits                                    2297     2303       +6     
- Misses                                  1970     2029      +59     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf
joshlf force-pushed the Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7 branch from 4e8a022 to 79ea0f5 Compare October 9, 2026 02:21
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from e1054a3 to f6aef3c Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7 branch from 28d6c6b to f5c26ca Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7 branch from f5c26ca to 2b395ee Compare October 15, 2026 01:19
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch 2 times, most recently from 5f309da to e7c908c Compare October 15, 2026 04:53
@joshlf
joshlf force-pushed the Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7 branch from 2b395ee to 60fa265 Compare October 15, 2026 04:53
@joshlf
joshlf force-pushed the Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7 branch from 60fa265 to 98d67b0 Compare October 15, 2026 14:22
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from e7c908c to 8129e89 Compare October 15, 2026 14:22
Factor the split-length calculation and zero-padding decision into proved
helpers used by the production pointer paths. A Rust assertion harness
compares complete sizes with the independent reference and checks physical
tail containment.

Prove counts, bounds and disjoint numerical intervals, including empty and
zero-sized tails, under the visible witness and containment guards.
Pointer validity, provenance and access permissions remain separate Rust
obligations. Refresh UI diagnostics for the shifted source lines.

gherrit-pr-id: Gytt7syk4w4f52xlmszabgwlaiofsu7p6
Agent-authored-by: AI agent acting on joshlf's behalf

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants