Skip to content

Retain every type argument in native trait laws - #3888

Open
joshlf wants to merge 1 commit into
Gkc7ajwbs2rni7qu5gz3sdcm7457o6iuffrom
Gh45pumwesnecey6ydwcy7kg5ucsvnr34
Open

joshlf wants to merge 1 commit into
Gkc7ajwbs2rni7qu5gz3sdcm7457o6iuffrom
Gh45pumwesnecey6ydwcy7kg5ucsvnr34

Conversation

@joshlf

@joshlf joshlf commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Allow inline invariants on type-parameterized traits and type-only bounds,
including conditional impls whose bound subject is a nominal wrapper.
Source parsing records supported syntax and bound arity; compiler-resolved
applications remain authoritative for every ordered argument.

Compare original and final applications, generic bounds, and implied
parent bounds. Reject unsupported argument kinds, changed arity, and
associated-type constraints before assembling a law. Keep the existing
native dictionary and proof-input audits. Add parser and binding regression
tests for reordered, repeated, missing, and unsupported arguments.

Authored by an AI agent acting on joshlf's behalf.


Latest Update: v4 — Compare vs v3

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v3 v2 v1 Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gh45pumwesnecey6ydwcy7kg5ucsvnr34 && git checkout -b pr-Gh45pumwesnecey6ydwcy7kg5ucsvnr34 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gh45pumwesnecey6ydwcy7kg5ucsvnr34 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gh45pumwesnecey6ydwcy7kg5ucsvnr34 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gh45pumwesnecey6ydwcy7kg5ucsvnr34

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T19:05:50.156768Z 79bdfd5 PR opened
🔒 Security Review ✅ Completed 2026-10-15T19:09:45.943938Z 79bdfd5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This was referenced Oct 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for parameterized traits and trait bounds to the Aeneas verification tool. The Rust inline parser has been updated to parse and record type argument counts for generic traits, while the Python verification scripts have been enhanced to validate these parameterized bounds, ensuring type argument identities and arities are preserved. Comprehensive unit tests have been added to both the Rust and Python test suites. As there are no review comments, I have no feedback to provide.

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.89%. Comparing base (04257d4) to head (cd7ad5b).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           Gkc7ajwbs2rni7qu5gz3sdcm7457o6iuf    #3888   +/-   ##
==================================================================
  Coverage                              48.89%   48.89%           
==================================================================
  Files                                     34       34           
  Lines                                   4733     4733           
==================================================================
  Hits                                    2314     2314           
  Misses                                  2419     2419           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf
joshlf force-pushed the Gh45pumwesnecey6ydwcy7kg5ucsvnr34 branch from 79bdfd5 to c3bc1c1 Compare October 15, 2026 19:25
@joshlf
joshlf force-pushed the Gkc7ajwbs2rni7qu5gz3sdcm7457o6iuf branch from f6bb2df to 04e750c Compare October 15, 2026 19:25
Allow inline invariants on type-parameterized traits and type-only bounds,
including conditional impls whose bound subject is a nominal wrapper.
Source parsing records supported syntax and bound arity; compiler-resolved
applications remain authoritative for every ordered argument.

Compare original and final applications, generic bounds, and implied
parent bounds. Reject unsupported argument kinds, changed arity, and
associated-type constraints before assembling a law. Keep the existing
native dictionary and proof-input audits. Add parser and binding regression
tests for reordered, repeated, missing, and unsupported arguments.

gherrit-pr-id: Gh45pumwesnecey6ydwcy7kg5ucsvnr34
Agent-authored-by: AI agent acting on joshlf's behalf

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants