Skip to content

Prove DstLayout padding and field extension - #3838

Open
joshlf wants to merge 1 commit into
Gasqy37pxeoegrksputrmrts2btqezgvhfrom
Ggsdoapsrkoab2sezv6aidvmzy46fo7pu
Open

joshlf wants to merge 1 commit into
Gasqy37pxeoegrksputrmrts2btqezgvhfrom
Ggsdoapsrkoab2sezv6aidvmzy46fo7pu

Conversation

@joshlf

@joshlf joshlf commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Relate the production pad_to_align and extend methods to mathematical
layout operations. Packing limits placement alignment while retaining the
field's complete size, including its internal padding.

Use mathematical clauses for the operation specs and prove that they
retain the independent guarantees about alignment, normalized payload,
physical fields and padding flags. Keep representation and fit conditions
explicit.

Add total Rust harnesses comparing every stored field and both padding
branches with independent remainder-based checked arithmetic. The resulting
proofs establish the conditional layout behavior without requiring review
of intermediate Lean proof steps.

Authored by an AI agent acting on joshlf's behalf.


Latest Update: v31 — Compare vs v30

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v31 v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu && git checkout -b pr-Ggsdoapsrkoab2sezv6aidvmzy46fo7pu FETCH_HEAD

Checkout

git fetch origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Ggsdoapsrkoab2sezv6aidvmzy46fo7pu

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:26:02.002770Z 3401b31 PR opened
🔒 Security Review ✅ Completed 2026-10-08T10:26:01.950965Z 3401b31 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This was referenced Oct 8, 2026
@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 119 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (Gasqy37pxeoegrksputrmrts2btqezgvh@87ccd8e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
zerocopy/src/layout/composition_checks.rs 0.00% 119 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##             Gasqy37pxeoegrksputrmrts2btqezgvh    #3838   +/-   ##
====================================================================
  Coverage                                     ?   54.90%           
====================================================================
  Files                                        ?       30           
  Lines                                        ?     4189           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?     2300           
  Misses                                       ?     1889           
  Partials                                     ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf
joshlf force-pushed the Gasqy37pxeoegrksputrmrts2btqezgvh branch from 7429c2f to beb98f1 Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Ggsdoapsrkoab2sezv6aidvmzy46fo7pu branch from 336c96f to aa3e5c0 Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Ggsdoapsrkoab2sezv6aidvmzy46fo7pu branch from aa3e5c0 to ca4b692 Compare October 15, 2026 01:19
@joshlf
joshlf force-pushed the Gasqy37pxeoegrksputrmrts2btqezgvh branch from beb98f1 to 9eaae3f Compare October 15, 2026 01:19
@joshlf
joshlf force-pushed the Ggsdoapsrkoab2sezv6aidvmzy46fo7pu branch from ca4b692 to 3f45436 Compare October 15, 2026 04:53
@joshlf
joshlf force-pushed the Gasqy37pxeoegrksputrmrts2btqezgvh branch from 9eaae3f to 1c8186b Compare October 15, 2026 04:53
@joshlf
joshlf force-pushed the Gasqy37pxeoegrksputrmrts2btqezgvh branch from 1c8186b to 87ccd8e Compare October 15, 2026 14:22
@joshlf
joshlf force-pushed the Ggsdoapsrkoab2sezv6aidvmzy46fo7pu branch from 3f45436 to 1f7adba Compare October 15, 2026 14:22
Relate the production pad_to_align and extend methods to mathematical
layout operations. Packing limits placement alignment while retaining the
field's complete size, including its internal padding.

Use mathematical clauses for the operation specs and prove that they
retain the independent guarantees about alignment, normalized payload,
physical fields and padding flags. Keep representation and fit conditions
explicit.

Add total Rust harnesses comparing every stored field and both padding
branches with independent remainder-based checked arithmetic. The resulting
proofs establish the conditional layout behavior without requiring review
of intermediate Lean proof steps.

gherrit-pr-id: Ggsdoapsrkoab2sezv6aidvmzy46fo7pu
Agent-authored-by: AI agent acting on joshlf's behalf

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants