Skip to content

Prove record construction against independent Rust references - #3846

Open
joshlf wants to merge 1 commit into
Ghrpggbfqci57rogpnzh6zckn5odscj6ufrom
Grnfmfcmtj2bil5vndowx5pfy4gvaytae
Open

joshlf wants to merge 1 commit into
Ghrpggbfqci57rogpnzh6zckn5odscj6ufrom
Grnfmfcmtj2bil5vndowx5pfy4gvaytae

Conversation

@joshlf

@joshlf joshlf commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Complete the connection from production record construction to recursive
field-placement semantics. Prove the constructor loop on its independent
prefix domain, including the final padding step, and retain concrete
witnesses that demonstrate the domain admits ordinary and nested packed
records.

Add total Rust assertion harnesses comparing arbitrary field-list
construction with independent checked extension and padding, and nested
DST sizing with the recursive Rust reference. Compare every stored field
and complete optional size, including overflow and zero-sized tails. The
guards expose descriptor, alignment and representability restrictions.

Keep the compiler-layout premise and regression tests as the Rust boundary.
Successful mathematical decoding alone does not certify an arbitrary
representation as a realizable Rust layout.

Closes #3617

Authored by an AI agent acting on joshlf's behalf.


Latest Update: v31 — Compare vs v30

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v31 v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v30 v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Grnfmfcmtj2bil5vndowx5pfy4gvaytae && git checkout -b pr-Grnfmfcmtj2bil5vndowx5pfy4gvaytae FETCH_HEAD

Checkout

git fetch origin refs/heads/Grnfmfcmtj2bil5vndowx5pfy4gvaytae && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Grnfmfcmtj2bil5vndowx5pfy4gvaytae && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Grnfmfcmtj2bil5vndowx5pfy4gvaytae

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:26:00.937452Z 12b0766 PR opened
🔒 Security Review ✅ Completed 2026-10-08T10:26:37.979843Z 12b0766 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.95%. Comparing base (30a082d) to head (3989a23).

Files with missing lines Patch % Lines
zerocopy/src/layout/nested_reference.rs 0.00% 67 Missing ⚠️
zerocopy/src/layout/composition_checks.rs 0.00% 43 Missing ⚠️
zerocopy/src/layout/mod.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           Ghrpggbfqci57rogpnzh6zckn5odscj6u    #3846      +/-   ##
=====================================================================
- Coverage                              50.03%   48.95%   -1.09%     
=====================================================================
  Files                                     32       32              
  Lines                                   4609     4719     +110     
=====================================================================
+ Hits                                    2306     2310       +4     
- Misses                                  2303     2409     +106     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf
joshlf force-pushed the Grnfmfcmtj2bil5vndowx5pfy4gvaytae branch from 12b0766 to a7f4190 Compare October 8, 2026 12:14
@joshlf
joshlf force-pushed the Ghrpggbfqci57rogpnzh6zckn5odscj6u branch from 27bc9ef to 4c7bdd5 Compare October 8, 2026 12:14
@joshlf
joshlf force-pushed the Grnfmfcmtj2bil5vndowx5pfy4gvaytae branch from a7f4190 to cbc6ad5 Compare October 9, 2026 00:08
@joshlf
joshlf force-pushed the Ghrpggbfqci57rogpnzh6zckn5odscj6u branch from 4c7bdd5 to 984c90f Compare October 9, 2026 00:08
@joshlf
joshlf force-pushed the Ghrpggbfqci57rogpnzh6zckn5odscj6u branch from eaba271 to f8bf4c3 Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Grnfmfcmtj2bil5vndowx5pfy4gvaytae branch from c9d40e4 to 60a6744 Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Ghrpggbfqci57rogpnzh6zckn5odscj6u branch from f8bf4c3 to ec9d086 Compare October 15, 2026 01:19
@joshlf
joshlf force-pushed the Grnfmfcmtj2bil5vndowx5pfy4gvaytae branch from 60a6744 to 32488cc Compare October 15, 2026 01:19
@joshlf
joshlf force-pushed the Ghrpggbfqci57rogpnzh6zckn5odscj6u branch from ec9d086 to 56a37de Compare October 15, 2026 04:53
@joshlf
joshlf force-pushed the Grnfmfcmtj2bil5vndowx5pfy4gvaytae branch from 32488cc to 202ee10 Compare October 15, 2026 04:53
@joshlf
joshlf force-pushed the Ghrpggbfqci57rogpnzh6zckn5odscj6u branch from 56a37de to 888176b Compare October 15, 2026 14:22
@joshlf
joshlf force-pushed the Grnfmfcmtj2bil5vndowx5pfy4gvaytae branch from 202ee10 to 5ba2b43 Compare October 15, 2026 14:22
Complete the connection from production record construction to recursive
field-placement semantics. Prove the constructor loop on its independent
prefix domain, including the final padding step, and retain concrete
witnesses that demonstrate the domain admits ordinary and nested packed
records.

Add total Rust assertion harnesses comparing arbitrary field-list
construction with independent checked extension and padding, and nested
DST sizing with the recursive Rust reference. Compare every stored field
and complete optional size, including overflow and zero-sized tails. The
guards expose descriptor, alignment and representability restrictions.

Keep the compiler-layout premise and regression tests as the Rust boundary.
Successful mathematical decoding alone does not certify an arbitrary
representation as a realizable Rust layout.

Closes #3617

gherrit-pr-id: Grnfmfcmtj2bil5vndowx5pfy4gvaytae
Agent-authored-by: AI agent acting on joshlf's behalf

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants