Skip to content

Verify the byte writers used by IntoBytes - #3851

Open
joshlf wants to merge 1 commit into
Gxtqzofwtbtv4xz242wckf27ztdvftiflfrom
Gkipiolhcatlfs5igrsox32w4yivfp7k3
Open

joshlf wants to merge 1 commit into
Gxtqzofwtbtv4xz242wckf27ztdvftiflfrom
Gkipiolhcatlfs5igrsox32w4yivfp7k3

Conversation

@joshlf

@joshlf joshlf commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

The public IntoBytes write methods previously kept their length selection
inside pointer-bearing code. Route exact, prefix and suffix writes through
extracted byte helpers so Lean checks the production decisions and complete
destination updates.

Prove acceptance, unchanged rejection and preservation of untouched regions.
Compose the public big-endian word constructor and byte accessor with the
prefix writer. Keep the typed-to-byte conversion and valid-reference
conditions as explicit Rust premises.

Add a self-contained offset-copy boundary with a source-bound, guarded
interpretation and negative controls. This avoids the pinned backend's
unsupported suffix reconstruction, which would otherwise lose the
destination prefix. Regression tests exercise the public write methods.

Authored by an AI agent acting on joshlf's behalf.


Latest Update: v25 — Compare vs v24

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gkipiolhcatlfs5igrsox32w4yivfp7k3 && git checkout -b pr-Gkipiolhcatlfs5igrsox32w4yivfp7k3 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gkipiolhcatlfs5igrsox32w4yivfp7k3 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gkipiolhcatlfs5igrsox32w4yivfp7k3 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gkipiolhcatlfs5igrsox32w4yivfp7k3

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T02:24:54.655814Z c2aa05d PR opened
🔒 Security Review ✅ Completed 2026-10-09T02:25:14.540012Z c2aa05d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joshlf
joshlf force-pushed the Gkipiolhcatlfs5igrsox32w4yivfp7k3 branch from c2aa05d to 94a3ef6 Compare October 10, 2026 00:00
@joshlf
joshlf force-pushed the Gkipiolhcatlfs5igrsox32w4yivfp7k3 branch from 807b862 to 689bdfd Compare October 14, 2026 21:43
@joshlf
joshlf force-pushed the Gkipiolhcatlfs5igrsox32w4yivfp7k3 branch from 689bdfd to da6b47d Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Gmunmfwlfxo5nsdg4ic6omp6if4lggr4 branch from 0c3770a to 2594344 Compare October 15, 2026 01:19
@joshlf
joshlf force-pushed the Gkipiolhcatlfs5igrsox32w4yivfp7k3 branch 2 times, most recently from 12e57ce to 97d6f8f Compare October 15, 2026 04:53
@joshlf
joshlf changed the base branch from Gmunmfwlfxo5nsdg4ic6omp6if4lggr4 to Gxtqzofwtbtv4xz242wckf27ztdvftifl October 15, 2026 04:53
@joshlf
joshlf force-pushed the Gxtqzofwtbtv4xz242wckf27ztdvftifl branch from f214615 to 3674685 Compare October 15, 2026 14:22
@joshlf
joshlf force-pushed the Gkipiolhcatlfs5igrsox32w4yivfp7k3 branch from 97d6f8f to 46cc1cd Compare October 15, 2026 14:22
The public IntoBytes write methods previously kept their length selection
inside pointer-bearing code. Route exact, prefix and suffix writes through
extracted byte helpers so Lean checks the production decisions and complete
destination updates.

Prove acceptance, unchanged rejection and preservation of untouched regions.
Compose the public big-endian word constructor and byte accessor with the
prefix writer. Keep the typed-to-byte conversion and valid-reference
conditions as explicit Rust premises.

Add a self-contained offset-copy boundary with a source-bound, guarded
interpretation and negative controls. This avoids the pinned backend's
unsupported suffix reconstruction, which would otherwise lose the
destination prefix. Regression tests exercise the public write methods.

gherrit-pr-id: Gkipiolhcatlfs5igrsox32w4yivfp7k3
Agent-authored-by: AI agent acting on joshlf's behalf

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants