Skip to content

refactor(ui): update dialog and welcome tour on QueryaButton - #1420

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1338-updater-onboarding-querya-button
Oct 11, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1338-updater-onboarding-querya-button

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Part of #1338 / #1331 (closes neither)

First feature-directory pass of the button migration, using QueryaButton (#1408, in dev).

What

18 shadcn button calls move to QueryaButton, mapped by the table in docs/ui-kit.md:

Was Now
PrimaryButton QueryaButton.primary
OutlineButton QueryaButton.secondary (ghost when it is Cancel / Close)
GhostButton QueryaButton.ghost
DestructiveButton QueryaButton.destructive
  • lib/features/updater/update_dialog.dart (12): all footers at lg.
  • lib/features/onboarding/welcome_tour_dialog.dart (6): footer and slide actions at lg; the compact Home link (ButtonDensity.compact) is sm; leading: Icon(...) is icon:.
  • Keys, labels and callbacks are unchanged; no test looks for a shadcn button type in these two features.

Visible differences (intended, from the standard)

  • Cancel in the unsaved-restart dialog loses its outline (ghost).
  • Icon sizes follow the control size instead of the hand-set 16 / 18.

Method

The mechanical part was done with a small codemod that only rewrites calls whose arguments it fully understands (key, onPressed, child: Text(...), leading: Icon(...), density, size) and reports the rest; both files converted with nothing skipped, and the diff was read by hand.

Not in this PR

The recovery app (querya_startup_recovery_app.dart) runs outside a QueryaThemeScope and waits for the tolerant QueryaButton of #1418; the toolbars (QueryaActionButton, QueryaActionMenu) are #1337.

Not run locally; CI is the check.

18 shadcn button calls (PrimaryButton / OutlineButton / GhostButton /
DestructiveButton) become QueryaButton variants at lg (sm for the compact
Home link); Cancel and Close are ghost per the standard. Keys, labels and
callbacks are unchanged. Part of #1338.
@github-actions github-actions Bot added enhancement New feature or request frontend Theme parser epic label: frontend ui User interface components and widgets ux User experience, keyboard shortcuts and interactions P2 Medium priority / Parity & Refactoring labels Oct 11, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 6b7c754 into dev Oct 11, 2026
13 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1338-updater-onboarding-querya-button branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring ui User interface components and widgets ux User experience, keyboard shortcuts and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant