Repository navigation
refactor(ui): the last shadcn buttons in lib on QueryaButton - #1427
Merged
Merged
Conversation
47 files: the remaining dialogs (connections, ERD, extensions, help, safe mode, Mongo, destructive / DML preview), the NoSQL and SQL overview views, the Redis editors, results tab, tab bar, SDUI form builder, unsaved-work guard and the tree load error. Dialog footers are lg, views md; Cancel / Close are ghost. IconButton.ghost (password eye, restart / open / save, close, copy / open in history) is QueryaButton.icon with a tooltip. No shadcn button call remains in lib. Part of #1337 and #1338.
github-actions
Bot
added
enhancement
3 tasks
ZhuchkaTriplesix
deleted the
issue/1338-remaining-dialogs-querya-button
branch
October 11, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1337 / #1338 / #1331. After this, no shadcn button call (
PrimaryButton,OutlineButton,GhostButton,SecondaryButton,DestructiveButton,IconButton.ghost) is left inlib/.What
50 files, the tail of the migration (#1420-#1425):
lg, Cancel / Close ghost): new connection / URL / folder, driver manager, ERD group / note / view name, extension manager / sideload / connection picker / unsandboxed consent, about, safe-mode unlock, Mongo add document / database, destructive query and DML preview, preferences.md): Mongo, MySQL, PostgreSQL, SQLite and Redis overview, stats, routine, sequence and workspace-home screens, the Redis value editors, extension stats and workspace home, results tab, SQL tab bar, tree load error, SDUI form builder, unsaved-work guard.IconButton.ghost(password / passphrase eye, driver restart / open / save in the extension toolbar, close in the cell inspector, copy / open-in-tab in the history) isQueryaButton.iconwith a tooltip; the restart button usesloading.ssl_certificate_fields: the browse icon is aQueryaButton.icon(Browse…).Method
The codemod converted 46 of 47 files with nothing skipped; the eight
IconButton.ghostand the last icon button were written by hand. A grep for shadcn button calls inlib/is empty, and no test looks for a shadcn button type any more (checkedwidgetWithText,byType,widget<...>,shadcn.).Visible differences (intended)
Cancel / Close lose their outline; icon-only buttons gain tooltips; the extension toolbar icons are no longer accent-tinted; icon sizes follow the control size.
Not in this PR
The guard tests (#1339) and the row / theme-switch tests (#1340), the gallery (#1336), and the non-button shadcn symbols (#1365).
Not run locally; CI is the check.