Skip to content

refactor(ui): tables, extensions and settings sections on QueryaButton - #1423

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1337-tables-extensions-settings-querya-button
Oct 11, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1337-tables-extensions-settings-querya-button

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Part of #1337 / #1331 (closes neither). Continues #1420, #1421, #1422.

What

Shadcn button calls become QueryaButton in 14 files:

  • Table toolbars: PostgreSQL, MySQL, SQLite and the generic table view, the staging toolbar and table_view_staging.
  • The cell popover inspector of the grid.
  • Extensions: table toolbar, table view, extension card and the driver recovery banner.
  • The workspace empty hero and the preference sections (appearance, about, extensions).

Toolbars and panels are md; dense rows (ButtonSize.small, ButtonDensity.compact) are sm.

Beyond the mechanical replacement

  • Loading: Save / Save Changes (staging toolbar), Save to DB (inspector) and Restart Driver (two places) use the button's loading instead of a spinner leading plus label switch.
  • Icon-only: the compact Revert All is a QueryaButton.icon with a tooltip.
  • Preference sections: OutlineButton(child: Row(Icon, SizedBox, Text)) becomes a labelled secondary button with an icon (10 buttons); the codemod learned this shape in this pass.

Tests

sql_workspace_readonly_save_test found Save Changes as PrimaryButton and read its onPressed; it now looks for QueryaButton (same onPressed, same enabled / disabled expectations).

Still shadcn

QueryaActionButton / QueryaActionMenu and the toolbars built on them (Execute (F5) finders in generic_sql_workspace_shortcuts_test, sql_workspace_execute_dirty_guard_test, extension_sql_workspace_test) are next: they need the action button itself swapped.

Not run locally; CI is the check.

…ryaButton

Table toolbars (PostgreSQL, MySQL, SQLite, generic), staging toolbar, cell
popover inspector, extension toolbar / card / recovery banner, the workspace
empty hero and the appearance / about / extensions preference sections move to
QueryaButton at md (sm for dense rows). Loading spinners become the button's
loading state, the compact undo is a QueryaButton.icon, and the readonly-save
test looks for QueryaButton. Part of #1337.
@github-actions github-actions Bot added enhancement New feature or request frontend Theme parser epic label: frontend ui User interface components and widgets ux User experience, keyboard shortcuts and interactions P2 Medium priority / Parity & Refactoring labels Oct 11, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit a9937bc into dev Oct 11, 2026
15 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1337-tables-extensions-settings-querya-button branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring ui User interface components and widgets ux User experience, keyboard shortcuts and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant