Repository navigation
refactor(ui): connection forms and dialogs on QueryaButton - #1421
Merged
Merged
Conversation
Footers of the connection forms, SQL editor dialogs, table privileges, theme dialogs, query history and the recovery app move to QueryaButton at lg (Cancel is ghost). Test Connection is a secondary button with the button's loading state instead of a hand-built spinner leading, and the certificate browse icon is a QueryaButton.icon with a tooltip. Part of #1338.
github-actions
Bot
added
enhancement
The dialog button moved to QueryaButton; the indexes view's own toolbar button is still a shadcn PrimaryButton, so the e2e flow taps one of each.
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1338 / #1331 (closes neither). Continues #1420.
What
Dialog and form footers move from shadcn buttons to
QueryaButton(mapping fromdocs/ui-kit.md; footer buttons arelg, Cancel / Close are ghost):QueryaThemeScope;QueryaButtontolerates that since refactor(ui): QueryaModalDialog and QueryaConfirmDialog on QueryaButton, off shadcn #1418).Beyond the mechanical replacement
secondarylg(smin the SSH section) button with the button's ownloadingstate, replacing the hand-builtQueryaSpinner/Iconleadingand the per-call colouredText. The standard says inline form actions use the button's loading state, not a separate spinner.loading: _submitting, same label switch.QueryaButton.iconwith aBrowse…tooltip instead of a bareGhostButton(child: Icon).Visible differences (intended)
Cancel / Close lose their outline; Test Connection is no longer tinted with the accent while the form is valid (it is a neutral secondary button, disabled when invalid); icon sizes follow the control size.
Method
A codemod rewrote only calls whose arguments it fully understood, and reported the rest; the reported ones were done by hand. The diff was read in full.
Tests
No test in these features looks for a shadcn button type (the existing finders use texts and keys;
Test Connectionis found by text).Not run locally; CI is the check.