Repository navigation
refactor(ui): Mongo and Redis panels on QueryaButton - #1422
Merged
Merged
Conversation
Toolbars, pagination and editors of the Mongo and Redis workspaces move from shadcn PrimaryButton / OutlineButton / GhostButton to QueryaButton at md (sm for the dense ones). Hand-built spinner leadings become the button's loading state, icon-only buttons are QueryaButton.icon with tooltips, and the tests that looked for shadcn button types look for QueryaButton. Part of #1337.
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1337 / #1331 (closes neither). Continues #1420 and #1421.
What
All shadcn
PrimaryButton/OutlineButton/GhostButtoncalls in the Mongo and Redis workspaces (14 files) becomeQueryaButton: toolbars, pagination, the document editor and tree, the stats view, the CLI, the keys view and the key / list editors. Panels and toolbars aremd; the dense ones (ButtonSize.small,ButtonDensity.compact) aresm.Beyond the mechanical replacement
leading: cond ? QueryaSpinner : Icon+ a label switch (Run Query, Run Pipeline, Refresh now, Save, redis Run) is the button's ownloading.QueryaButton.iconwith tooltips (the folder toggle's separateTooltipwrapper goes).Tests (paired in this PR)
mongo_query_workspace_test:widgetWithText(PrimaryButton, 'Run Query (Ctrl+Enter)')->QueryaButton.nosql_return_to_object_test:shadcn.OutlineButton->QueryaButton(these tests buildMongoStatsViewunder a bareShadcnApp;QueryaButtonworks without aQueryaThemeScopesince refactor(ui): QueryaModalDialog and QueryaConfirmDialog on QueryaButton, off shadcn #1418).e2e_mongo_index_manager_test: both Create Index taps areQueryaButtonnow (the indexes toolbar button moved too).Visible differences (intended)
Ghost / outline distinctions follow the standard map; icon sizes follow the control size; no hand-set 14 / 16 / 18 px icons.
Not in this PR
Postgres / MySQL / SQLite table toolbars, the grid, extensions and settings sections;
QueryaActionButton/QueryaActionMenuthemselves.Not run locally; CI is the check.