Repository navigation
refactor(ui): QueryaActionButton is a QueryaButton wrapper, off shadcn - #1424
Merged
Merged
Conversation
… off shadcn The action button keeps its API (label, icon, loading, isDestructive, tooltip, compact) but renders a QueryaButton.secondary; size is now a QueryaControlSize instead of shadcn's ButtonSize, so the three MCP preference buttons pass sm. The Execute (F5) finders in four tests look for QueryaButton. The file leaves the shadcn allow-list. Part of #1337 and #1365.
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1337 / #1365 (closes neither). Continues the migration (#1420-#1423).
What
QueryaActionButtonwas a shadcnOutlineButtonwith a hand-built spinner / icon / tone. It is now a thin wrapper that rendersQueryaButton.secondaryand keeps its API:label,icon,onPressed,loading,isDestructive(tone: destructive),tooltip,compact.sizewas shadcn'sButtonSize; it is nowQueryaControlSize?(default: the nearest control scope, thenmd). The three buttons of the MCP preferences section that passedButtonSize.smallpassQueryaControlSize.sm. No other call site passed a size.shadcn_flutterimport and leaves the allow-list.Visible difference (intended)
The icon and label of a neutral action button use the theme foreground instead of the accent colour; the height follows the control size (
md32 px) instead of shadcn'snormal.Tests
querya_action_button_test: the disabled case readsQueryaButton.onPressed.generic_sql_workspace_shortcuts_test(2),sql_workspace_execute_dirty_guard_testandextension_sql_workspace_testlook forQueryaButton; imports adjusted.Not in this PR
QueryaActionMenu(its trigger takes an arbitrarychild; its six call sites becomeQueryaMenuButtonnext) andExportMenuButton.Not run locally; CI is the check.