Skip to content

fix(configs): fix paths for data hydra yaml configs - #622

Merged
RyanPCo merged 1 commit into
mainfrom
ryanco/phase1-configs
Sep 20, 2026
Merged

RyanPCo merged 1 commit into
mainfrom
ryanco/phase1-configs

Conversation

@RyanPCo

@RyanPCo RyanPCo commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor
  • paths/default.yaml: restore root_dir (${oc.env:PROJECT_ROOT,${hydra:runtime.cwd}});
    log_dir had referenced it while it was commented out, so every top-level
    config failed a full resolve.
  • data/*.yaml (14 files): ${train_datasets.x} -> ${data.train_datasets.x}. Data
    configs are mounted under data., so the root-relative form raised
    InterpolationKeyError on the first cfg.data.valid_datasets[name] access;
    the repo default data: eva had been unrunnable since 4ca49ca (May).
  • data/mecka_pi.yaml, data/scale_pi.yaml: plain-dict / untargeted filters: ->
    DatasetFilter with filter_lambdas (the zarr resolver rejects anything else).
    mecka_pi's task string becomes 'fold_clothes', the value every other mecka
    config filters on; 'folding_clothes' matched nothing.
  • train_zarr_keypoints / train_zarr_keypoint_wrist: viz override pointed at
    eva_cartesian_aria_keypoints*, removed in 9788e2b (now keypoints*);
    the two files also had each other's data config.
  • viz_language.yaml: add the paths group its data config interpolates.
  • tests/unit/test_hydra_configs.py: composes and fully resolves every top-level
    config, every data option under every train config, every model / evaluator /
    viz option, and checks each data config's filters is a DatasetFilter
    (instantiated only for the base class; subclasses may need API keys).
    164 parametrized cases, no data, network, or cluster paths.

Co-Authored-By: Claude Fable 5.1 [email protected]
Claude-Session: https://claude.ai/code/session_01UHDiN8yfERcsiFdz4mXuZi

🤖 Generated with Claude Code

https://claude.ai/code/session_01UHDiN8yfERcsiFdz4mXuZi

@RyanPCo
RyanPCo marked this pull request as ready for review September 12, 2026 17:30
@RyanPCo
RyanPCo force-pushed the ryanco/phase1-configs branch from bee193a to f363b4d Compare September 12, 2026 19:39
@RyanPCo
RyanPCo force-pushed the ryanco/phase1-code-fixes branch 2 times, most recently from 23b5c36 to eae89d6 Compare September 12, 2026 21:28
@RyanPCo
RyanPCo force-pushed the ryanco/phase1-configs branch 2 times, most recently from 5aa55b6 to 793e0e5 Compare September 12, 2026 21:32
@RyanPCo
RyanPCo force-pushed the ryanco/phase1-code-fixes branch from eae89d6 to 3db4d2e Compare September 12, 2026 21:32
@RyanPCo
RyanPCo changed the base branch from ryanco/phase1-code-fixes to graphite-base/622 September 12, 2026 22:01
@RyanPCo
RyanPCo force-pushed the ryanco/phase1-configs branch from 793e0e5 to 046a402 Compare September 12, 2026 22:01
@RyanPCo
RyanPCo changed the base branch from graphite-base/622 to ryanco/delete-act September 12, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant