Skip to content

trainHydra: record the split and Lance versions a run read - #726

Draft
RyanPCo wants to merge 2 commits into
ryanco/hand-masksfrom
ryanco/run-data-manifest
Draft

RyanPCo wants to merge 2 commits into
ryanco/hand-masksfrom
ryanco/run-data-manifest

Conversation

@RyanPCo

@RyanPCo RyanPCo commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Every run writes split.json (train/valid dataset keys per train dataset) and,
with Lance datasets, lance_versions.json (table versions and their tags) next
to git_sha.txt; a requeue or resume that differs keeps the first file and
writes a timestamped one. Resolving an untagged Lance version warns that the
run is reproducible only until cleanup_old_versions drops it. Resuming from a
checkpoint whose run validated on episodes this run trains on warns.

https://claude.ai/code/session_01HjCQBqQCr2igFEMR7yUovw

RyanPCo commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@RyanPCo
RyanPCo force-pushed the ryanco/run-data-manifest branch from 8d2e1c3 to 07a66f7 Compare October 22, 2026 14:06
@RyanPCo
RyanPCo force-pushed the ryanco/run-data-manifest branch 2 times, most recently from 1671ffe to f12785f Compare October 23, 2026 19:36
@RyanPCo
RyanPCo force-pushed the ryanco/hand-masks branch 2 times, most recently from af0f481 to d28b3f8 Compare October 23, 2026 20:03
@RyanPCo
RyanPCo force-pushed the ryanco/run-data-manifest branch from f12785f to 1ef7b5e Compare October 23, 2026 20:03
@RyanPCo
RyanPCo force-pushed the ryanco/run-data-manifest branch from 1ef7b5e to 9c74259 Compare October 30, 2026 18:27

@RyanPCo RyanPCo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated adversarial review (read-only; findings were checked by a second skeptical pass before posting): 1 low.

),
**ann_kw,
)
untagged = sorted(n for n, t in self.manifest()["tags"].items() if not t)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low (efficiency): manifest() runs here only to find untagged tables, and MultiDataset._from_resolver calls it again right after. Each call lists tags on every table read, which means S3 metadata reads. Since self.versions is fixed by the end of resolve, compute it once (e.g. cache it on self) and reuse it in both places.

Every run writes split.json (train/valid dataset keys per train dataset) and,
with Lance datasets, lance_versions.json (table versions and their tags) next
to git_sha.txt; a requeue or resume that differs keeps the first file and
writes a timestamped one. Resolving an untagged Lance version warns that the
run is reproducible only until cleanup_old_versions drops it. Resuming from a
checkpoint whose run validated on episodes this run trains on warns.

Claude-Session: https://claude.ai/code/session_01Kt1E8T2x8kdV9akAvbJyVd
…ps table

Steps tables moved to steps/{lab}/{embodiment}/{end_effector}.lance in the
Lance schema change below this PR; the manifest test keyed versions by the
old steps/aria.lance path.

Claude-Session: https://claude.ai/code/session_01HjCQBqQCr2igFEMR7yUovw
@RyanPCo
RyanPCo force-pushed the ryanco/run-data-manifest branch from 9c74259 to 7115264 Compare October 30, 2026 23:05
@RyanPCo

RyanPCo commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Review findings: status after the fixup pass. The fixes are squashed into this PR's commits, and the whole stack was force-pushed.

Fixed

  • manifest() runs in resolve and again in _from_resolver: manifest() is cached until self.versions changes and returns a deep copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant