Repository navigation
Conversation
This was referenced Oct 22, 2026
Open
Contributor
Author
This was referenced Oct 22, 2026
RyanPCo
force-pushed
the
ryanco/hand-masks
branch
from
October 22, 2026 14:06
4e3e283 to
b097f9e
Compare
RyanPCo
force-pushed
the
ryanco/run-data-manifest
branch
from
October 22, 2026 14:06
8d2e1c3 to
07a66f7
Compare
RyanPCo
force-pushed
the
ryanco/hand-masks
branch
from
October 23, 2026 19:28
b097f9e to
8864ceb
Compare
RyanPCo
force-pushed
the
ryanco/run-data-manifest
branch
2 times, most recently
from
October 23, 2026 19:36
1671ffe to
f12785f
Compare
RyanPCo
force-pushed
the
ryanco/hand-masks
branch
2 times, most recently
from
October 23, 2026 20:03
af0f481 to
d28b3f8
Compare
RyanPCo
force-pushed
the
ryanco/run-data-manifest
branch
from
October 23, 2026 20:03
f12785f to
1ef7b5e
Compare
RyanPCo
force-pushed
the
ryanco/hand-masks
branch
from
October 30, 2026 18:27
d28b3f8 to
98b98e3
Compare
RyanPCo
force-pushed
the
ryanco/run-data-manifest
branch
from
October 30, 2026 18:27
1ef7b5e to
9c74259
Compare
RyanPCo
commented
Oct 30, 2026
RyanPCo
left a comment
Contributor
Author
There was a problem hiding this comment.
Automated adversarial review (read-only; findings were checked by a second skeptical pass before posting): 1 low.
| ), | ||
| **ann_kw, | ||
| ) | ||
| untagged = sorted(n for n, t in self.manifest()["tags"].items() if not t) |
Contributor
Author
There was a problem hiding this comment.
low (efficiency): manifest() runs here only to find untagged tables, and MultiDataset._from_resolver calls it again right after. Each call lists tags on every table read, which means S3 metadata reads. Since self.versions is fixed by the end of resolve, compute it once (e.g. cache it on self) and reuse it in both places.
Every run writes split.json (train/valid dataset keys per train dataset) and, with Lance datasets, lance_versions.json (table versions and their tags) next to git_sha.txt; a requeue or resume that differs keeps the first file and writes a timestamped one. Resolving an untagged Lance version warns that the run is reproducible only until cleanup_old_versions drops it. Resuming from a checkpoint whose run validated on episodes this run trains on warns. Claude-Session: https://claude.ai/code/session_01Kt1E8T2x8kdV9akAvbJyVd
…ps table
Steps tables moved to steps/{lab}/{embodiment}/{end_effector}.lance in the
Lance schema change below this PR; the manifest test keyed versions by the
old steps/aria.lance path.
Claude-Session: https://claude.ai/code/session_01HjCQBqQCr2igFEMR7yUovw
RyanPCo
force-pushed
the
ryanco/hand-masks
branch
from
October 30, 2026 23:05
98b98e3 to
ffd10b3
Compare
RyanPCo
force-pushed
the
ryanco/run-data-manifest
branch
from
October 30, 2026 23:05
9c74259 to
7115264
Compare
Contributor
Author
|
Review findings: status after the fixup pass. The fixes are squashed into this PR's commits, and the whole stack was force-pushed. Fixed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Every run writes split.json (train/valid dataset keys per train dataset) and,
with Lance datasets, lance_versions.json (table versions and their tags) next
to git_sha.txt; a requeue or resume that differs keeps the first file and
writes a timestamped one. Resolving an untagged Lance version warns that the
run is reproducible only until cleanup_old_versions drops it. Resuming from a
checkpoint whose run validated on episodes this run trains on warns.
https://claude.ai/code/session_01HjCQBqQCr2igFEMR7yUovw