Repository navigation
Fix WIA hash exceptions in the last sector of a group - #38
Open
communism420 wants to merge 2 commits into
Open
communism420 wants to merge 2 commits into
communism420 wants to merge 2 commits into
Conversation
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exclusive hash-area boundary for sector 63 is 65536, which overflows u16. Use u32 for the comparison so the final sector's exceptions are retained.
The regression covers the first and last exception offsets, rebasing, and adjacent-sector filtering. Before the fix it panics in debug and returns no exceptions in release; after the fix it passes in both. All 16 library tests also pass in debug and release on Windows x64 (
cargo test --locked -p nod --lib --target x86_64-pc-windows-msvc, with and without--release).Prepared with AI assistance.