Skip to content

Join preloader workers when the reader is dropped - #39

Open
communism420 wants to merge 1 commit into
encounter:mainfrom
communism420:codex/fix-preloader-shutdown
Open

communism420 wants to merge 1 commit into
encounter:mainfrom
communism420:codex/fix-preloader-shutdown

Conversation

@communism420

@communism420 communism420 commented Oct 13, 2026 •

Copy link
Copy Markdown

Dropping the last reader currently detaches preloader workers, and explicit shutdown can wait with the request sender still alive. Disconnect the original request/statistics channels first, then join every worker. A running read finishes before shutdown returns.

The regression checks channel closure and joining two workers. On Windows x64 / Rust 1.99, cargo test --locked -p nod --lib --target x86_64-pc-windows-msvc passed 16 tests; adding --no-default-features passed 15. This is independent of the read-ahead changes in #27.

Additional release validation of #38–#43 combined on wiidev/nod@9a7a6b2 passed 24 library tests (20 with no default features). These are combined-build results, separate from the standalone branch checks above.

Developed with AI assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant