Skip to content

Join digest workers on early drop and normal completion - #40

Open
communism420 wants to merge 1 commit into
encounter:mainfrom
communism420:codex/fix-digest-worker-shutdown
Open

communism420 wants to merge 1 commit into
encounter:mainfrom
communism420:codex/fix-digest-worker-shutdown

Conversation

@communism420

@communism420 communism420 commented Oct 13, 2026 •

Copy link
Copy Markdown

A writer error can skip DigestManager::finish and detach its workers. Close all digest input channels before joining any worker, and use the same cleanup on drop. Normal completion retains every digest and propagates a worker panic only after all workers have been joined.

Three regressions cover early drop, channel closure order, and normal digest results. On Windows x64 / Rust 1.99, cargo test --locked -p nod --lib --target x86_64-pc-windows-msvc passed 18 tests; adding --no-default-features passed 15.

Additional release validation of #38–#43 combined on wiidev/nod@9a7a6b2 passed 24 library tests (20 with no default features). These are combined-build results, separate from the standalone branch checks above.

Developed with AI assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant