Repository navigation
Preserve original Wii hash areas when writing WIA and RVZ - #42
Draft
communism420 wants to merge 3 commits into
Draft
communism420 wants to merge 3 commits into
communism420 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WIA/RVZ writer currently emits empty hash-exception lists. Reconstructing those images can change original Wii hashes and padding. Generate exceptions against the reconstructed partition-aligned hash group, preserve padding, and size WIA compression buffers for the encoded exceptions.
Depends on #38 and includes its commits; this is a draft until that prerequisite is resolved. Nine synthetic round trips cover encrypted/plaintext input, small and large chunks, partial groups, neighboring partitions, compression, and incompressible data. No private game dumps are included.
On Windows x64 / Rust 1.99,
cargo test --locked -p nod --lib --target x86_64-pc-windows-msvcpassed 19 tests and--test wia_losslesspassed 9. With--no-default-features, the corresponding counts were 19 and 4.Additional validation of #38–#43 combined on wiidev/nod@9a7a6b2 passed 24 library, 9 lossless and 2 progress tests in release; without default features the counts were 20, 4 and 2. All five doctests passed. In the combined patched TinyWiiBackupManager integration, all 24 USB games were exported to RVZ and their decoded SHA1 values matched the source images. These end-to-end results apply to the combined patches, not this branch alone.
Developed with AI assistance.