Repository navigation
Report WIA and RVZ progress for empty and reused groups - #43
Open
communism420 wants to merge 1 commit into
Open
communism420 wants to merge 1 commit into
communism420 wants to merge 1 commit into
Conversation
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty or reused WIA/RVZ groups currently skip the output callback, leaving callers without a progress or cancellation checkpoint. Call it with empty data before each group and at two finalization checkpoints, and document that behavior.
Synthetic GameCube fixtures check progress and callback-error propagation for empty/reused groups and finalization. On Windows x64 / Rust 1.99,
cargo test --locked -p nod --lib --target x86_64-pc-windows-msvcpassed 15 tests and--test wia_progresspassed 2, both with default features and with--no-default-features. Worker shutdown is addressed separately.The two progress/callback regressions also passed in release, with and without default features, in a combined #38–#43 build on wiidev/nod@9a7a6b2. The standalone branch counts above remain separate.
Developed with AI assistance.