Skip to content

Report WIA and RVZ progress for empty and reused groups - #43

Open
communism420 wants to merge 1 commit into
encounter:mainfrom
communism420:codex/wia-progress-checkpoints
Open

communism420 wants to merge 1 commit into
encounter:mainfrom
communism420:codex/wia-progress-checkpoints

Conversation

@communism420

@communism420 communism420 commented Oct 13, 2026 •

Copy link
Copy Markdown

Empty or reused WIA/RVZ groups currently skip the output callback, leaving callers without a progress or cancellation checkpoint. Call it with empty data before each group and at two finalization checkpoints, and document that behavior.

Synthetic GameCube fixtures check progress and callback-error propagation for empty/reused groups and finalization. On Windows x64 / Rust 1.99, cargo test --locked -p nod --lib --target x86_64-pc-windows-msvc passed 15 tests and --test wia_progress passed 2, both with default features and with --no-default-features. Worker shutdown is addressed separately.

The two progress/callback regressions also passed in release, with and without default features, in a combined #38–#43 build on wiidev/nod@9a7a6b2. The standalone branch counts above remain separate.

Developed with AI assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant