extras: robomimic and LIBERO on MuJoCo 2.3.7, mujoco on MuJoCo 3, as declared conflicts; lock current - #11
Merged
Merged
Conversation
…MuJoCo 3, declared as conflicts; the lock is current uv.lock still held robomimic 0.3.0 after the extra moved to 0.4.0, and relocking without declared conflicts would have put MuJoCo 2.3.7 under the `mujoco` extra as well. The `libero` extra, unpinned, resolved MuJoCo 3.6, which robosuite 1.4.1 rejects; it now pins 2.3.7, matching E42's recorded client environment. The README no longer gives one command for all six extras, which could not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs audit found
uv.lockout of date (uv lock --checkfails), and relocking it would have gone wrong. Resolving it per extra showed why:mujocorobomimicliberoThe
liberorow now matches the client environment E42 recorded on qz103: robosuite 1.4.1, MuJoCo 2.3.7 and robomimic 0.3.0.[tool.uv] conflictsdeclaresmujocoagainstrobomimicand againstlibero. The comment inpyproject.tomlalready said they belong in separate environments; uv now knows it too, and resolves each on its own MuJoCo. Asking for both givesExtras mujoco and robomimic are incompatible with the declared conflicts.liberopinsmujoco==2.3.7.uv.lockis regenerated with uv 0.9.8, anduv lock --checkpasses.The README gives two install groups instead of one command for all six extras:
mujoco,classic,atariandd4rltogether.robomimicorlibero, each in its own environment. They resolve together, but robomimic would move to 0.4.0, and LIBERO has only run on 0.3.0.The old command could not produce a working environment. The README records the correction.
The install without extras, which CI tests, resolves to the same versions as before. Slimming that default install (pandas unused, imageio's ffmpeg only for recording, per E45) is a separate PR.
Not included: a
uv lock --checkstep in CI, beforeuv sync --frozen.--frozennever asks whether the lock matchespyproject.toml, which is how this went unnoticed. My token cannot change workflow files, so that step is left for a follow-up.