[CP Staging] Revert "Add Vendor filter to expense Search" by c3024 · Pull Request #103211 · Expensify/App

c3024 · 2026-10-06T15:18:46Z

Explanation of Change

Reverts #101309 (Vendor filter in expense Search) to unblock the deploy. Members can see the Vendor filter but the picker only lists "No vendor". A fix will follow in a separate PR.

Fixed Issues

$ #103145
PROPOSAL: N/A

Tests

Sign in as a member of a workspace with an accounting connection that has vendors
Go to Spend > Filters
Verify there is no Vendor filter
Verify the Vendor column still shows in expense Search for workspaces with vendors

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…19-vendor-search-filter-column" This reverts commit 5005ab9, reversing changes made to e5fac34. # Conflicts: # tests/unit/PolicyUtilsTest.ts

melvin-bot · 2026-10-06T15:18:54Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-10-06T15:19:32Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

Beamanator

LGTM

Beamanator · 2026-10-06T15:41:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-10-06T15:48:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-06T16:06:47Z

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

…filter Revert "Add Vendor filter to expense Search" (cherry picked from commit ed72758) (cherry-picked to staging by Beamanator)

github-actions · 2026-10-06T16:11:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103211.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ed72758-0a74b97-073e3a0815f9892ef9a9c109eaf37275e7dc1f84/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ed72758-0a74b97-6f72ff6ad22412ef9955d867e38484fb4cf1f477/index.html

Web 🕸️
https://103211.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

os-botify · 2026-10-06T16:32:31Z

🔁 Filed a Staging retest request for deploy blockers #103145 after this PR was cherry-picked to staging.

OSBotify · 2026-10-06T16:32:53Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.5.3-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-06T16:41:54Z

No help site update is needed: this PR reverts the Vendor filter in expense Search, and no merged article under docs/articles mentions that filter or the vendor: search operator.

Note: the open docs PR [No QA] Docs updates for E/A#101309 Add vendor search operator to search operators article documents the reverted filter. Hold or close it until the fix PR brings the filter back.

view run

IuliiaHerets · 2026-10-06T17:37:34Z

Pass on Web build 9.5.3-2, checked Admin and Member

Vendor.Column.A.and.M.mp4

iPhone 15 iOS 26.6.1 build 9.5.3-2, don't see the Vendor filter at all, except on iOS we can't check the columns

No.vendors.MP4

OSBotify · 2026-10-06T21:58:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.3-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-10-06T22:29:44Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.5.4-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-06T22:36:57Z

No help site update is needed. This PR reverts the Vendor filter, and no article under docs/articles on main mentions that filter or a vendor: search operator.

One thing to watch: the open draft docs PR [No QA] Docs updates for E/A#101309 Add vendor search operator to search operators article adds the vendor: operator to the search operators article. Hold or close it until the Vendor filter fix ships. Otherwise the article will describe a filter the app no longer has.

view run

OSBotify · 2026-10-07T19:40:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

…-vendor-filter" This reverts commit ed72758, reversing changes made to cf6d740.

OSBotify · 2026-10-27T22:09:36Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.5.24-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-27T22:15:03Z

No help site update is needed. This PR temporarily reverted the Vendor filter, but [Payment due @eVoloshchak] Add Vendor filter to expense Search using workspace connections added it back. So the vendor: row in Use-Search-Operators-to-Filter-and-Analyze.md still matches the current app.

view run

OSBotify · 2026-10-29T00:56:50Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.24-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Revert "Merge pull request Expensify#101309 from c3024/chaitanya/6819…

da67370

…19-vendor-search-filter-column" This reverts commit 5005ab9, reversing changes made to e5fac34. # Conflicts: # tests/unit/PolicyUtilsTest.ts

c3024 requested review from a team as code owners October 6, 2026 15:18

melvin-bot Bot requested review from dylanexpensify and eVoloshchak and removed request for a team October 6, 2026 15:18

melvin-bot Bot removed the request for review from a team October 6, 2026 15:18

melvin-bot Bot assigned c3024 Oct 6, 2026

Beamanator approved these changes Oct 6, 2026

View reviewed changes

Beamanator merged commit ed72758 into Expensify:main Oct 6, 2026
39 of 41 checks passed

Beamanator changed the title ~~Revert "Add Vendor filter to expense Search"~~ [CP Staging] Revert "Add Vendor filter to expense Search" Oct 6, 2026

MelvinBot mentioned this pull request Oct 6, 2026

[Refactor] Move PolicyUtils vendor-matching helpers into vendor.ts #103135

Merged

44 tasks done

OSBotify pushed a commit that referenced this pull request Oct 6, 2026

Merge pull request #103211 from c3024/chaitanya/revert-101309-vendor-…

ef3ebef

…filter Revert "Add Vendor filter to expense Search" (cherry picked from commit ed72758) (cherry-picked to staging by Beamanator)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 6, 2026

OSBotify mentioned this pull request Oct 6, 2026

Deploy Checklist: New Expensify 2026-10-05 #103094

Closed

93 tasks done

melvin-bot Bot mentioned this pull request Oct 6, 2026

[Due for payment 2026-11-05] iOS-Spend- Synced Vendors list is not updated in Filter with non-admin member #103145

Closed

1 of 7 tasks

MelvinBot mentioned this pull request Oct 8, 2026

Campfire - Vendor option is missing from the Spend filters #103404

Closed

2 of 7 tasks

MelvinBot mentioned this pull request Oct 16, 2026

[$175] Filters - Vendor option is missing in filters #104176

Open

2 of 7 tasks

c3024 mentioned this pull request Oct 19, 2026

[Payment due @eVoloshchak] Add Vendor filter to expense Search using workspace connections #104351

Merged

38 tasks done

Beamanator pushed a commit that referenced this pull request Oct 26, 2026

Revert "Merge pull request #103211 from c3024/chaitanya/revert-101309…

8fa9430

…-vendor-filter" This reverts commit ed72758, reversing changes made to cf6d740.

OSBotify mentioned this pull request Oct 27, 2026

Deploy Checklist: New Expensify 2026-10-27 #105183

Closed

97 tasks done

This was referenced Oct 27, 2026

Expense-Unable to switch off "reimbursable" toggle when creating expense #105205

Closed

Spend - Vendor filter is present in Spend / Filters #105207

Closed

Conversation

c3024 commented Oct 6, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 6, 2026

Uh oh!

melvin-bot Bot commented Oct 6, 2026

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

os-botify Bot commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

MelvinBot commented Oct 6, 2026

Uh oh!

IuliiaHerets commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

MelvinBot commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 7, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

MelvinBot commented Oct 27, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Beamanator commented Oct 6, 2026 •

edited

Loading