Repository navigation
[Due for payment 2026-11-05] iOS-Spend- Synced Vendors list is not updated in Filter with non-admin member #103145
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.3-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #101309
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: iPhone 11 iOS 26.7.1
App Component: Workspace Settings
Action Performed:
Preconditions:
- Use new 2 Expensifail accounts thats never connect QBO before
- Admin connect QBO to workspace, set up "Export company card expenses as" set to Credit card. Invite non-admin member to workspace
- Open Hybrid app
- Log in as member
- Go to Spend
- Tap on Filter button
- Tap on Vendor item in list
Expected Result:
Vendor appears in the filter list with the workspace's synced vendors.
Actual Result:
Only 'no vendor' is displayed in Vendor list
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7278431_1791258421593.Isu.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7278431
Issue Owner
Current Issue Owner: @eVoloshchakMetadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Oct 6, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e2bd93165fb9075d1ced1d64c1e8ed02f46f41f691ec01454a7b3c87eb5b6055
https://platform.applause.com/services/links/v1/external/a60e25ced23d03d52873f5459517011f995a7ec82a8b9a3c1435c367f874ecfb
melvin-bot commentedon Oct 6, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #101309
melvin-bot commentedon Oct 6, 2026
@Beamanator @eVoloshchak you have been assigned to this deploy blocker because you reviewed the offending PR: #101309
github-actions commentedon Oct 6, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 6, 2026
@c3024 you have been assigned to this deploy blocker because you authored the offending PR: #101309
melvin-bot commentedon Oct 6, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 6, 2026
Deploy Blocker Analysis
Causing PR: Add Vendor filter to expense Search added this feature. The App code doesn't filter by role, so the empty list most likely means the server sends no vendor data to non-admin members. Confidence: medium.
Recommendation: Don't revert. The feature is new and staging-only, so nothing that works in production breaks. Treat this as a backend/internal issue; a separate internal investigation is needed. Consider demoting the blocker once that is confirmed.
Investigation details
Why the list shows only "No vendor"
VendorSelector.tsx:34callsuseLoadSearchVendorData, which sendsOpenSearchVendorFiltersPage(Search.ts:1081-1107). The App sets only loading flags. The server fillspolicyVendors_<policyID>.VendorSelector.tsx:52-70always adds "No vendor" first, then adds names frompolicyVendors_*for eligible workspaces. It has no role check.So "only No vendor" means
policyVendors_<policyID>is empty or missing on the member's device.The filter doesn't read
policy.connections.quickbooksOnline.data.vendors. That field feeds the expense-level Vendor picker (PolicyUtils/index.ts:2483).This is a gap, not a known limitation. Step 10 of the PR's test plan says a non-admin member should see the synced vendors. The PR's screenshots don't show that step.
How to confirm
OpenSearchVendorFiltersPageresponse containspolicyVendors_<policyID>. If it doesn't, the fix belongs on the backend.getMatchingVendors(policy)for workspaces that have nopolicyVendors_entry.Next Steps: Reply with
@MelvinBot <your feedback>to refine this analysis.view run
8 remaining items
[-]iOS-Spend- Synced Vendors list is not updated in Filter with non-admin member[/-][+][Due for payment 2026-10-13] iOS-Spend- Synced Vendors list is not updated in Filter with non-admin member[/+]melvin-bot commentedon Oct 6, 2026
@eVoloshchak
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-13. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 8, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 28, 2026
c3024 commentedon Oct 28, 2026
False flag. ⬆️
Beamanator commentedon Oct 28, 2026
agreed, i hid it - than ks
[-][Due for payment 2026-10-13] iOS-Spend- Synced Vendors list is not updated in Filter with non-admin member[/-][+][Due for payment 2026-11-05] iOS-Spend- Synced Vendors list is not updated in Filter with non-admin member[/+]melvin-bot commentedon Oct 29, 2026
@eVoloshchak
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-05. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]