Skip to content

Spend - Vendor filter is present in Spend / Filters #105207

Closed
Closed
Spend - Vendor filter is present in Spend / Filters#105207
Assignees
Beamanatorc3024
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Description

@applause-bot
applause-bot
bot
opened on Oct 28, 2026

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: v9.5.24-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103211
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Desktop / Windows 11
App Component: Left Hand Navigation (LHN)

Action Performed:

Preconditions:

  • Create a Control workspace.
  • Enable Accounting.
  • Connect a connector that has vendors (QuickBooks Online in my case).
  1. Open the Expensify Web App and log in
  2. Go to Spend and click on Filters
  3. Try to locate the "Vendor" filter

Expected Result:

The "Vendor" filter should not be present in the list of available filters.

Actual Result:

The "Vendor" filter is present in the list of available filters.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7298396_1793143784211.Expensify_PR103211_Vendor_Web.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Alberto Gutierrez
Bug ID: 7298396

Activity

  1. applause-bot
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2026
  2. gleitebr
    added this to #expensify-bugson Oct 28, 2026

  3. applause-bot commented on Oct 28, 2026

    @applause-bot
    applause-botBot
    on Oct 28, 2026
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/d3e238f6a189a859a46e4f290e6b0a22e9278cf66e41cc4c60a2f93b507fbeda

    https://platform.applause.com/services/links/v1/external/b624f5697dc846bc433ec04efbdf76fe7c7294c7ea644d89ddc79d6a46c83b8f

  4. melvin-bot
    assigned
    Beamanator
    on Oct 28, 2026

  5. melvin-bot commented on Oct 28, 2026

    @melvin-bot
    melvin-botBot
    on Oct 28, 2026 – with Melvin Bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103211

  6. melvin-bot commented on Oct 28, 2026

    @melvin-bot
    melvin-botBot
    on Oct 28, 2026 – with Melvin Bot

    @Beamanator you have been assigned to this deploy blocker because you reviewed the offending PR: #103211

  7. melvin-bot
    assigned
    c3024
    on Oct 28, 2026

  8. melvin-bot commented on Oct 28, 2026

    @melvin-bot
    melvin-botBot
    on Oct 28, 2026 – with Melvin Bot

    @c3024 you have been assigned to this deploy blocker because you authored the offending PR: #103211

  9. melvin-bot commented on Oct 28, 2026

    @melvin-bot
    melvin-botBot
    on Oct 28, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  10. github-actions
    added
    Engineering
    HourlyKSv2
    on Oct 28, 2026

  11. github-actions commented on Oct 28, 2026

    @github-actions
    github-actionsBot
    on Oct 28, 2026 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  12. MelvinBot commented on Oct 28, 2026

    @MelvinBot
    MelvinBot
    on Oct 28, 2026
    Contributor

    Deploy Blocker Analysis

    Not a bug. The Vendor filter showing up is intended. Recommend closing this issue and removing DeployBlockerCash. Do not revert anything.

    Applause tested the QA steps from the revert PR. A later PR in the same release added the filter back on purpose.

    Investigation details

    Timeline:

    1. [Payment due @eVoloshchak] Add Vendor filter to expense Search added the filter on 2026-10-05.
    2. [CP Staging] Revert "Add Vendor filter to expense Search" removed it on 2026-10-06. Its QA step "Verify there is no Vendor filter" is the step that failed here.
    3. [Payment due @eVoloshchak] Add Vendor filter to expense Search using workspace connections brought the filter back on 2026-10-26, with a fix for the original bug. Its QA expects the opposite result: on a QBO workspace, "Verify Vendor appears next to Category and Tag."

    Both PRs are on Deploy Checklist: New Expensify 2026-10-27. This explains why the filter shows on staging but not production.

    Gating (App 13567c65):

    Caveat: the issue doesn't say which QBO export setting the tester used. Suppose it was something other than Credit Card or Debit Card, and none of the tester's other workspaces qualify. Then showing the filter would be a real bug in the gating from #104351, not #103211. Ask the tester to confirm the setting before you close.

    Confidence: High.

    Next steps: Close this issue, remove DeployBlockerCash, and ask Applause to use the QA steps from #104351. c3024 and Beamanator were auto-assigned and can be unassigned.

    view run

  13. c3024 commented on Oct 28, 2026

    @c3024
    c3024
    on Oct 28, 2026
    Contributor

    @m-natarajan

    #103211 is already in production. Botify incorrectly marked it as deployed to staging again yesterday. There’s nothing to QA for this PR.

    You need to QA #104351, which appears to have already been done, as it’s checked off on the list.

  14. c3024 commented on Oct 28, 2026

    @c3024
    c3024
    on Oct 28, 2026
    Contributor

    @Beamanator the expected result is incorrect here. This is not a deploy blocker, so it can be closed.

  15. Beamanator commented on Oct 28, 2026

    @Beamanator
    Beamanator
    on Oct 28, 2026
    Contributor

    yeah i agree with everything you said here @c3024 , closing!

  16. Beamanator
    closed this as completedon Oct 28, 2026
  17. github-project-automation
    moved this to Done in #expensify-bugson Oct 28, 2026
  18. github-actions
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions