Skip to content

Campfire - Vendor option is missing from the Spend filters #103404

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: v9.5.5-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103146
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.5.1 Safari, iPhone 13 iOS 26.6
App Component: Search

Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with an account that is not in the vendorMatching beta
  3. Open a workspace connected to Campfire that finished setup
  4. Go to More features and verify the Vendors row shows, switched on and locked
  5. Go to Reports > Expenses > Filters

Expected Result:

Vendor is listed with the Campfire vendors in the filters

Actual Result:

Vendor option is missing from the Spend filters

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7280604_1791411341005.Recording__3110.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7280604

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 8, 2026
  2. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103146

  3. applause-bot commented on Oct 8, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/02f4ea9332aa2098474d46f52a5af93621096cf174dba6ada20e4c61cc62271b

  4. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    @mollfpr you have been assigned to this deploy blocker because you reviewed the offending PR: #103146

  5. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    @lakchote you have been assigned to this deploy blocker because you authored the offending PR: #103146

  6. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Oct 8, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Oct 8, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Investigation

    Not a regression. Remove Campfire vendor matching beta requirement did not cause this. The Vendor filter is missing for every user, with or without the beta. [CP Staging] Revert "Add Vendor filter to expense Search" removed it on purpose on 2026-10-06, about 18 hours before #103146 merged.

    Recommendation: Demote. No revert or fix is needed for this deploy. A human should remove DeployBlockerCash or close the issue.

    Investigation details

    The filter isn't in the code

    Timeline

    1. [Payment due @eVoloshchak] Add Vendor filter to expense Search added the filter on 2026-10-05. It showed only when hasVendorFeatureOnAnyPolicy was true.
    2. [CP Staging] Revert "Add Vendor filter to expense Search" #103211 reverted it on 2026-10-06 to fix [Due for payment 2026-10-13] iOS-Spend- Synced Vendors list is not updated in Filter with non-admin member. Its QA steps check that no Vendor filter is shown.
    3. Remove Campfire vendor matching beta requirement #103146 merged on 2026-10-07. Its step 8 ("verify Vendor is listed" in Filters) assumed a filter that was no longer there. Applause filed this bug from that step.

    Why #103146 is correct

    It changes only src/libs/PolicyUtils/vendor.ts:115-137 and WorkspaceMoreFeaturesPage/index.tsx:181-199, plus tests. It doesn't touch any Search filter file. Reverting it would not bring the filter back. It would only hide the Campfire Vendors row again for users outside the beta.

    Next steps


    view run

  9. mollfpr commented on Oct 8, 2026

    @mollfpr
    Contributor

    Agree with Melvin's analysis here, this isn't caused by Expensify/App#103146. The vendor filter was already removed by Expensify/App#103211 before this PR even merged, so there's nothing to revert or fix on our side.

    @lakchote can you confirm so we can close this out?

  10. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 8, 2026
  11. lakchote commented on Oct 8, 2026

    @lakchote
    Contributor

    @mollfpr yea confirmed. This isn't from #103146. The Vendor filter got reverted in #103211 before my PR merged, so it's not on staging or prod for anyone.

    Step 8 in my QA steps was stale so I took it out. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions