You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Campfire - Vendor option is missing from the Spend filters #103404
Version Number: v9.5.5-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#103146 Email or phone of affected tester (no customers): n/a Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Mac 26.5.1 Safari, iPhone 13 iOS 26.6 App Component: Search
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Agree with Melvin's analysis here, this isn't caused by Expensify/App#103146. The vendor filter was already removed by Expensify/App#103211 before this PR even merged, so there's nothing to revert or fix on our side.
@lakchote can you confirm so we can close this out?
@mollfpr yea confirmed. This isn't from #103146. The Vendor filter got reverted in #103211 before my PR merged, so it's not on staging or prod for anyone.
Step 8 in my QA steps was stale so I took it out. Closing this.
Activity
melvin-bot commentedon Oct 8, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103146
applause-bot commentedon Oct 8, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/02f4ea9332aa2098474d46f52a5af93621096cf174dba6ada20e4c61cc62271b
melvin-bot commentedon Oct 8, 2026
@mollfpr you have been assigned to this deploy blocker because you reviewed the offending PR: #103146
melvin-bot commentedon Oct 8, 2026
@lakchote you have been assigned to this deploy blocker because you authored the offending PR: #103146
melvin-bot commentedon Oct 8, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 8, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 8, 2026
Deploy Blocker Investigation
Not a regression. Remove Campfire vendor matching beta requirement did not cause this. The Vendor filter is missing for every user, with or without the beta. [CP Staging] Revert "Add Vendor filter to expense Search" removed it on purpose on 2026-10-06, about 18 hours before #103146 merged.
Recommendation: Demote. No revert or fix is needed for this deploy. A human should remove
DeployBlockerCashor close the issue.Investigation details
The filter isn't in the code
VENDORkey: src/CONST/index.ts:8105-8160Timeline
hasVendorFeatureOnAnyPolicywas true.Why #103146 is correct
It changes only src/libs/PolicyUtils/vendor.ts:115-137 and WorkspaceMoreFeaturesPage/index.tsx:181-199, plus tests. It doesn't touch any Search filter file. Reverting it would not bring the filter back. It would only hide the Campfire Vendors row again for users outside the beta.
Next steps
hasVendorFeatureOnAnyPolicygate. With Remove Campfire vendor matching beta requirement #103146 in place, that gate already shows the filter for Campfire workspaces without the beta.lakchoteandmollfprdon't need to stay assigned.c3024owns the Vendor filter work.view run
mollfpr commentedon Oct 8, 2026
Agree with Melvin's analysis here, this isn't caused by Expensify/App#103146. The vendor filter was already removed by Expensify/App#103211 before this PR even merged, so there's nothing to revert or fix on our side.
@lakchote can you confirm so we can close this out?
lakchote commentedon Oct 8, 2026
@mollfpr yea confirmed. This isn't from #103146. The Vendor filter got reverted in #103211 before my PR merged, so it's not on staging or prod for anyone.
Step 8 in my QA steps was stale so I took it out. Closing this.