Repository navigation
Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row v2 - #100015
Conversation
…g to and highlighting the row" This reverts commit 47ece02.
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…deleting same report on RHP
… when submissions are disabled
…on growl after opening it
…m growl and splitting expense
…wl to another report offline
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 208954f558
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.1-0 🚀
|
|
No help site update needed. The new "Expense added" growl is an in-app confirmation message, and no article under |
|
Deploy Blocker #102831 was identified to be related to this PR. |
|
Deploy Blocker #102833 was identified to be related to this PR. |
|
Hi @mhawryluk. QA team failed this PR on Android with #99255 1790901045815.View_12.mp4 |
|
Deploy Blocker #102845 was identified to be related to this PR. |
this PR should fix it: #102847 |
|
Deploy Blocker #102848 was identified to be related to this PR. |
|
Deploy Blocker #102850 was identified to be related to this PR. |
|
Deploy Blocker #102857 was identified to be related to this PR. |
|
Deploy Blocker #102889 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.1-9 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Another attempt after the previous PR has been reverted.
Shows an "Expense added" growl (with a "View" action) after an expense is created from FAB outside of its report‚ as well as when duplicating and splitting expenses on Spend. Removes the highlighting of new expenses in the Spend tab tables completely.
It's driven declaratively by a single ExpenseAddedGrowl component, which watches an Onyx signal that the creation flows write to (same as they did for highlighting). In the #94866 each creation flow triggered the growl and its navigation imperatively, passing values that could go stale before the user tapped "View". Centralizing it in one Onyx-driven component matches main more closely and solves the stale-data problem.
Fixed Issues
$ #91408
PROPOSAL: N/A
Tests
Flows from deploy blockers that caused the revert:
Expense - Report on central pane changes to not here page after deleting same report on RHP
Expense - Expense added growl does not appear after changing report and creating expense
Expense - No Expense added growl after splitting expense from report opened from LHN
Report - WS avatar disappears when moving expense opened via growl to another report offline
Expense added growl is not shown after creating per diem expense when submissions are disabled
Android - Expense - Report is opened a second time when tapping on growl after opening it
Android - Expense - No growl after splitting/bulk duplicating expense
Android - Workspace chat opens briefly after opening expense from growl and splitting expense
Expense - Expense added growl is hidden behind Concierge side panel
Standard test cases:
Growl + "View" from global create (Inbox tab)
Growl in the Spend tab
"View" opens the correct destination for the current surface
Single growl/single navigation on a batch (skip-confirm multi-scan)
Invoice
Split an existing expense into multiple (in Spend)
Bulk duplicate expenses
Self-DM expense
Share flow (native only)
Offline tests
QA Steps
Same as tests + offline tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2026-09-2.o.15.06.37.mov
Nagranie.z.ekranu.2026-09-2.o.14.41.30.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-3.o.21.02.18.mov
Nagranie.z.ekranu.2026-09-2.o.15.51.45.mov
Nagranie.z.ekranu.2026-09-1.o.17.08.07.mov
Nagranie.z.ekranu.2026-09-1.o.16.52.10.mov