You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - View expense growl does not appear after splitting unreported expense from Home #102823
Version Number: 9.5.1-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#100015 Email or phone of affected tester (no customers):[email protected] Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to self DM.
Create an expense.
Go to Home.
Open the expense from Recently added section.
Click More > Split > Save.
Expected Result:
View expense growl will appear because user is not on report view with expense list.
Actual Result:
View expense growl does not appear after splitting unreported expense from Home.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: Splitting an unreported (self-DM) expense opened from Home takes the self-DM branch in SplitTransactionUpdate.ts:2102-2111. That branch returns early and never calls signalExpenseAddedGrowl. The only split growl signal is at SplitTransactionUpdate.ts:2131-2133, and it fires only when Spend is the topmost full-screen route.
Recommendation: Fix forward instead of reverting, and consider demoting.
Production has no growl, and the old row highlight was also Spend-only. A split saved from Home gave no confirmation before this PR either.
The split itself works. Only the confirmation growl is missing.
Reverting a ~70-file PR that is already a second attempt is out of proportion to this gap.
Suggested fix: In the self-DM branch, check before dismissing the panel whether the user is outside both Inbox and Spend (for example, on Home). If so, call signalExpenseAddedGrowl(getNewSplitTransactionIDs().at(-1), CONST.SEARCH.DATA_TYPES.EXPENSE) after updateSplitTransactions when !isReverseSplitOperation. The check must be explicit. Otherwise the growl would also show in the self-DM chat and in Inbox, which the PR's test case 6 says should not happen.
Investigation details
Home opens the expense in the right-side panel: RecentlyAddedSection/index.tsx:88 navigates to SEARCH_REPORT with backTo: HOME. Home stays the full-screen route, so isSearchTopmostFullScreenRoute() returns false.
In SplitTransactionUpdate.ts:2089, isSelfDMSplit is true for this repro. The branch dismisses the modal, runs updateSplitTransactions, and returns. The PR did not change these lines.
ExpenseAddedGrowl.tsx:97-121 renders only when RAM_ONLY_EXPENSE_ADDED_GROWL_TRANSACTION_IDS is written. With no signal, nothing appears.
The growl's own self-hide check (ExpenseAddedGrowl.tsx:116) compares the focused report with transaction.reportID. Unreported split children carry the unreported placeholder ID, not the self-DM report ID, so the growl would not hide itself in the self-DM chat. This is why the fix needs an explicit Home check.
Open question for the PR author: A workspace expense split from Home takes the dismissModalWithReport path (SplitTransactionUpdate.ts:2181-2185). It does not appear to signal a growl either, but the PR's test steps expect a "View" growl in that case. Please confirm whether Home split growls are in scope. This analysis is from code only; I did not test live.
Timing: the PR merged 2026-10-01 and is in 9.5.1-1. The bug was reported 2026-10-02.
Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
not a bug, this is the expected behavior. per this summary:
We show the growl when splitting expenses in Spend, but not in Inbox.
Home wasn't explicitly named, but it wasn't meant to get the growl, there was no highlight there previously, so we don't lose any information. we can add it in this case if we want though, but we shouldn't block deploy over this
Activity
applause-bot commentedon Oct 2, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/21735c70a749652b3bc6e51c3fe0ea6c720f068038a4ee5e39e5976fae657779
melvin-bot commentedon Oct 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #100015
github-actions commentedon Oct 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 2, 2026
@mountiny @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100015
melvin-bot commentedon Oct 2, 2026
@mhawryluk you have been assigned to this deploy blocker because you authored the offending PR: #100015
melvin-bot commentedon Oct 2, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 2, 2026
Deploy Blocker Analysis
Causing PR: Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row v2. This PR shipped the growl, but it never wired the growl into the self-DM split path. Nothing that works in production broke. The first attempt, Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row, had the same gap.
Root cause: Splitting an unreported (self-DM) expense opened from Home takes the self-DM branch in
SplitTransactionUpdate.ts:2102-2111. That branch returns early and never callssignalExpenseAddedGrowl. The only split growl signal is atSplitTransactionUpdate.ts:2131-2133, and it fires only when Spend is the topmost full-screen route.Recommendation: Fix forward instead of reverting, and consider demoting.
Suggested fix: In the self-DM branch, check before dismissing the panel whether the user is outside both Inbox and Spend (for example, on Home). If so, call
signalExpenseAddedGrowl(getNewSplitTransactionIDs().at(-1), CONST.SEARCH.DATA_TYPES.EXPENSE)afterupdateSplitTransactionswhen!isReverseSplitOperation. The check must be explicit. Otherwise the growl would also show in the self-DM chat and in Inbox, which the PR's test case 6 says should not happen.Investigation details
RecentlyAddedSection/index.tsx:88navigates toSEARCH_REPORTwithbackTo: HOME. Home stays the full-screen route, soisSearchTopmostFullScreenRoute()returnsfalse.SplitTransactionUpdate.ts:2089,isSelfDMSplitistruefor this repro. The branch dismisses the modal, runsupdateSplitTransactions, and returns. The PR did not change these lines.ExpenseAddedGrowl.tsx:97-121renders only whenRAM_ONLY_EXPENSE_ADDED_GROWL_TRANSACTION_IDSis written. With no signal, nothing appears.ExpenseAddedGrowl.tsx:116) compares the focused report withtransaction.reportID. Unreported split children carry the unreported placeholder ID, not the self-DM report ID, so the growl would not hide itself in the self-DM chat. This is why the fix needs an explicit Home check.Open question for the PR author: A workspace expense split from Home takes the
dismissModalWithReportpath (SplitTransactionUpdate.ts:2181-2185). It does not appear to signal a growl either, but the PR's test steps expect a "View" growl in that case. Please confirm whether Home split growls are in scope. This analysis is from code only; I did not test live.Timing: the PR merged 2026-10-01 and is in 9.5.1-1. The bug was reported 2026-10-02.
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mhawryluk commentedon Oct 2, 2026
not a bug, this is the expected behavior. per this summary:
Home wasn't explicitly named, but it wasn't meant to get the growl, there was no highlight there previously, so we don't lose any information. we can add it in this case if we want though, but we shouldn't block deploy over this
melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.