Skip to content

[CP Staging] fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl - #102854

Merged
Julesssss merged 6 commits into
Expensify:mainfrom
software-mansion-labs:fix/growl-arrow-navigation
Oct 2, 2026
Merged

Julesssss merged 6 commits into
Expensify:mainfrom
software-mansion-labs:fix/growl-arrow-navigation

Conversation

@mhawryluk

@mhawryluk mhawryluk commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

Opening a new expense with "View" on the "Expense added" growl didn't show the previous/next arrows, even when the report had other expenses. Closing the expense and reopening it from the report made the arrows appear.

Wide layout: "View" opens the expense report and then the expense on top of it. Before opening the expense, it set the arrow list (setActiveTransactionIDs) to only the new expense, so there was nothing to step to. It now sets every expense on the report that isn't pending deletion.

Narrow layout: "View" opened the expense as a full report (r/<threadID>). Arrows only render on SEARCH_REPORT, so they could never appear there. It now does what tapping an expense in the report preview does: open the expense report, set the arrow list, then open the expense as SEARCH_REPORT on top. Back and delete now land on the expense report, the same as when the expense is opened from the report.

Fixed Issues

$ #102848
PROPOSAL: N/A

Tests

  1. Navigate to workspace chat.
  2. Create a manual expense.
  3. Navigate to "Inbox"
  4. Create a new manual expense via FAB and submit it to the same report in workspace chat.
  5. Click on "View" in the displayed growl.
  6. Verify that when expense is opened arrow navigation is visible on top.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Nagranie.z.ekranu.2026-10-2.o.12.36.28.mov
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-10-2.o.11.05.18.mov

@mhawryluk mhawryluk closed this Oct 2, 2026
@mhawryluk mhawryluk reopened this Oct 2, 2026
@mhawryluk
mhawryluk marked this pull request as ready for review October 2, 2026 10:37
@mhawryluk
mhawryluk requested review from a team as code owners October 2, 2026 10:37
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and situchan and removed request for a team October 2, 2026 10:37
@melvin-bot

melvin-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 2, 2026 10:37
@situchan

situchan commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

Review

The fix works for the main case, and the narrow-layout branch matches the report preview flow. CI passes apart from the approval check. I found one issue you should fix before merge.

1. The arrows step through expenses in the wrong order. The growl seeds openableTransactionIDs straight from useReportTransactions, which is Object.values of the transactions collection. That is creation order, not the order the report shows:

The report preview sorts its list first (useReportPreviewCarousel.tsx:87-108). The report view won't correct the order either: it keeps any seed with the same set of IDs (useMoneyRequestReportActiveTransactionIDs.ts:32-38).

Example: a report has expenses dated Oct 1 and Sep 15. You add a Sep 20 expense and press "View". The report lists them oldest first: Sep 15, Sep 20, Oct 1. The arrows treat the new expense as the last one, so "Next" is disabled when it should open Oct 1.

Fix: Sort the IDs the same way the report sorts them before you seed them. Add a test where creation order and display order differ.

2. Question: the Search and Home tabs still seed only the new expense. navigateToCreatedExpense.ts:58-61 still calls setActiveTransactionIDs([transactionID]). Pressing "View" outside the Inbox shows no arrows. Is that intended?

Nits

  • Line 67: iouReportID && is redundant, because hasMultipleReportTransactions is already false without it.
  • Line 41: the "Don't reopen an expense…" comment now sits above the ID mapping. Move it down to the early-return check.

I reviewed the code only. I did not test the flow in the app.


view run

@situchan

situchan commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

I approved all PRs except this one.
Please check remaining blockers if this PR will fix them

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Web test steps verification results: ✅ pass

On web (wide layout), pressing "View" on the "Expense added" growl opened the new expense with prev/next arrows. The arrows followed the report's list order in both directions, and no regressions showed up in this flow.
Sep 15 expense reached via Previous, Previous disabled

Step Status
VERIFY 1: "View" on the growl opens the Sep 20 expense on top of its report, with prev/next arrows in the header"View" opened the "$30.00 for Test Merchant 3" (Sep 20) expense directly. The "<" and ">" arrows were visible next to "More" in the header.
Expense opened from growl View with prev/next arrows
Sep 20 expense with prev/next arrows
✅
VERIFY 2: From the Sep 20 expense, the arrows follow the report's list orderThe report lists Sep 15 ($20), Sep 20 ($30), Oct 1 ($10). From Sep 20, "Next" opened Oct 1 and was then disabled. "Previous" opened Sep 15 and was then disabled.
Report list order Sep 15, Sep 20, Oct 1
✅
VERIFY 3: Back returns to the expense report, then to the chatThe first Back opened the expense report's list. The second Back opened the workspace chat, which is where the app had switched when the expense was created.
✅
VERIFY 4: An expense opened from the report list still has working arrows in list orderOpening Oct 1 from the list showed "Next" disabled. "Previous" went to Sep 20, then to Sep 15, where "Previous" was disabled.
Sep 15 expense reached via Previous, Previous disabled
✅

view run

@MelvinBot

MelvinBot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Regressions

I found one regression, on narrow layout only. It needs a report to already be open in the RHP when you press "View". The main path works, and the web test above passed.

1. A report is already open in the RHP: "View" replaces it and skips the expense report. For example, you open another expense from a report preview while the growl is still showing, then press "View".

  • Before: linkTo turned the forced replace into a push, because the target was a full-screen report (linkTo/index.ts:248-251). The thread opened above the RHP, and Back returned to it.
  • After: shouldOpenExpenseReport is false whenever forceReplace is true (navigateToCreatedExpense.ts:68). The thread RHP replaces the open RHP (:74).
  • Result: The thread's own expense report never opens. Back and delete land on whatever was underneath, often a different report. The RHP you had open is lost from history. If that RHP was this expense report, the thread replaces it, so Back skips the report.
  • Fix: Handle forceReplace the way the wide branch does at :85-97. Open the expense report first, then stack the thread on it. Add a narrow-layout forceReplace test, since none exists.

2. Minor: after a forced replace, reloading on mobile web can land on the Spend tab.

  • getCurrentRouteBackTo() returns undefined when the replaced route has no backTo (:28-34).
  • The URL then becomes search/view/<thread> with no backTo, and on reload SEARCH_REPORT falls back to Search.
  • The old r/<thread> URL stayed in the Inbox. Fixing item 1 also fixes this.
Checked and fine
  • Back and delete on the main path now land on the expense report instead of the chat. That is intended and matches the report preview.
  • The thread RHP keeps the composer and the hold, approve, and delete actions. It loses only the header's search and help buttons, which is the same as the report preview path.
  • Invoices always create a new report, so they never reach the new branch.
  • Optimistic threads open fine in the RHP.
  • Active transaction IDs still clear when the RHP closes, because the arrows component clears them on unmount (MoneyRequestReportTransactionsNavigation.tsx:122-130).
  • The pending-delete filters match the report list, online and offline.

About the arrow order from my earlier review: the web test didn't reproduce it. The tester had to set dates by editing the expenses after creating them, so the run may not have tested this case cleanly. The code still seeds the IDs unsorted (useReportTransactions.ts:9-12). Treat that finding as unconfirmed, not as a regression, because the arrows didn't show at all before this PR.

I found these regressions by reading the code. The web test covered only the wide layout.


view run · view recording

@MelvinBot

Copy link
Copy Markdown
Contributor

Regressions

I found one regression. It happens on narrow layout, when a report is already open in the RHP and you press "View". The PR hasn't changed since my earlier regressions comment, and I re-checked this finding against the current code.

"View" replaces the open RHP and skips the expense report. This only happens when the report has more than one expense.

  • Before: The old narrow path opened the thread as a full-screen r/<threadID> with forceReplace. linkTo sets REPLACE at linkTo/index.ts:222-224. Then :248-251 turns it back into a PUSH, because the target is a full-screen route above an RHP. The thread opened on top, and Back returned to the RHP you had open.
  • After: shouldOpenExpenseReport is false whenever forceReplace is true (navigateToCreatedExpense.ts:68). The thread opens as a SEARCH_REPORT RHP with REPLACE (:74). Nothing turns that back into a push.
  • Result: The expense report never opens underneath, so Back and delete land on whatever was below the replaced RHP. That is often a different report. The RHP you had open also drops out of history.
  • Example: You open another expense from a report preview while the growl is still showing, then press "View".
  • Fix: Open the expense report even when forceReplace is true, then stack the thread on it, the same way the wide branch does at :85-97. Add a narrow-layout forceReplace test. None exists today.

The main narrow path (no RHP open) and the wide path look correct. On those paths, Back and delete now land on the expense report instead of the chat. That change matches the report preview.

I found this by reading the code and did not test it in the app. The earlier web test covered only the wide layout.


view run

@mountiny mountiny changed the title fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl [CP Staging] fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl Oct 2, 2026
@mhawryluk

Copy link
Copy Markdown
Member Author

Review

1. The arrows step through expenses in the wrong order. The growl seeds openableTransactionIDs straight from useReportTransactions, which is Object.values of the transactions collection. That is creation order, not the order the report shows:

done, added sorting by getCreated, which is the value the report's default date sort uses.

2. Question: the Search and Home tabs still seed only the new expense. navigateToCreatedExpense.ts:58-61 still calls setActiveTransactionIDs([transactionID]). Pressing "View" outside the Inbox shows no arrows. Is that intended?

yes, I think that's intended

  • Line 67: iouReportID && is redundant, because hasMultipleReportTransactions is already false without it.

has to stay to satisfy typescript

  • Line 41: the "Don't reopen an expense…" comment now sits above the ID mapping. Move it down to the early-return check.

indeed, done

@mhawryluk

Copy link
Copy Markdown
Member Author

2. Minor: after a forced replace, reloading on mobile web can land on the Spend tab.

Fixed. When the replaced RHP has no backTo, the thread now falls back to r/<iouReportID>

@mhawryluk

mhawryluk commented Oct 2, 2026 •

Copy link
Copy Markdown
Member Author

1. A report is already open in the RHP: "View" replaces it and skips the expense report. For example, you open another expense from a report preview while the growl is still showing, then press "View".

I found one regression. It happens on narrow layout, when a report is already open in the RHP and you press "View".

I think it only broke when the RHP was showing something from a different report, like an expense from another report's preview or the expense report itself, and then you press "View". To be safe, "View" now closes the RHP in those cases, then opens the expense report with the thread on top, so Back and delete land on the expense report. If another expense report was open under the RHP, the new one replaces it rather than stacking on it, so Back goes from the expense, to its report, to the chat. When the expense report is already under the RHP, nothing changed.

@mhawryluk

Copy link
Copy Markdown
Member Author

@situchan I addressed the AI reviewer's comments, back to you. on top of the arrow navigation, could you also please test if the navigation works correctly when we have an expense opened already and we click "View"? cause we switched to opening the /search rhp instead of /r and it affected the behavior, so I had to introduce more changes for it

@MelvinBot

Copy link
Copy Markdown
Contributor

Regressions (re-review at ed5f791)

I found no blocking regressions. Your fixes address my earlier findings. One minor behavior change on narrow layout is worth a decision.

1. Minor: "View" now drops another expense report that is open full screen.

  • When: No RHP is open, the report has two or more expenses, and a different expense report is open full screen. For example, you open another expense report during the growl's 6 seconds, then press "View".
  • Before: The thread was pushed on top of that report, so Back returned to it.
  • After: openThreadOnExpenseReport replaces that report with the new one (navigateToCreatedExpense.ts:95-99). Back goes from the thread, to the new expense report, to whatever was under the old report. The old report is gone from history.
  • The single-expense path still pushes (:113-115), so Back behaves differently depending on the expense count.
  • Suggestion: If this isn't intended, replace only after closing an RHP (the case you were fixing), and push otherwise.

Nit: Line 86 calls getTopmostReportId() without a state argument, but line 95 passes navigationRef.getRootState(). Pass the root state in both places for consistency.

Checked and fine
  • Sort order: getCreated is the value the report list's default sort (date, oldest first) uses (ReportUtils.ts:14428-14429, useMoneyRequestReportSortedTransactions.ts:137-138). Grouped layouts still differ, as your code comment notes. The report preview path has the same limitation.
  • Main narrow path (no RHP open): The expense report is pushed, then the thread opens on top, as in the previous version.
  • RHP open over the same expense report: The thread replaces the RHP. backTo falls back to r/<iouReportID>, which fixes the reload-to-Spend issue.
  • RHP open over a different report: The RHP closes, then the expense report and thread open. Back and delete land on the expense report.
  • Wide layout: Only the sort changed.
  • getFocusedReportId(rootState): This only makes the early return more accurate.
  • Tests and CI: The new branches have unit tests. CI passes except the approval check.

I found these by reading the code. I did not test narrow layout in the app.


view run

@situchan

situchan commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Back goes from the thread, to the new expense report, to whatever was under the old report. The old report is gone from history.

So this is behavioral change on all growl deep open. Hopefully not bug or at least not blocker

@situchan

situchan commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web1.mov
web2.mov

@melvin-bot
melvin-bot Bot requested a review from mountiny October 2, 2026 15:21
@mhawryluk

Copy link
Copy Markdown
Member Author

Back goes from the thread, to the new expense report, to whatever was under the old report. The old report is gone from history.

So this is behavioral change on all growl deep open. Hopefully not bug or at least not blocker

yeah, I believe this is the expected behavior. since we're replacing an expense when opening a new one while one is open, instead of stacking

@Julesssss

Copy link
Copy Markdown
Contributor

@mountiny could you take a look at this potential fix please

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are a bit too verbose but it's resolving a blocker so moving forward.

@Julesssss Julesssss changed the title [CP Staging] fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl [HOLD][CP Staging] fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl Oct 2, 2026
@Julesssss Julesssss changed the title [HOLD][CP Staging] fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl [CP Staging] fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl Oct 2, 2026
@Julesssss

Copy link
Copy Markdown
Contributor

Okay going ahead, I'd prefer to revert the original PR but it's not clean and other fixes have already been CPd

@Julesssss
Julesssss merged commit 6a53868 into Expensify:main Oct 2, 2026
35 of 37 checks passed
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Oct 2, 2026
…-navigation

[CP Staging] fix: Expense - Arrow navigation is not automatically displayed when opening expense via growl

(cherry picked from commit 6a53868)

(cherry-picked to staging by Julesssss)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 2, 2026
@OSBotify OSBotify mentioned this pull request Oct 2, 2026
73 tasks done
@OSBotify

OSBotify commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@os-botify

os-botify Bot commented Oct 2, 2026

Copy link
Copy Markdown

🔁 Filed a Staging retest request for deploy blockers #102848 after this PR was cherry-picked to staging.

@OSBotify

OSBotify commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.5.1-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This bug fix makes the previous/next arrows appear when you open an expense from the "Expense added" message, which is what users already expect, and no article under docs/articles describes that message or those arrows.


view run

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #100015 was identified to be related to this PR.

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.1-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.5.2-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This is a bug fix: selecting View on the expense-added message now shows the previous/next arrows, as users already expect, and no help article describes this flow.


view run

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@IuliiaHerets

Copy link
Copy Markdown

Issue is not reproducible on Xiaomi Poco F5 / Android 13 in v9.5.5-0

1000232110.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants