[Due for payment 2026-10-12] Report opens with skeleton loader after clicking View on growl when invoice is deleted offline

@situchan

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.1-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100015
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

Enable Invoices.

Go to staging.new.expensify.com
Go offline.
Open FAB > Send invoice.
Send invoice to any user.
Right click on the invoice preview > Delete > Delete.
Click View on Invoice sent growl.

Expected Result:

Nothing will happen after clicking View on Invoice sent growl because invoice is deleted.

Actual Result:

Report opens with skeleton loading after clicking View on Invoice sent growl when invoice is deleted offline.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7274934_1790916892501.11.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7274934

Issue Owner

Current Issue Owner: @situchan

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/f14563c594c2b232cec788444ef14aa50b9d53e51120e8e18e8ae06c52f87511

You have been assigned to this deploy blocker because you recently merged this PR: #100015

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@mountiny

@mountiny @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100015

@mhawryluk

@mhawryluk you have been assigned to this deploy blocker because you authored the offending PR: #100015

💬 A slack conversation has been started in #expensify-open-source

Deploy Blocker Investigation

Causing PR: Confirm new expenses with a "View" toast instead of scrolling to and highlighting the row v2 (high confidence). It added the shared ExpenseAddedGrowl component that shows the "Invoice sent" growl.

Root cause: The growl's View handler never checks whether the transaction was deleted. When you delete offline, the transaction stays in Onyx with pendingAction: DELETE. View then rebuilds the soft-deleted transaction thread and opens it. With no report actions and no network, the thread shows a skeleton loader.

Recommendation: fix forward. In src/components/ExpenseAddedGrowl.tsx:131, return early at the top of navigateToExpense:

if (!transaction || isTransactionPendingDelete(transaction)) {
    setActive(null);
    return;
}

Add a unit test in tests/unit/ExpenseAddedGrowlTest.tsx. The test should give the growl a transaction with pendingAction: DELETE and check that View does not navigate or call setOptimisticTransactionThread.

Investigation details

SendInvoice.ts:879-881 queues the growl for the invoice's transactionID. The growl stays visible for 6 seconds.
Deleting offline uses deleteMoneyRequest. The transaction is only marked pendingAction: DELETE (DeleteMoneyRequest.ts:881-885). It is removed only after the server responds (L1050-L1054). The transaction thread is soft-deleted (L684-L702).
View reads transaction.transactionThreadReportID from the leftover transaction (ExpenseAddedGrowl.tsx:132-134) and calls setOptimisticTransactionThread. That call writes reportID and type back onto the deleted thread (Report/index.ts:8732-8750). Then L152 opens it.
Online, the server confirms the delete quickly and the transaction disappears, so the bug mainly shows offline.
Expenses and invoices share this component. Based on the code, an expense deleted offline while its growl is showing should hit the same bug. This was not reproduced.
No other growl has an action button, so there is no existing guard to copy. isTransactionPendingDelete (TransactionUtils/index.ts:1526) is the standard check.
Optional: clear active once its transaction is pending delete, so the growl hides itself. Do not just return null at render time. The effect at lines 98-100 skips new growls while active is set, so a stale active would block later growls.

Revert vs. fix forward: This bug alone is small and easy to fix. However, the same PR has five other open deploy blockers:

If they can't all be fixed quickly, revert the PR instead.

Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Not repro on Mac Chrome, iPhone 15 and Pixel 8a/Android 16, build 9.5.1-5

Retest.102850.mp4

Retest.102850.1.mp4

az_recorder_20261002_114956.mp4

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@situchan

@situchan

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.1-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] fix: Report opens with skeleton loader after clicking View on growl when invoice is deleted offline #102872

If no regressions arise, payment will be issued on 2026-10-12. 🎊

The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Navigation Menu

Repository navigation

[Due for payment 2026-10-12] Report opens with skeleton loader after clicking View on growl when invoice is deleted offline #102850

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Deploy Blocker Investigation

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2026-10-12] Report opens with skeleton loader after clicking View on growl when invoice is deleted offline #102850

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

applause-bot commented on Oct 2, 2026

melvin-bot commented on Oct 2, 2026

github-actions commented on Oct 2, 2026

melvin-bot commented on Oct 2, 2026

melvin-bot commented on Oct 2, 2026

melvin-bot commented on Oct 2, 2026

MelvinBot commented on Oct 2, 2026

Deploy Blocker Investigation

melvin-bot commented on Oct 2, 2026

m-natarajan commented on Oct 2, 2026

melvin-bot commented on Oct 4, 2026

melvin-bot commented on Oct 5, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions