Skip to content

[Due for payment 2026-10-12] Expense - Arrow navigation is not automatically displayed when opening expense via growl #102848

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.1-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100015
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has a workspace.

  1. Open the staging.new.expensify.com website.
  2. Navigate to workspace chat.
  3. Create a manual expense.
  4. Navigate to "Inbox"
  5. Create a new manual expense via FAB and submit it to the same report in workspace chat.
  6. Click on "View" in the displayed growl.
  7. Note that when expense is opened, no arrow navigation is visible on top.
  8. Click on the arrow on the top left corner to return to parent report.
  9. Reopen expense.
  10. Note that now, arrow navigation is visible.

Expected Result:

Arrow navigation should be automatically displayed when opening expense via growl, if report has more expenses in it.

Actual Result:

Arrow navigation is not displayed if second created expense is opened via growl. After closing and reopening expense, arrows appear.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7274929_1790916295992.View_16.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7274929

Issue OwnerCurrent Issue Owner: @situchan

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2026
  2. applause-bot commented on Oct 2, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/1622d2a913ecc613b54345d45ae4539c904060be3e22a7d81d9f13971dd8bd6d

  3. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #100015

  4. github-actions commented on Oct 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    @mountiny @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100015

  6. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    @mhawryluk you have been assigned to this deploy blocker because you authored the offending PR: #100015

  7. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Oct 2, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row v2 (high confidence, from code review; not reproduced).

    Root Cause: The growl's "View" handler seeds the prev/next carousel with only the new expense: setActiveTransactionIDs([transactionID]) at navigateToCreatedExpense.ts:58 and :79. The arrows need two or more IDs, so they don't show. On narrow layouts (Android), :64-66 opens the expense as a full report instead of SEARCH_REPORT, where arrows never render.

    Recommended Fix (fix forward, no revert): In navigateToCreatedExpense.ts:

    1. Build the sibling ID list from reportTransactions (already passed in), skipping pending-delete expenses, in display order. Pass it to setActiveTransactionIDs instead of [transactionID].
    2. On the narrow path with a multi-expense report, copy MoneyRequestReportPreview/index.tsx:286-293: open the expense report, set the siblings, then open the expense in SEARCH_REPORT.
    3. Extend tests/unit/navigateToCreatedExpenseTest.ts to check that the full list is passed.

    Blocker status: Suggest demoting. It's a new feature not in production, nothing breaks, and going back and reopening the expense is a workaround (steps 8–10).

    Investigation details
    • The header shows arrows only when the expense is open in SEARCH_REPORT: MoneyRequestHeader.tsx:101-103.
    • The full ID list is already available: reportTransactions is used only to count expenses at navigateToCreatedExpense.ts:42-44.
    • The expense report opened underneath (Inbox, wide layout, :71) doesn't fix the list. The hook that seeds it, useMoneyRequestReportActiveTransactionIDs.ts:22-24, returns early unless SEARCH_REPORT is focused.
    • Reopening works because tapping a row goes through useNavigateToTransactionThread, which sets the full sibling list before opening SEARCH_REPORT.
    • A revert is a poor trade: the PR touches about 70 files, is already a second attempt, and the rest of the "View" feature works.

    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  9. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. mhawryluk commented on Oct 2, 2026

    @mhawryluk
    Member

    I'm not sure if the arrow navigation has to be shown after clicking on View. I guess we could argue that growl's View just shows the newest created expense and it's not the same as clicking on the expense in the context of its report. I think we can implement it to be shown, but I would not consider this a deploy blocker necessarily

  11. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. self-assigned this
    on Oct 2, 2026
  14. m-natarajan commented on Oct 2, 2026

    @m-natarajan

    Not repro, Win / Chrome, v9.5.1-6

    Recording.3627.mp4
  15. jponikarchuk commented on Oct 4, 2026

    @jponikarchuk

    Deploy Blocker #100015 was identified to be related to the PR http://github.com/Expensify/App/pull/102854 that attempted to fix this issue.

  16. added and removed
    ReviewingHas a PR in review
    on Oct 5, 2026
  17. changed the title [-]Expense - Arrow navigation is not automatically displayed when opening expense via growl[/-] [+][Due for payment 2026-10-12] Expense - Arrow navigation is not automatically displayed when opening expense via growl[/+] on Oct 5, 2026
  18. melvin-bot commented on Oct 5, 2026

    @melvin-bot

    @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.1-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-12. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions