You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-12] Expense - Arrow navigation is not automatically displayed when opening expense via growl #102848
Version Number: 9.5.1-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#100015 Email or phone of affected tester (no customers):[email protected] Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has a workspace.
Open the staging.new.expensify.com website.
Navigate to workspace chat.
Create a manual expense.
Navigate to "Inbox"
Create a new manual expense via FAB and submit it to the same report in workspace chat.
Click on "View" in the displayed growl.
Note that when expense is opened, no arrow navigation is visible on top.
Click on the arrow on the top left corner to return to parent report.
Reopen expense.
Note that now, arrow navigation is visible.
Expected Result:
Arrow navigation should be automatically displayed when opening expense via growl, if report has more expenses in it.
Actual Result:
Arrow navigation is not displayed if second created expense is opened via growl. After closing and reopening expense, arrows appear.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause: The growl's "View" handler seeds the prev/next carousel with only the new expense: setActiveTransactionIDs([transactionID]) at navigateToCreatedExpense.ts:58 and :79. The arrows need two or more IDs, so they don't show. On narrow layouts (Android), :64-66 opens the expense as a full report instead of SEARCH_REPORT, where arrows never render.
Recommended Fix (fix forward, no revert): In navigateToCreatedExpense.ts:
Build the sibling ID list from reportTransactions (already passed in), skipping pending-delete expenses, in display order. Pass it to setActiveTransactionIDs instead of [transactionID].
On the narrow path with a multi-expense report, copy MoneyRequestReportPreview/index.tsx:286-293: open the expense report, set the siblings, then open the expense in SEARCH_REPORT.
Extend tests/unit/navigateToCreatedExpenseTest.ts to check that the full list is passed.
Blocker status: Suggest demoting. It's a new feature not in production, nothing breaks, and going back and reopening the expense is a workaround (steps 8–10).
I'm not sure if the arrow navigation has to be shown after clicking on View. I guess we could argue that growl's View just shows the newest created expense and it's not the same as clicking on the expense in the context of its report. I think we can implement it to be shown, but I would not consider this a deploy blocker necessarily
changed the title [-]Expense - Arrow navigation is not automatically displayed when opening expense via growl[/-][+][Due for payment 2026-10-12] Expense - Arrow navigation is not automatically displayed when opening expense via growl[/+]on Oct 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.1-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-12. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Oct 2, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1622d2a913ecc613b54345d45ae4539c904060be3e22a7d81d9f13971dd8bd6d
melvin-bot commentedon Oct 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #100015
github-actions commentedon Oct 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 2, 2026
@mountiny @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100015
melvin-bot commentedon Oct 2, 2026
@mhawryluk you have been assigned to this deploy blocker because you authored the offending PR: #100015
melvin-bot commentedon Oct 2, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 2, 2026
Deploy Blocker Analysis
Causing PR: Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row v2 (high confidence, from code review; not reproduced).
Root Cause: The growl's "View" handler seeds the prev/next carousel with only the new expense:
setActiveTransactionIDs([transactionID])at navigateToCreatedExpense.ts:58 and :79. The arrows need two or more IDs, so they don't show. On narrow layouts (Android), :64-66 opens the expense as a full report instead ofSEARCH_REPORT, where arrows never render.Recommended Fix (fix forward, no revert): In
navigateToCreatedExpense.ts:reportTransactions(already passed in), skipping pending-delete expenses, in display order. Pass it tosetActiveTransactionIDsinstead of[transactionID].SEARCH_REPORT.tests/unit/navigateToCreatedExpenseTest.tsto check that the full list is passed.Blocker status: Suggest demoting. It's a new feature not in production, nothing breaks, and going back and reopening the expense is a workaround (steps 8–10).
Investigation details
SEARCH_REPORT: MoneyRequestHeader.tsx:101-103.reportTransactionsis used only to count expenses at navigateToCreatedExpense.ts:42-44.SEARCH_REPORTis focused.useNavigateToTransactionThread, which sets the full sibling list before openingSEARCH_REPORT.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.view run
melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mhawryluk commentedon Oct 2, 2026
I'm not sure if the arrow navigation has to be shown after clicking on View. I guess we could argue that growl's View just shows the newest created expense and it's not the same as clicking on the expense in the context of its report. I think we can implement it to be shown, but I would not consider this a deploy blocker necessarily
melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
m-natarajan commentedon Oct 2, 2026
Not repro, Win / Chrome, v9.5.1-6
Recording.3627.mp4
jponikarchuk commentedon Oct 4, 2026
Deploy Blocker #100015 was identified to be related to the PR http://github.com/Expensify/App/pull/102854 that attempted to fix this issue.
[-]Expense - Arrow navigation is not automatically displayed when opening expense via growl[/-][+][Due for payment 2026-10-12] Expense - Arrow navigation is not automatically displayed when opening expense via growl[/+]melvin-bot commentedon Oct 5, 2026
@situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.1-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-12. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]