Repository navigation
Conversation
✅ CI passed ·
|
| Check | Result |
|---|---|
| Build + DOL SHA-1 | ✅ |
No regressions (report_delta --check) |
✅ |
| Linked units still link | ✅ |
| Metric | Base | PR | Δ |
|---|---|---|---|
| Matched data (bytes) | 1,758,510 | 1,758,510 | 0 |
| Complete data (bytes) | 1,758,510 | 1,758,510 | 0 |
| Matched code (bytes) | 4,353,092 | 4,353,092 | 0 |
| Complete code (bytes) | 4,353,092 | 4,353,092 | 0 |
| Matched functions | 27,572 | 27,572 | 0 |
| Linked units | 2,449 | 2,449 | 0 |
0 new exact functions, 0 function regressions, 0 renamed functions.
e8b2284 to
1d7a9bb
Compare
|
I'd be overall ok having this. Couple things: Would you maintain this, or have plans to automate parts? Changes to CI needed? @humarpso hope for your input. thanks |
|
Yeah they're mostly the same and the European one is based on the US one with a mapping between them (for almost all functions). I'm happy to look after it. I can make a PR after this to build both versions in CI |
|
apparently there is no plus version for PAL? This decomp is about plus version. |
|
closing. no plus version exists for pal. not in scope. |
|
@Elias843 btw sorry for closing this so quick. we can potentially put this in scope later. but perhaps too soon? |
|
No worries, yeah it may be a bit too soon now I agree. I think it'll be easier once we've fully matched (and linked?) the US DOL first. Anyways, I'll keep doing the work locally until we're ready. I'll change this to a draft PR for now Also was thinking jp plus would be nice to have here as well, yeah 😄 |
Summary
Adds the European release, Phantasy Star Online Episode I & II (
GPOP8P), as a second version of the build, anddecompiles the code where it differs from the USA version. Every European difference is behind
#if VERSION == VERSION_GPOP8P(include/versions.h); the USA build is unchanged.python configure.py --version GPOP8P && ninja: EuropeanPsoV3.dolOK, 100% code matched, every unitlinked (2,450), data 100%. The European config leaves out two USA-only units that have no bytes there
(NetworkInfoRequests, text_8036F764).
python configure.py && python tools/check_pr.py: PASS on every commit, no USA changes in the report.Commits
configure.py --version,VERSIONdefine,link_units.py/localize_split_globals.py/report_delta.py/orig_asm.pytake the version,check_pr.pyrefuses a non-USA configure.config/GPOP8P/psov3/: symbols, splits and config at the European addresses; links every unit whose codeis already the same in both versions (2,309).
decompressors, ntInf network configuration, modem check, disc error messages, protocol and lobby, quests and
challenges, character select and save files, title and menus, in-game windows, game objects). Each links the
units it completes.
From the second commit on, each commit builds both DOLs OK (the first adds no European config yet).
Shared code
A few USA lines change without changing the USA objects: state numbers and table sizes go through macros
(
CHR_SEL_A_STATE(n)etc.,(n)in the USA build) where the European version drops states, a few constants arenamed, and two files have a second part included under a define (
TEXT_803F3BF8_SECOND_FILE,TKEYBOARDCONTROL_SECOND_FILE) because the European disc builds those parts as their own files.