Skip to content

Match __ct__14TObjEnePanBARAFP7TObjectPvl — byte-exact, TObjEnePanarms fns 72/72 - #250

Merged
zeroz41 merged 1 commit into
zeroz41:masterfrom
scottlowry:match-tobjenepanarms-ct
Nov 12, 2026
Merged

zeroz41 merged 1 commit into
zeroz41:masterfrom
scottlowry:match-tobjenepanarms-ct

Conversation

@scottlowry

Copy link
Copy Markdown
Collaborator

Match __ct__14TObjEnePanBARAFP7TObjectPvl (0x800E252C) — byte-exact 100.0, completes TObjEnePanarms functions 72/72

The constructor's last mismatch was one instruction of provenance, not logic: the member call passed (s32)&objectState, which made MWCC home the stack address in a callee-saved register (+1 insn, 0x3cc) and renumbered the r28/r29 arg homes. The fix adopts the house spelling already matched in the corpus — extern-C twin declaration s32 exchange_object_state__9TObjEnemyFls(void*, void*, int) (TBoss7Crawfish/TBoss6Type2 precedent) with a direct &local pass — so the era shape reproduces: addi r4,r1,0x8 rematerializes twice at the call sites, era-exact.

Proof chain (all at the true-merge commit on current master 5312217d):

  • one_shot paired meter: match=100.0, size 968/968, rows orig 242 / ours 242 (symbols.txt row gate size:0x3C8; gnm -S OURS 0000295c 000003c8 T — int-parse gate-exact)
  • Unit psov3/pso/enemy/panarms/TObjEnePanarms: functions 72/72, matched_data 100.0, matched_code 100.0 (was 71/72; this seat was the last open function)
  • Package is +3/−2 in src/pso/enemy/panarms/TObjEnePanarms.cpp only; config untouched

Verification battery (integrator, replayed in a full checkout): ninja rc=0; report_delta.py --check before=5312217d tip report → New exact functions: 1, regressions: 0 (matched_functions 27500→27501); check_pr.py PASS (linked now 2793, regressed 0, skipped 0); link_units.py check OK (2793 all exact); psov3.dol sha1 0d85744b51d7379efb025a943d0cd5aaae2191a3 — byte-identical to orig/GPOE8P/files/PsoV3.dol (unit is unlinked, DOL-inert as expected); sibling audit: zero size drift, whole-unit re-score stable. Collision screen: no open PR touches the owner file (#237's panarms references are GPOP8P config only).

Intentionally out of scope: now that the unit is function-complete + data-paired, a linked_units.txt row is the natural follow-up — but TObjEnePanarms.cpp sits first in linked_units_blocked.json (missing __sinit_TObjEnePanarms_cpp emitter, missing named data globals like TObjEnePanarms__sound_ids / panarms_particle_frame_window, plus a section-order note), so that config package needs its own measure-then-link probe and is deliberately not bundled here.

Drafted by Scott's Hermes agent (AI-assisted lane; Scott reviews)

Twin-transcribe of the matched TObjEnemy::exchange_object_state spelling
(TBoss7Crawfish/TBoss6Type2 precedent: extern-C decl + direct &local pass):
the member call with (s32)&local cast made MWCC home the stack address into
a callee-saved reg (+1 insn, 0x3cc, arg-reg renumber cascade). Direct pass
rematerializes addi r4,r1,0x8 twice; era-exact 242/242 paired 100.0.
@github-actions

Copy link
Copy Markdown

✅ CI passed · 0817ef352d · run

Check Result
Build + DOL SHA-1 ✅
No regressions (report_delta --check) ✅
Linked units still link ✅
Metric Base PR Δ
Matched data (bytes) 1,610,341 1,610,341 0
Complete data (bytes) 1,516,877 1,516,877 0
Matched code (bytes) 4,277,904 4,278,872 +968
Complete code (bytes) 3,959,856 3,959,856 0
Matched functions 27,500 27,501 +1
Linked units 2,793 2,793 0

1 new exact functions, 0 function regressions, 0 renamed functions.

@zeroz41
zeroz41 merged commit c1d7a52 into zeroz41:master Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants