Repository navigation
Match __ct__14TObjEnePanBARAFP7TObjectPvl — byte-exact, TObjEnePanarms fns 72/72 - #250
Merged
Merged
Conversation
Twin-transcribe of the matched TObjEnemy::exchange_object_state spelling (TBoss7Crawfish/TBoss6Type2 precedent: extern-C decl + direct &local pass): the member call with (s32)&local cast made MWCC home the stack address into a callee-saved reg (+1 insn, 0x3cc, arg-reg renumber cascade). Direct pass rematerializes addi r4,r1,0x8 twice; era-exact 242/242 paired 100.0.
✅ CI passed ·
|
| Check | Result |
|---|---|
| Build + DOL SHA-1 | ✅ |
No regressions (report_delta --check) |
✅ |
| Linked units still link | ✅ |
| Metric | Base | PR | Δ |
|---|---|---|---|
| Matched data (bytes) | 1,610,341 | 1,610,341 | 0 |
| Complete data (bytes) | 1,516,877 | 1,516,877 | 0 |
| Matched code (bytes) | 4,277,904 | 4,278,872 | +968 |
| Complete code (bytes) | 3,959,856 | 3,959,856 | 0 |
| Matched functions | 27,500 | 27,501 | +1 |
| Linked units | 2,793 | 2,793 | 0 |
1 new exact functions, 0 function regressions, 0 renamed functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match
__ct__14TObjEnePanBARAFP7TObjectPvl(0x800E252C) — byte-exact 100.0, completesTObjEnePanarmsfunctions 72/72The constructor's last mismatch was one instruction of provenance, not logic: the member call passed
(s32)&objectState, which made MWCC home the stack address in a callee-saved register (+1 insn, 0x3cc) and renumbered the r28/r29 arg homes. The fix adopts the house spelling already matched in the corpus — extern-Ctwin declarations32 exchange_object_state__9TObjEnemyFls(void*, void*, int)(TBoss7Crawfish/TBoss6Type2 precedent) with a direct&localpass — so the era shape reproduces:addi r4,r1,0x8rematerializes twice at the call sites, era-exact.Proof chain (all at the true-merge commit on current master
5312217d):one_shotpaired meter:match=100.0, size 968/968, rows orig 242 / ours 242 (symbols.txt row gatesize:0x3C8;gnm -SOURS0000295c 000003c8 T— int-parse gate-exact)psov3/pso/enemy/panarms/TObjEnePanarms: functions 72/72, matched_data 100.0, matched_code 100.0 (was 71/72; this seat was the last open function)src/pso/enemy/panarms/TObjEnePanarms.cpponly; config untouchedVerification battery (integrator, replayed in a full checkout):
ninjarc=0;report_delta.py --checkbefore=5312217dtip report → New exact functions: 1, regressions: 0 (matched_functions 27500→27501);check_pr.pyPASS (linked now 2793, regressed 0, skipped 0);link_units.py checkOK (2793 all exact);psov3.dolsha10d85744b51d7379efb025a943d0cd5aaae2191a3— byte-identical toorig/GPOE8P/files/PsoV3.dol(unit is unlinked, DOL-inert as expected); sibling audit: zero size drift, whole-unit re-score stable. Collision screen: no open PR touches the owner file (#237's panarms references are GPOP8P config only).Intentionally out of scope: now that the unit is function-complete + data-paired, a
linked_units.txtrow is the natural follow-up — butTObjEnePanarms.cppsits first inlinked_units_blocked.json(missing__sinit_TObjEnePanarms_cppemitter, missing named data globals likeTObjEnePanarms__sound_ids/panarms_particle_frame_window, plus a section-order note), so that config package needs its own measure-then-link probe and is deliberately not bundled here.Drafted by Scott's Hermes agent (AI-assisted lane; Scott reviews)