Repository navigation
Name 10 evidence-backed network/PPP + rope/box/gifoie symbols (A3 pack v2) - #288
Merged
Merged
Conversation
…lpers Pack V2 (re-anchored post-zeroz41#286/zeroz41#287 world @98a7485a5): 8 symbols rows / 10 names / 16 seds. netbuf_copy_by_ref, ppp_output_frame, ipcp_merge_config_options, reassemble_fragment_packet, resolve_collisions, box_edge_order_table, gifoie_pad_step, gifoie_angle_scale + frag_pool_take_entry, frag_chain_contig_check. GO-day STEP-0 battery re-run at 98a7485 (same harness as certification, constants flipped): residue 0 full-tree, idempotent, reverse 18/18 byte-exact, occurrence law 49/7/5/5/4/3/3/2/1/1 x10 identical, new-name collisions 0, lint all-pass, line-count delta 0, live-vs-certified applied world byte-identical 18/18. Row lbl_8047E558 carries the upstream-resolved retype (size:0x14 scope:local). Renaming wave-7 companion row (lbl_804FD3A8) dropped: named upstream ppp_fcs16_table. Names from era evidence: caller tags, section band anchors, and build-graph obj gate receipts per symbol; no semantic claims beyond the evidence tiers in the body.
✅ CI passed ·
|
| Check | Result |
|---|---|
| Build + DOL SHA-1 | ✅ |
No regressions (report_delta --check) |
✅ |
| Linked units still link | ✅ |
| Metric | Base | PR | Δ |
|---|---|---|---|
| Matched data (bytes) | 1,700,891 | 1,700,891 | 0 |
| Complete data (bytes) | 1,676,175 | 1,676,175 | 0 |
| Matched code (bytes) | 4,298,020 | 4,298,020 | 0 |
| Complete code (bytes) | 4,162,592 | 4,162,592 | 0 |
| Matched functions | 27,525 | 27,525 | 0 |
| Linked units | 2,662 | 2,662 | 0 |
0 new exact functions, 0 function regressions, 5 renamed functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A3 naming pack, v2: 10 evidence-backed names / 8 symbols rows
Title: Name 10 evidence-backed network/PPP + rope/box/gifoie symbols (w14 banked pack A3, re-anchored post-#286/#287)
Network-band symbols-only renames (#223–#228 pattern: symbols row + matching extern/usage renames) — the class GATE law applies: provenances are symbols.txt-only and byte-neutral; historically merged without the exacts bar (#214–#223 pattern; #67 review-era precedent: 117 same-address pairs merged as data claims).
Survivor re-check (this wave, @1542ec2fe0a1 — the real numbers): 8/8 kept symbols rows survive #286: SEVEN byte-identical at identical line numbers (6049/27421/27507/27517/27762/32750/32751 vs pack-era blob
08209e1a→ new blob1aa710be, 59,886 lines), anchors^old =unique ×8/8, zero prefix-extensions in symbols.txt AND zero extended-identifier occurrences tree-wide (raw-vs-word census). The box-edge row survives RETYPED (40401→40410,size:0x18→size:0x14+scope:local) — see row-9 note. Old-token occurrence law re-derived from scratch at the new blob (no carryover): 49/7/5/5/4/3/3/2/1/1 over an 18-file live universe,git grep -cwnew-name tree collisions 0/10. Row 5's header site unchanged since FIX-1:PppIpcp.c3 +PppIpcp.h1 +TLobby_803FCF44.h0 (dead path kept as a no-op third arg in the sed line).Row 7 dropped — datum named upstream (celebrate): the CRC-16 FCS table
lbl_804FD3A8— this pack's proposedppp_fcs_crc16_table— was named by #286 asppp_fcs16_table(symbols.txt:45904,@.data:0x804FD3A8; // type:object size:0x200; extern + both table-step use sites inTLobby_804050DC.cL35/467/991 renamed with it; old token = 0 occurrences tree-wide). All four sites the row covered are now named upstream; the maintainer's spelling stands and the row's sed pair is deleted (it had become a silent no-op). Rework probe found no still-unclaimed successor datum (crc32_table,sound_bank_file_crc16already named; size-0x200.datasiblings lack any CRC algebra) — 8 symbols rows is final.Row 8 carrier re-pathed: #286's TU fold deleted
src/pso/unk/text_800FF580.cpp; the function survives verbatim with name and 3 sites insrc/pso/object/TObjHMS_EZRope_Player_800FEFCC.cpp(proto L291, def L299, call L384; still a free fn over placeholderObj_800FF788 *self). The sed file-list re-points there (method-form conversion stays with a future seat PR, unchanged exclusion).Row 9 kept, quirk resolved upstream: v1 disclosed a 24B-row vs 20B-struct mismatch on
lbl_8047E558(EdgeOrder_803E112C { s32 v[5]; }); #286 resolved it maintainer-side — row retypedsize:0x14+scope:local, and the datum materialized in-file asstatic const EdgeOrder_803E112C lbl_8047E558 = {{0, 1, 2, 3, 0}};. Rename remains safe and mechanical: anchor unique, owner unit unlinked at tip, and it completes the same named quartet (box_face_corner_index_table40407 /box_face_vertex_index_table40408 /box_edge_adjacent_face_table40409 / ours 40410).Evidence (old → new — one-line executable proof): per-row chains, every anchor re-greppable at the target tip (protocol-constant pins
tag == 0xc021+ 0x7e/0x7d/0x20 ACFC algebra, IPCP option algebracase 1/2/3/0x81/0x83RFC1332+RFC1877,sizeof(NetBufferPoolEntry)==0x3Cstatic assert, box-edge family quartet, gifoie era.double 0.015/.double 10430.38043493439): doc comment ×1,0xc021×1,case 0x81×2,0x3Cassert ×1, EdgeOrder ×3,.rodata 0x8044D2A0–0x8044D368band intact with both doubles verbatim andlbl_display labels (display-only, rename-inert).Ready-to-apply sed set (16 commands, content-anchored, order-free; macOS
sed -i ''; repo root = tree at ≥1542ec2fe0a1):Collision posture NOW (post-#286 merge, open set = #237 only):
2026-11-14T15:30:16Z(as440d7449) — its 1-siteSocketProtocolRuntime.c:400row-6 same-line surface is CONSUMED; the pack applies clean to the merged blob (v1's order-risk disclosure retired with cite).98a7485a5— the wave this re-anchor exists for; it named one of our 11 datums (row 7 — dropped above, celebrated), re-pathed another (row 8), retyped a third (row 9 — kept), and moved ZERO sites of the remaining ten tokens (per-file census digit-equal to pack-era, incl. all 13 row-6 carriers).1d7a9bbfunchanged): GPOP8P EU build, 13 files, zero hunks underconfig/GPOE8P/**, zero intersect with the pack's file universe (path-disjoint by construction: EUconfig/**vs packsrc/pso/**+include/pso/**+ one GPOE8P symbols row-file — verified against the local object, diff --name-only). Its EU snapshot carries era names at its own addresses ⇒ semantic cross-version drift only, no git collision.5ab04084, still applies): 0 pack tokens in its diff (sole fileBoss7DeRolLeCBehavior.cppdisjoint — and its 286 successor wave likewise renames none of our ten). Meter lesson cited verbatim from its landed body: "the report's global meter already counted these rows as demo-matched; the seat-strict row diff is where 99.9x → 100.0 shows" — this PR claims neither: it is a pure rename, byte-neutral by construction, every meter expected frozen.Verification plan (naming-class gate, full battery per naming-wave law §5): apply the 16-sed set verbatim →
git grep -cwzero-residue on all TEN old tokens across src+include+config →configure.py -v GPOE8P && ninjarc=0 → DOL shasum byte-identical to canonical master at the same base (names never enter bytes; the merge-day B1 measurement confirms canonical alive at1542ec2f; any linked carrier is rename-inert) →report_delta --checkvs fresh base snapshot: 0 regressions / 0 new-exact / 0 total moves →check_pr.pyPASS →link_unitsunchanged (pack touches it zero) →pr_gate.py origin/master.Byte-neutral exhibit (dress-run, not promise): the FULL 16-sed set was rehearsed at
98a7485a5on COPIES only (git-archive checkout to scratch, no tree/config write, zero builds): zero-residue post-apply across all 10 old tokens full-tree occurrence scan; re-run byte-exact (idempotent); reverse-apply restores all 18 changed files byte-identical (md5; the no-op header never touched); symbols-file diff = exactly 8 lines, each^name = .sec:0xADDR; // attrsformat-OK with post-name tail byte-identical to base and no line insert/delete (59,886→59,886); per-token occurrence totals preserved old→new49/7/5/5/4/3/3/2/1/1(\b-counted); zkit USE-edges on all 8 renamed addresses consistent with the git census modulo two disclosed stale-report artifacts (#286 fold, header move) — mentioned-in truncation (DEFECT-4) cross-verified by git-grep before use. Full rehearsal evidence re-run at this tip — see GO-day battery below.Exclusions (disciplined drops): row 7
lbl_804FD3A8(NAMED UPSTREAM by #286 — full disclosure above);lbl_8044D350(2^52 CodeWarrior f64 cast magic — compiler-synthesized, not game data); method-form conversion forresolve_collisionsstays with a future seat PR; StarLight pool claim (evidence-missing, dropped by the pack); CityDoors/w54-region rows are NOT here — superseded at master (cites:84a09e5b,907bfd84).Authorship law: one author/attribution line, exactly once, as the LAST non-empty line of the filed body, added at filing time.
[authorship line — exactly once, as LAST non-empty line, at filing time]
GO-day battery, re-run at
98a7485a5by the certifying harness (same script, constants flipped; 2026-11-16): per-row anchors all present at lines 6049/27421/27507/27517/27762/40410/32750/32751; occurrence law49/7/5/5/4/3/3/2/1/1×10 identical to certification; new-name collisions 0/10 (andppp_fcs16_tableuntouched at its 4 upstream sites); residue 0 full-tree; idempotent; reverse-apply 18/18 byte-exact; lint all-pass, linecount Δ0 (59,886→59,886); applied branch byte-identical to the certified copy-world 18/18. symbols blob itself frozen between certification and this PR (1aa710be77). DOL/CI as usual for the renaming-wave class: renames are display-layer,report_delta --check0 regressions by address-keyed pairing, DOL byte-identical (also re-verified on this push's build before opening).