Repository navigation
Name 8 TQuestVmDownLoadServer download-text band functions on single landed carrier and quest cross-TU caller evidence - #313
Merged
zeroz41 merged 1 commit intoNov 18, 2026
Conversation
…landed carrier and quest cross-TU caller evidence Replay of landed-local f6 payload 6b90b6f1b (battery-green per its commit body; config.yml zero-write — no force_active rider for this pack; KEEP seat 0x803EE580 byte-kept, strike-lineage leg per its family history; interlock screened STEP-0 against the LIVE open set).
✅ CI passed ·
|
| Check | Result |
|---|---|
| Build + DOL SHA-1 | ✅ |
No regressions (report_delta --check) |
✅ |
| Linked units still link | ✅ |
| Metric | Base | PR | Δ |
|---|---|---|---|
| Matched data (bytes) | 1,729,805 | 1,729,805 | 0 |
| Complete data (bytes) | 1,729,353 | 1,729,353 | 0 |
| Matched code (bytes) | 4,344,964 | 4,344,964 | 0 |
| Complete code (bytes) | 4,332,364 | 4,332,364 | 0 |
| Matched functions | 27,566 | 27,566 | 0 |
| Linked units | 2,564 | 2,564 | 0 |
0 new exact functions, 0 function regressions, 8 renamed functions.
Owner
|
looks fine. @humarpso did you want to take a look first? you were working on semantic matching with newserv related to this |
Collaborator
|
Good to me too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composed + battery-verified at ship time @
cad0f459b(survivor re-checks populated inline; open-set screened programmatically incl. #312).Title: Name 8 TQuestVmDownLoadServer download-text band functions on single landed carrier and quest cross-TU caller evidence
Config disclosure (zero-rider pack): this diff carries NO line of
config/GPOE8P/psov3/config.yml—the f6 apply proved it: "riders NONE" (
6b90b6f1bcommit body; harvest §5: all 9 OLD tokens — 8 seats +KEEP — vs
config.yml,splits.txt,linked_units.txt,linked_units_blocked.json→ zero occurrences;force_active contains no OLD token of this pack). Re-verified by this kit's card at
9925c2c50: 0/9old-token hits in config.yml (per-token
-cwFloop, KEEP seat included) and force_active block membershipre-derived 17,821 entries unchanged.
Pure rename PR: 8 placeholder rows in
config/GPOE8P/psov3/symbols.txt(contiguous band :27079–:27087;:27082 is the byte-KEPT declined seat) + every declaring/calling site — closed 5-file set, expected diffstat
60 insertions / 60 deletions (filter: diffstat summary, physical lines), line-count neutral, zero bytes of
codegen change (conservation: 60 token occurrences @
9925c2c50= 60 union physical lines, double-token lines0 — harvest §6 law, whole-tree
git grep -oEcensus re-run by this kit's card: 60 occurrences across exactly5 tracked files; per-file split symbols.txt 8 ·
include/pso/quest/TQuestVmDownLoadServer_803E6970.h10 ·src/pso/quest/TQuestVmDownLoadServer_803E5668.cpp30 ·_803E6970.cpp2 ·_803EB0D8.cpp10). RenamedRenamed functions: 8; all eight measures +0, regressions 0 / DOL byte-identical / all measures +0 / DOL byte-identical pre==post==era-pin
0d85744b51d7379efb025a943d0cd5aaae2191a3, measured at ship.This is the pack#11 quest download-text band on the single LANDED carrier
src/pso/quest/TQuestVmDownLoadServer_803EB0D8.cpp— the semantic entry→SJIS text-rendering cluster sittingbetween landed
find_keyword_entryandformat_number_text: the romaji→kana converter, the entry-textaccumulator reset, the range processor, the entry renderer, the build-all/convert-all pair, the per-slot node
chain free and the all-modes number formatter, with cross-TU call sites through
TQuestVmDownLoadServer_803E5668.cpp(quest-download request handlers 0x16–0x25,handle_list_scroll,convert_jis_to_sjis_string),TQuestVmDownLoadServer_803E6970.cpp(reset/init flows :82/:209) and decls ininclude/pso/quest/TQuestVmDownLoadServer_803E6970.h. Band pick = maximal 0x0-gap run 0x803EDF64–0x803EEB10,9 seats, 42 external hits — densest in the unit (harvest §3). Declined seats: 1 —
0x803EE580, KEEP-disclosedbelow; every other seat earned a name (HIGH 4 / MED 4, filter: harvest §4 conf column).
Seats (old → new — class-(i) evidence per seat; tiers per harvest ledger
ca03ddc67:fleet/w22_questvm68.md§4):convert_romaji_to_kanareset_entry_text_accumulatorprocess_entry_text_rangeget_entry_textconvert_all_entry_textfree_slot_node_chainbuild_all_entry_textformat_number_text_all_modesAll 8 renamed seats are 100.0-fuzzy at addr+size+name key in the post-apply report at the f6 battery
(carrier unit
psov3/pso/quest/TQuestVmDownLoadServer_803EB0D8unchanged, 99 fn rows; 8/8 PAIR-OK name-onlyvia DEC/HEX INT field-compare; 91/91 non-renamed rows byte-identical incl. KEEP) — re-census at execution tip
cad0f459bDONE: keys 8/8 exactly-1-old, NEW 8/8 zero-claims, pair-tails 8/8.Meter quote (f6 receipt,
6b90b6f1bcommit body + harvest §6 battery table, transcribed — not this card'sclaims): "DOL byte-identical, report_delta all +0 / Renamed 8, check_pr OK, riders NONE. 60+/60-/5 files.";
report_delta rc=0
--checkmatched_functions 27560→27560 (+0),total_functions 27572→27572 (+0), "Newexact functions: 0; regressions: 0", "Renamed functions: 8";
tools/check_pr.py --no-buildrc=0 PASS "link_units check: OK (2559 linked units all exact)" add 0/drop 0/skipped 0; one_shot skill-home ×8 — pre 8/8 rc=0
ORIG/OURS @100.0 sizes 896/16/652/272/72/196/276/200, post 8/8 same rows under NEW names, identical sizes +
identical instruction-row counts 224/4/163/68/18/49/69/50; apply residue OLD-token tree hits 0;
ninjarc=0(slots 2/3). GO-day re-derives live: report_delta
Renamed functions: 8all +0 regressions 0; check_pr PASS — link_units OK, 2,564 linked units all exact, add/drop/skip 0.Evidence class (per-seat cites, harvest §4 — four strongest, verbatim):
convert_romaji_to_kana— doc-verbatim class: "carrier .s.fn:3707–:3962 (224 rows paired@100.0); leading comment cpp:2087–2089 "Converts the romaji at src … to kana in out; *count gets …"; body
reads
romaji_kana_rows, calls landedfind_keyword_entry,map_key_to_code; callerTQuestVmDownLoadServer_803E5668.cpp:611feeds result to landedjis_to_sjis".free_slot_node_chain— doc-verbatim class: "carrier comment cpp:2398–2399 literally "Drops thenode chain of a slot; in mode 1 the nodes before the current position are first returned to the download
entry pool"; body calls landed
push_download_entry,detach_node_chain,free_node_list".format_number_text_all_modes— landed-stem class: "body wraps landedformat_number_text__22TQuestVmDownLoadServerFiiPvifor current modelbl_805D78FC+ the other three into*out3, guardquest_download_file_handle == -1 → -3; internal caller cpp:691 with&count; stemtransferred verbatim from the LANDED callee name".
get_entry_text— caller-density class: "body renders entry range intolbl_805A0340vialanded-shape
sub_803EB420loop then SJIS-converts and returns buffer; 20 cross-TUstrcpycall sitesin
E5668.cpp(:194/:195/:215/:216/:243/:244/:264/:265/:285/:286/:458/:470/:471/:509/:510/:549/:550/:580/:581) all fed
(quest_text_cursor_pos, quest_text_entry_len)".KEEP-seat disclosure (incl. family history):
0x803EE580(TQuestVmDownLoadServer__sub_803EE580, size0x198, symbols :27082) is DECLINED — verbatim harvest §4 seat 4: "0 external references (declarator line
only); both dispatch callees
sub_803EEDC0/sub_803EF958are themselves unnamed placeholders so a namewould chain guesses (constant-stub class spirit, pack#10B precedent)". Family-history note: this seat is one
of the pre-#291 strike-park legs marked "permanently SUPERSEDED" in the matching-campaign inventory (harvest
§2, quoted from the w22-14 brief, NOT re-derived here); the supersession is matching-campaign specific and
NAMING-ORTHOGONAL at this world — triage showed 68/68 rows fuzzy-paired 100.0, zero sub-100, so the
out-of-scope inventory is empty and the other two ex-strike legs (seats 1, 3) were named from their own
bodies/comments per that card's adjudication.
sub_803EE580was nonetheless KEPT on its own zero-ext-refdatum; its name, token, decls and symbols row ride this PR byte-exact (2 internal call sites carrier
:2244/:2253 untouched; battery: 91/91 non-renamed rows byte-identical incl. KEEP; symbols row re-derived
byte-present in BOTH master and payload blobs by this kit's card).
sub_803EC71C(parked color-wall leg) isnot renamed nor semantically characterized — cited only from seat 6's call site.
Collision posture at filing: 8/8 OLD rows exactly-1 by addr+size key at
9925c2c50AND 8/8 NEW tokens 0whole-tree hits + 0/9 config.yml rider hits (all re-measured by this kit's card, clean-token census with
loop-liveness positive control
free_node_list10 HIT) — both passes re-run at execution tip: PASS-A whole-token zero-hits 8/8 across the LIVE six-PR open set (incl. our own #312 — new-token-added-hits=[] every PR) + PASS-B clean; loop-liveness control unchanged. Full live open-set screen (review directive w22, commandnot list): {#237, #302, #303, #306, #307, #308, #309} measured 2026-11-17 by this card; per-PR
gh pr diff --name-only | grep -c 'pso/quest/'= 0 for all seven (quest/ region expected untouched —PROVEN mechanically per PR; any FUTURE quest-touching PR keys the re-screen via the live
gh pr listloop,never a hardcoded set); shared-old-tokens
comm= [] and added-new-token hits = 0/8 for EVERY open PR;symbols hunks of #302–#308 are net-0 row-count rename swaps and BAND-INTERSECTING HUNKS = 0 for all seven
open PRs (range math vs :27076–:27090, THIS card: nearest starts above band #307 :27360, #302 :27469, #303
:27524, #306 :27594, #308 :50906; #308's sub-band hunks end below :27076); #237
pal-buildis a stale-base wholesale symbols add (+59,730/−0 diff-side, zeroquest files, zero shared tokens ⇒ no name surface, positional cites only expire — keys are whole lines);
#309 touches
TObjPlayer_803DF7A8.cpp+linked_units.txtonly —linked_units.txtis cited here ONLY as awhole file, never by line number. PASS-B containment per harvest §5: 6 candidates ×1 discloser each, all
generic-word PR artifacts; non-equal containment cannot fire under whole-word semantics ⇒ zero ripple class.
Target verification is by addr+size key (exact
token = .text:0xADDR; // type:function size:0xSZrowmatch) — 8/8 rows byte-exact @
9925c2c50re-derived twice incl. after a simulated master-move and asimulated already-renamed seat in the kit's scratch clone;
:27079–:27087cites are informational and expireon any symbols insert.
Sibling-kit note: kit#10 (
pack#10/10B, player-band names) is being authored concurrently oncard-w22kit10-f5; registry folds +naming_tokens_v4are that lane's duty, NOT this pack's. Count grammarstamped: effective registry tokens currently 135 (filter: non-comment non-blank lines of ops mirror
fleet/naming_tokens_v3.txt; same file 195 physical / 194 non-blank lines) + 5 pack#10B + 8 pack#11 (thispack) pending f5's v4.1 fold. This sheet's STEP-0 prints the live applied-local kit listing from the ops
shipwindowdir READ and HALTS if anypack11-8.*appears there from another branch (double-composeguard; authoring census: absent — clean).
Builder notes honoured (harvest §6/§7): rename TOKENS only — the loose duplicate
extern "C"decl blocks inTQuestVmDownLoadServer_803E6970.h(:66–67/:148–149) ride along, NOT "fixed" here; local misdeclared callerforwards in
E5668.cpp(get_entry_texttyped(void*,void*)at :31-class decls) ride token-only —decl-shape seals NOT touched;
def-shapeseals respected (sub_803EC71Cuntouched); callers keep looserlocal prototypes — no arity or prototype fixes ride a rename PR. Held remainder: 59 out-of-band placeholder
seats stay held (next-densest run 0x803F0268–0x803F0AB8 ×8, ext 28). Renames pay zero charged rows (names
never enter bytes; the DOL check is the proof). No inline-literal conversions, no
linked_units.txtchange,no
config.ymlchange of any kind — zero-rider by construction. Style: quest-domain vocabulary transfersfrom landed siblings (
format_number_textstem verbatim);TQuestVmDownLoadServer__sub_placeholder prefixdropped per pack#1/#5/#6/#7/#9 precedent; MED seats have operation proven, semantics left numeric at inferred
edges.
Evidence of record (blob-sha cites): harvest
ca03ddc67:fleet/w22_questvm68.md§2–§6 (triage: 68/68placeholder rows 100.0-paired, brief premise CONFIRMED exactly; band pick 9 seats/42 ext hits; per-seat
table; collision screen incl. live open-PR added-identifier counts 237-class/160/130/130/268/136/51;
conservation 60/60/5 dry-proven before apply); apply LANDED-LOCAL on
card-w22questvm-f6: payload6b90b6f1b(SINGLE commit, parent ==9925c2c50verified by this kit's card; 5 files, 60+/60−, diffstatre-walked by this kit's card; battery receipts quoted above are ITS commit body/harvest §6 prints,
transcribed, not this card's claims — this lane ran ZERO builds). This kit's card re-derived (zero-build
static legs, scratch clone @
9925c2c50): all 5 payload paths + 8/8 unique placeholder rows by addr+size key(exactly-1-old) + 8/8 new-name rows exactly-0-new @master + name-string-only pair-proof 8/8 + 0/8 new-token
whole-tree claims + 0/9 config.yml rider hits + KEEP row byte-present pre/post + strict-apply rc=0 AND
git apply -3rc=0 with 5f/60+/60− preserved + post-apply residue 0 + markers 0 + post-refetch re-derive +two guard negative-controls (absent token ⇒ reported miss; wrong addr+size pairing ⇒ failed) + sibling-merge
drift simulation (one band seat pre-renamed locally ⇒ the 8/8 exactly-1-old guard HALTS with superseded
diagnosis; reset) + double-compose guard simulation against an ops sandbox (stray pack11-8 ⇒ HALT; absent ⇒
pass) + vacuous-mask and REFUTED-class phrasing censuses both 0. Disclosed refuted premises found during
composition hygiene (checks run against fresh captures; both corrected forward, not waited on): the
the grammar-source kit9 sheet's interpreter-path literal carried an asterisk-mask compose artifact (this kit
carries the corrected path, live-verified
--versionrc=0) and its KEEP-row leg used agit grepflag formgit grepdoes not accept (rc=129 measured THIS card; non-abort echo ⇒ would mis-report at GO-day; this kit'ssheet uses the corrected blob+
grep -xFpattern, verified 1/1).— Scott Lowry [email protected]
Composed by Scott's Hermes agent (AI-assisted); reviewed and submitted by Scott Lowry.