Skip to content

[Automated] Update aws CLI Options - #5168

Closed
thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-aws
Closed

thomhurst wants to merge 1 commit into
mainfrom
automated/update-cli-options-aws

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

This PR contains automatically generated updates to aws CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Command coverage

Command coverage report:

  • aws (aws-cli/2.36.46 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24): 19332 commands, tree f93794b2c00ae699042c1352ec8a5b09781ff6601808106f970f1bb1890110bc
    • Baseline comparison: 18920 commands at aws-cli/2.36.34 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24 -> 19332 commands at aws-cli/2.36.46 Python/3.14.6 Linux/6.17.0-1022-azure exe/x86_64.ubuntu.24
    • Added: aws accessanalyzer create-analyzer, aws accessanalyzer create-service-linked-analyzer, aws accessanalyzer update-analyzer, aws acm list-certificates, aws agent-registry-control create-registry, aws agent-registry-control update-registry, aws aiops create-investigation-group, aws aiops update-investigation-group, aws appconfig update-experiment-definition, aws appconfig update-extension, aws appflow list-connector-entities, aws appflow reset-connector-metadata-cache, aws application-signals create-service-level-objective, aws application-signals update-service-level-objective, aws apprunner update-service, aws appstream create-fleet, aws appstream create-image-builder, aws appstream update-app-block-builder, aws appstream update-fleet, aws autoscaling create-auto-scaling-group, aws autoscaling put-scaling-policy, aws autoscaling start-instance-refresh, aws autoscaling update-auto-scaling-group, aws b2bi create-transformer, aws b2bi update-transformer, aws backupsearch start-search-job, aws batch cancel-jobs, aws batch create-scheduling-policy, aws batch register-job-definition, aws batch submit-job, aws batch submit-service-job, aws batch terminate-jobs, aws batch terminate-service-jobs, aws batch update-scheduling-policy, aws bedrock create-model-customization-job, aws bedrock create-model-import-job, aws bedrock create-model-invocation-job, aws bedrock-agent create-flow, aws bedrock-agent update-flow, aws bedrock-agent-runtime retrieve, aws bedrock-agent-runtime retrieve-and-generate, aws bedrock-agentcore start-browser-session, aws bedrock-agentcore-control create-agent-runtime, aws bedrock-agentcore-control create-consent-portal, aws bedrock-agentcore-control create-gateway, aws bedrock-agentcore-control create-harness, aws bedrock-agentcore-control create-payment-manager, aws bedrock-agentcore-control create-registry, aws bedrock-agentcore-control delete-consent-portal, aws bedrock-agentcore-control get-consent-portal (+362 more; see manifest)

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Sep 16, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T07:09:33.573825Z 5f94679 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Caution

CodeRabbit couldn't post its review summary.

Error details
Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"} - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@thomhurst

Copy link
Copy Markdown
Owner Author

This refresh replaces closed generated PRs #5163, #5157, #5155, and #5148. It includes the source fixes from #5150, #5159, and #5165 for issues #5149, #5158, and #5164.

Verified against main at 1527863: provenance matches; AWS CLI 2.36.46 has 19,332 commands without baseline removals. SNS AttributeName and the single allowed VPN Type now use strings; ACM Contact retains its two genuine enum values; required collections, Logs argument arity, and ingress/egress handling remain present. Generation and solution build passed. Waiting for this PR's CI and reviews before merge.

@github-actions

Copy link
Copy Markdown
Contributor

Review: Automated AWS CLI options update

This is a large autogenerated regeneration of the aws CLI options package (18,920 -> 19,332 commands). Since this PR is entirely machine-generated output, I focused the review on generated-output health rather than line-by-line diffing (per repo policy, generated options are never hand-edited).

What I checked

  • Scope of changes: sampled the changed-file list — every file is under src/ModularPipelines.AmazonWebServices/{Enums,Options}/*.Generated.cs plus docs/docs/mp-packages/cli/aws.md. No hand-written source, no PublicAPI.Shipped.txt/PublicAPI.Unshipped.txt baselines touched — consistent with the "generated CLI packages don't track API baselines" rule.
  • Regression check against the recent generator fix: main's most recent commit (fix(generator): respect AWS enum description boundaries #5165) fixed AWS enum description boundaries (prose bleeding across enum bullets). I scanned all 3,890 generated enum files in this PR for the failure signature (abnormally long doc-comment lines, EnumValue entries containing embedded prose/spaces) — found none, so this regeneration is clean against that bug.
  • Spot-checked a newly added command (AwsBedrockCreateModelCustomizationJobOptions, one of the new commands listed in the PR body) — well-formed record, correct [CliOption]/[EnumValue] wiring, validation logic for the CLI-input-JSON/skeleton alternate-input path looks consistent with other generated options classes.
  • Pre-existing scraper artifact, not introduced by this PR: several doc comments (e.g. in the Bedrock file above) carry AWS's terminal-wrapped help text verbatim, including mid-word hyphenation like val- idation, founda- tion-model. I confirmed this same artifact already exists throughout the current main branch (e.g. AwsAcmRequestCertificateOptions.Generated.cs, AwsAppflowCreateFlowOptions.Generated.cs), so it's a longstanding scraper characteristic, not a regression from this regeneration. Worth a separate scraper-fix issue at some point (dehyphenate wrapped text before emitting docs), but not something to hand-patch here.
  • Prior review comments: none exist yet to reconcile — only automated bot placeholders (a still-running Codex review and a CodeRabbit summary that failed to post due to size).

CI status at time of review: Fast fail, Classify changes, Test Deploy to GitHub Pages, analyzers/CodeQL, and trim and Native AOT completed successfully (core build/full-pipeline jobs correctly skipped since only the AWS integration package changed). generated integration (ModularPipelines.AmazonWebServices) and claude-review were still in progress at review time — please confirm both are green before merging.

No blocking findings from this review.

@thomhurst

Copy link
Copy Markdown
Owner Author

@coderabbitai review

The previous summary failed GitHub's 65,536-character comment limit. Please keep the summary compact and report any actionable findings separately. The authoritative generated snapshot and source-fix provenance are described in comment 5693398595.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

@thomhurst I will review #5168. I will keep the summary compact and report actionable findings separately.

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@thomhurst

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

The completed review's summary could not be posted because it exceeded GitHub's comment size limit. Please provide a compact final result and any actionable findings, without enumerating the generated file list.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

@thomhurst I will run a full review of #5168. I will keep the final summary compact and report actionable findings separately. I will not list generated files.

⚠️ Action not completed

No files to review.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Caution

CodeRabbit couldn't post its review summary.

Error details
Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"} - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@thomhurst

Copy link
Copy Markdown
Owner Author

CodeRabbit's full-review retry reports no files to review (comment 5693447157), and its check is SUCCESS on 5f94679. Its summary still exceeds GitHub's 65,536-character limit; this is a publication limitation, with no inline findings or review threads posted.

Generated-output review is covered by the manual contract/provenance checks above and Claude's completed review (5693409682). The pre-existing wrapped-help hyphenation noted there remains unchanged. Codex's review is still running; merge will wait for its result.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review


P1 Badge Keep pagination counts out of secret masking

When this command is used with MaxResults = 1, the new attribute causes SecretProvider.NormalizeSecret to register the string "1" with both framework and native CI masking, so every occurrence of that common digit in subsequent logs can be redacted. The option description merely mentions a nextToken value; it does not make the page size secret, and the same false positive was generated for six other MaxResults properties. Fix the generator's description-based secret detection and regenerate rather than shipping these attributes.

AGENTS.md reference: AGENTS.md:L34-L34

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@thomhurst

Copy link
Copy Markdown
Owner Author

Closing this autogenerated PR for the correctness finding in comment 5693471703. Issue #5169 tracks the generic secret-description detector fix: pagination counts must not acquire SecretValue merely because their descriptions mention a nextToken value.

Generation and all 14 checks passed, but the current output can mask ordinary digits in logs. Repository policy requires a separate source fix on main and fresh regeneration; this generated branch will not be repaired in place. #4367 remains blocked on the corrected replacement snapshot.

@thomhurst

Copy link
Copy Markdown
Owner Author

Source PR #5170 fixes the description-based count classification in 8b316eb. It includes all seven affected AWS descriptions and shared-detector regressions. The baseline reproduced 12 failures; all 471 focused tests now pass. Scoped formatting and the Release generator solution build pass with zero warnings/errors.

Fresh AWS/gcloud generation will run after source CI/reviews pass and #5170 merges. This issue remains open until the regenerated AWS output and #4367 are verified.

@thomhurst

Copy link
Copy Markdown
Owner Author

Fresh replacement: #5174, regenerated from main f408d8c after the source fixes. It preserves all 19,332 AWS commands and fixes the secret-metadata finding from #5168. Integration CI and reviews must pass before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant